search

home-assistant / core

:house_with_garden: Open source home automation that puts local control and privacy first.
https://www.home-assistant.io
Apache License 2.0
73.93k stars 30.99k forks source link

Area not attached to disks for Synology DSM #63557

Closed Mariusthvdb closed 2 years ago

Mariusthvdb commented 2 years ago

The problem

Areas are supposed to be attached to all devices of a main integrations config. However, using the Synology DSM integration, only the Synology NAS itself gets the Area, where none of the contained disks do, nor does the Volume device.:

Schermafbeelding 2022-01-06 om 17 15 54

What version of Home Assistant Core has the issue?

2022.2.0.dev20220106

What was the last working version of Home Assistant Core?

never?

What type of installation are you running?

Home Assistant OS

Integration causing the issue

Synology DSM

Link to integration documentation on our website

https://www.home-assistant.io/integrations/synology_dsm/

Example YAML snippet

No response

Anything in the logs that might be useful for us?

No response

Additional information

No response

probot-home-assistant[bot] commented 2 years ago

synology_dsm documentation synology_dsm source (message by IssueLinks)

probot-home-assistant[bot] commented 2 years ago

Hey there @hacf-fr, @quentame, @mib1185, mind taking a look at this issue as it has been labeled with an integration (synology_dsm) you are listed as a code owner for? Thanks! (message by CodeOwnersMention)

mib1185 commented 2 years ago

When setting up the integration, you were asked to assign the created device entries to areas. There is no inheritances of area assignments. Further you can change the assignment at every time.

Mariusthvdb commented 2 years ago

Yes I guess that's exactly my point. Shouldn't there be inheritance?

mib1185 commented 2 years ago

OK, so this is not an issue report, but - more or less - a feature request (and honestly not related to the Synology DSM integration itself). Please use the feature request section in our forum to place this request. Thanks

Mariusthvdb commented 2 years ago

no, not a feature request. I don't mind at all. Was merely thinking to help out.

If you say this is as per design, it's ok.

It's just a bit surprising because all disk devices clearly are 'parented' by the main device, and as such should have inherited the area. Seems a bit weird to be able to set different areas for each of the included disks?

And how is this Not related to the Synology Integration? I would say it is clearly listed....

mib1185 commented 2 years ago

If you say this is as per design, it's ok.

Yes, it is the current design, that the user can assign areas as they want.

It's just a bit surprising because all disk devices clearly are 'parented' by the main device, and as such should have inherited the area. Seems a bit weird to be able to set different areas for each of the included disks?

For now there is no concept of inhering device properties from parent device in HA. It is not as easy, since this concept should work for all possible scenario - for example, an integration can add a device for the gateway device (eq. a router or Smart-HUB) and also for each real device (eg. tracked devices, thermostats, bulbs, ..) which can be in different areas, but are child of the main device.

And how is this Not related to the Synology Integration? I would say it is clearly listed....

The area concept is not related to any specific integration - it is a core feature - so yes, it is not direct related to the Synology DSM integration (or any other integration)