home-assistant / core

:house_with_garden: Open source home automation that puts local control and privacy first.
https://www.home-assistant.io
Apache License 2.0
72.81k stars 30.51k forks source link

Flaky tests in iaqualink #63583

Closed epenet closed 2 years ago

epenet commented 2 years ago

The problem

When running full CI jobs, iaqualink sometimes fails tests. An example can be seen in https://github.com/home-assistant/core/runs/4736125447?check_suite_focus=true

=========================== short test summary info ============================
FAILED tests/components/iaqualink/test_init.py::test_setup_all_good_all_device_types[pyloop]

What version of Home Assistant Core has the issue?

core-2022.02.0.dev0

What was the last working version of Home Assistant Core?

No response

What type of installation are you running?

Home Assistant Core

Integration causing the issue

iaqualink

Link to integration documentation on our website

No response

Example YAML snippet

No response

Anything in the logs that might be useful for us?

No response

Additional information

No response

probot-home-assistant[bot] commented 2 years ago

iaqualink documentation iaqualink source (message by IssueLinks)

probot-home-assistant[bot] commented 2 years ago

Hey there @flz, mind taking a look at this issue as it has been labeled with an integration (iaqualink) you are listed as a code owner for? Thanks! (message by CodeOwnersMention)

flz commented 2 years ago

My guess at first glance is that the device number generator is causing name collisions.