Samsung Q80A TV state cycles between on and off many times per hour

jeffdeal commented 2 years ago

The problem

I have a Samsung Q80A television using the Samsung TV integration. I have an automation in Node Red that listens to the state of the TV to turn on a LED strip backlight. I noticed that the light was turning on and off by itself, so I checked the logs and discovered the TV state is cycling between "on" and "off" several times per hour, even when the TV is off. The cycle repeats about every 5 minutes, with the "on" period lasting around 30 seconds. I have temporarily worked around this by only triggering when the TV is detected on for longer than one minute.

What version of Home Assistant Core has the issue?

2022.2.2

What was the last working version of Home Assistant Core?

Unsure

What type of installation are you running?

Home Assistant OS

Integration causing the issue

Samsung TV

Link to integration documentation on our website

https://www.home-assistant.io/integrations/samsungtv/

Diagnostics information

config_entry-samsungtv-810d13a64568c812641b1f2ea101c578.json.txt

Example YAML snippet

No response

Anything in the logs that might be useful for us?

No response

Additional information

No response

probot-home-assistant[bot] commented 2 years ago

Hey there @escoand, @chemelli74, mind taking a look at this issue as it has been labeled with an integration (samsungtv) you are listed as a code owner for? Thanks! _{^{(message by CodeOwnersMention)}}

samsungtv documentation samsungtv source _{^{(message by IssueLinks)}}

chemelli74 commented 2 years ago

Please add the following to configuration.yaml , restart HA, and post the log:

logger:
  default: warning
  logs:
    homeassistant.components.samsungtv: debug
    samsungtvws: debug
    samsungctl: debug

Note: it is better to drag the log into the comment (which will add it as an attachment) and not copy paste as it is hard to read logs in GitHub.

jeffdeal commented 2 years ago

Log attached.

home-assistant.log

The HA logbook shows on-off pairs as follows:

16:47:30 on 16:48:08 off

16:52:30 on 16:53:08 off

16:57:30 on 16:58:08 off

17:02:30 turned on manually 17:04:38 turned off manually

17:08:30 on 17:08:58 off

Thanks, Jeff

chemelli74 commented 2 years ago

How many TVs do you own ?

jeffdeal commented 2 years ago

Three total. The Q80A that is reporting waking up is the newest, with the IP ending in 102. I also have a N5200 series TV with IP ending in 168, and a C5000 series.

Jeff

From: Simone Chemelli @.> Sent: Monday, February 7, 2022 5:28 PM To: home-assistant/core @.> Cc: jeffdeal @.>; Author @.> Subject: Re: [home-assistant/core] Samsung Q80A TV state cycles between on and off many times per hour (Issue #65908)

How many TVs do you own ?

— Reply to this email directly, view it on GitHubhttps://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fhome-assistant%2Fcore%2Fissues%2F65908%23issuecomment-1031999834&data=04%7C01%7C%7C3a280d2a04d9435e5fe308d9ea892d9e%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C637798697180227790%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&sdata=5r678cz8kuHR9oM%2Fqhqu9HJN2CU3URU3gQop1BdndaM%3D&reserved=0, or unsubscribehttps://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FARIKP2OAWKLV26ZJO5KMUPLU2BBRDANCNFSM5NVOIFIA&data=04%7C01%7C%7C3a280d2a04d9435e5fe308d9ea892d9e%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C637798697180227790%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&sdata=nwEDErjh6xnANkrnKpM0UVVE%2FB21fGpoUlqYD4Xb%2FGY%3D&reserved=0. Triage notifications on the go with GitHub Mobile for iOShttps://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fapps.apple.com%2Fapp%2Fapple-store%2Fid1477376905%3Fct%3Dnotification-email%26mt%3D8%26pt%3D524675&data=04%7C01%7C%7C3a280d2a04d9435e5fe308d9ea892d9e%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C637798697180227790%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&sdata=JqMP4W3BFkRNmUfMSpuyq%2BT0vgmZfIG0xhPS17JriMk%3D&reserved=0 or Androidhttps://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fplay.google.com%2Fstore%2Fapps%2Fdetails%3Fid%3Dcom.github.android%26referrer%3Dutm_campaign%253Dnotification-email%2526utm_medium%253Demail%2526utm_source%253Dgithub&data=04%7C01%7C%7C3a280d2a04d9435e5fe308d9ea892d9e%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C637798697180227790%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&sdata=5JiTbeFuo%2B1eri0I7P3dpmaRzGZc6EdKXo07yUZ40Vc%3D&reserved=0. You are receiving this because you authored the thread.Message ID: @.***>

jeffdeal commented 2 years ago

I see there's been some activity in the release notes around the samsungtv integration. I turned logging back on and captured the logs again through three on-off cycles where the TV is reported as turning on when nothing visibly happens.

home-assistant.log

chemelli74 commented 2 years ago

Sorry @jeffdeal but I didn't investigate the issue well enough jet. The work from @epenet was about the token refresh management.

Simone

jeffdeal commented 2 years ago

No worries, thanks. I had some time and wanted to be proactive in case the new releases changed something you'd be looking for.

epenet commented 2 years ago

I guess it's linked to zeroconf. Maybe the zeroconf request is "waking up" the TV on some level, and the TV websocket port gets opened. I am guessing it would be fixed with #64865

2022-02-07 16:47:24 DEBUG (MainThread) [homeassistant.components.samsungtv] Samsung device found via ZEROCONF: ZeroconfServiceInfo(host='192.168.1.102'...
2022-02-07 16:52:24 DEBUG (MainThread) [homeassistant.components.samsungtv] Samsung device found via ZEROCONF: ZeroconfServiceInfo(host='192.168.1.102'...
2022-02-07 16:57:24 DEBUG (MainThread) [homeassistant.components.samsungtv] Samsung device found via ZEROCONF: ZeroconfServiceInfo(host='192.168.1.102'...
2022-02-07 17:02:24 DEBUG (MainThread) [homeassistant.components.samsungtv] Samsung device found via ZEROCONF: ZeroconfServiceInfo(host='192.168.1.102'...
2022-02-07 17:08:24 DEBUG (MainThread) [homeassistant.components.samsungtv] Samsung device found via ZEROCONF: ZeroconfServiceInfo(host='192.168.1.102'...

jeffdeal commented 2 years ago

Ah, I see. Makes sense. Thanks for the info! I'll eagerly await the fix.

DanLomb commented 2 years ago

I noticed I had the same on off problem and that it started after I started DLNA Digital Media Renderer intagration on a different Samsung TV. Problem went away after I disabled the DLNA Digital Media Renderer. I hope that helps.

jeffdeal commented 2 years ago

I've uninstalled the DLNA integration and it has not changed the behavior in my case. My Q80A status still cycles between on and off every 5 minutes or so. I've been told that a change in Zeroconf is likely to fix it.

From: DanLomb @.> Sent: Monday, February 28, 2022 7:29 AM To: home-assistant/core @.> Cc: jeffdeal @.>; Mention @.> Subject: Re: [home-assistant/core] Samsung Q80A TV state cycles between on and off many times per hour (Issue #65908)

I noticed I had the same on off problem and that it started after I started DLNA Digital Media Renderer intagration on a different Samsung TV. Problem went away after I disabled the DLNA Digital Media Renderer. I hope that helps.

— Reply to this email directly, view it on GitHubhttps://nam12.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fhome-assistant%2Fcore%2Fissues%2F65908%23issuecomment-1054207741&data=04%7C01%7C%7C85fda5ce0b68465f334d08d9fab5e73e%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C637816481433730944%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&sdata=IamW6mJYvbB1W4cDEXhPc13RMzoD3Y%2B0bRBXmEK7l%2BY%3D&reserved=0, or unsubscribehttps://nam12.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FARIKP2ONTSVJ4IOZ3TALD4DU5NTA5ANCNFSM5NVOIFIA&data=04%7C01%7C%7C85fda5ce0b68465f334d08d9fab5e73e%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C637816481433730944%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&sdata=ACjVTLASmR1xj3ZYY7pWdSr3BnQBUfl7VDuddkxt95I%3D&reserved=0. Triage notifications on the go with GitHub Mobile for iOShttps://nam12.safelinks.protection.outlook.com/?url=https%3A%2F%2Fapps.apple.com%2Fapp%2Fapple-store%2Fid1477376905%3Fct%3Dnotification-email%26mt%3D8%26pt%3D524675&data=04%7C01%7C%7C85fda5ce0b68465f334d08d9fab5e73e%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C637816481433730944%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&sdata=m7sQhtN2LxAIS9UKsj2lJgwKJUTXvakRu2qk7iIiRxs%3D&reserved=0 or Androidhttps://nam12.safelinks.protection.outlook.com/?url=https%3A%2F%2Fplay.google.com%2Fstore%2Fapps%2Fdetails%3Fid%3Dcom.github.android%26referrer%3Dutm_campaign%253Dnotification-email%2526utm_medium%253Demail%2526utm_source%253Dgithub&data=04%7C01%7C%7C85fda5ce0b68465f334d08d9fab5e73e%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C637816481433730944%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&sdata=TaeY3qz3S88UzzDTZ4kVJP3zHgKrHNdUlEygJma3ezI%3D&reserved=0. You are receiving this because you were mentioned.Message ID: @.***>

epenet commented 2 years ago

I have created a new PR for this: #67541. If you have the ability to test it it would be great...

jeffdeal commented 2 years ago

I'd be happy to test - I would need some guidance on how to implement the new code. I'm currently running 2022.3.0 core on Hassio.

From: epenet @.> Sent: Thursday, March 3, 2022 6:48 AM To: home-assistant/core @.> Cc: jeffdeal @.>; Mention @.> Subject: Re: [home-assistant/core] Samsung Q80A TV state cycles between on and off many times per hour (Issue #65908)

I have created a new PR for this: #67541https://nam12.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fhome-assistant%2Fcore%2Fpull%2F67541&data=04%7C01%7C%7C08b18f5286354fc9ed0308d9fd0bc03b%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C637819049173126135%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&sdata=AOi4U1J8KYmkUr2WZia3aNjMjn5MD6u0VF1OMRGR8MM%3D&reserved=0. If you have the ability to test it it would be great...

— Reply to this email directly, view it on GitHubhttps://nam12.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fhome-assistant%2Fcore%2Fissues%2F65908%23issuecomment-1057963704&data=04%7C01%7C%7C08b18f5286354fc9ed0308d9fd0bc03b%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C637819049173126135%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&sdata=DzabIBgLj8UnpYwNAOIJ9XUFHs6Gd%2B1sdQEUoTi2Vtc%3D&reserved=0, or unsubscribehttps://nam12.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FARIKP2JSQGPWB47AI42YIJDU6CRJHANCNFSM5NVOIFIA&data=04%7C01%7C%7C08b18f5286354fc9ed0308d9fd0bc03b%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C637819049173126135%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&sdata=DP8QK1VNyYEySfyliH6jHTR0JnaRpkuuuIp%2FDgnliCg%3D&reserved=0. Triage notifications on the go with GitHub Mobile for iOShttps://nam12.safelinks.protection.outlook.com/?url=https%3A%2F%2Fapps.apple.com%2Fapp%2Fapple-store%2Fid1477376905%3Fct%3Dnotification-email%26mt%3D8%26pt%3D524675&data=04%7C01%7C%7C08b18f5286354fc9ed0308d9fd0bc03b%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C637819049173126135%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&sdata=75OLzmIEZogaQqCFL2Sg0DkKY3hc9HD3f%2B8I8sdshYk%3D&reserved=0 or Androidhttps://nam12.safelinks.protection.outlook.com/?url=https%3A%2F%2Fplay.google.com%2Fstore%2Fapps%2Fdetails%3Fid%3Dcom.github.android%26referrer%3Dutm_campaign%253Dnotification-email%2526utm_medium%253Demail%2526utm_source%253Dgithub&data=04%7C01%7C%7C08b18f5286354fc9ed0308d9fd0bc03b%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C637819049173126135%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&sdata=EXrmAMKW6AfV2PgggL74wucjhuX%2FXUwecuAlVHKBeuA%3D&reserved=0. You are receiving this because you were mentioned.Message ID: @.***>

epenet commented 2 years ago

I'm not exactly sure how to test it on a live instance. Maybe something along those lines:

docker exec -it homeassistant bash
cd /usr/src/homeassistant/homeassistant/components/samsungtv/

curl https://raw.githubusercontent.com/epenet/home-assistant-core/samsungtvws-onoff/homeassistant/components/samsungtv/__init__.py > __init__.py
curl https://raw.githubusercontent.com/epenet/home-assistant-core/samsungtvws-onoff/homeassistant/components/samsungtv/bridge.py > bridge.py
curl https://raw.githubusercontent.com/epenet/home-assistant-core/samsungtvws-onoff/homeassistant/components/samsungtv/config_flow.py > config_flow.py
curl https://raw.githubusercontent.com/epenet/home-assistant-core/samsungtvws-onoff/homeassistant/components/samsungtv/diagnostics.py > diagnostics.py
curl https://raw.githubusercontent.com/epenet/home-assistant-core/samsungtvws-onoff/homeassistant/components/samsungtv/manifest.py > manifest.py
curl https://raw.githubusercontent.com/epenet/home-assistant-core/samsungtvws-onoff/homeassistant/components/samsungtv/media_player.py > media_player.py

epenet commented 2 years ago

A much better way to test:

create a new custom_components\samsungtv folder in your HA config folder
copy all the files (including the translations) into the new folder

edit custom_components\samsungtv\manifest.json to add a new version key:

{
"domain": "samsungtv",
"name": "Samsung Smart TV",
"version": "2022.4.0-dev",
"documentation": "https://www.home-assistant.io/integrations/samsungtv",
"...",
}

jeffdeal commented 2 years ago

Now we're talking... I can do that. Can you give me a hint on where to get the necessary files?

From: epenet @.> Sent: Thursday, March 3, 2022 10:32 AM To: home-assistant/core @.> Cc: jeffdeal @.>; Mention @.> Subject: Re: [home-assistant/core] Samsung Q80A TV state cycles between on and off many times per hour (Issue #65908)

A much better way to test:

create a new custom_components\samsungtv folder in your HA config folder
copy all the files (including the translations) into the new folder
edit custom_components\samsungtv\manifest.json to add a new key:

{ "domain": "samsungtv", "name": "Samsung Smart TV", "version": "2022.4.0-dev", "documentation": "https://www.home-assistant.io/integrations/samsungtv", "...", }

— Reply to this email directly, view it on GitHubhttps://nam12.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fhome-assistant%2Fcore%2Fissues%2F65908%23issuecomment-1058161167&data=04%7C01%7C%7C8749fa039be04bfd39d108d9fd2b0d17%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C637819183617080853%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&sdata=Mui%2FdLVZ7o3AHVXg8Zpya7Lws6Rc3Is8utaEjZOPamU%3D&reserved=0, or unsubscribehttps://nam12.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FARIKP2JYUKXMHPMVPAKLTF3U6DLRNANCNFSM5NVOIFIA&data=04%7C01%7C%7C8749fa039be04bfd39d108d9fd2b0d17%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C637819183617080853%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&sdata=1trpxpzT4SNfCDd3BId0dirNLBfqMEkQ%2BenrcJEW3Ks%3D&reserved=0. Triage notifications on the go with GitHub Mobile for iOShttps://nam12.safelinks.protection.outlook.com/?url=https%3A%2F%2Fapps.apple.com%2Fapp%2Fapple-store%2Fid1477376905%3Fct%3Dnotification-email%26mt%3D8%26pt%3D524675&data=04%7C01%7C%7C8749fa039be04bfd39d108d9fd2b0d17%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C637819183617080853%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&sdata=2QZtFqSKPJI5btjEUU0OFwQpnzOCvcjnNuhpmszMhLk%3D&reserved=0 or Androidhttps://nam12.safelinks.protection.outlook.com/?url=https%3A%2F%2Fplay.google.com%2Fstore%2Fapps%2Fdetails%3Fid%3Dcom.github.android%26referrer%3Dutm_campaign%253Dnotification-email%2526utm_medium%253Demail%2526utm_source%253Dgithub&data=04%7C01%7C%7C8749fa039be04bfd39d108d9fd2b0d17%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C637819183617080853%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&sdata=VKThy5UFrFKGv4sULSO1h47hFVOxW3goDBf%2FsicdScU%3D&reserved=0. You are receiving this because you were mentioned.Message ID: @.***>

epenet commented 2 years ago

The are on my branch in github: https://github.com/epenet/home-assistant-core/tree/samsungtvws-onoff/homeassistant/components/samsungtv

epenet commented 2 years ago

Maybe this DownGit link works (untested): https://minhaskamal.github.io/DownGit/#/home?url=https://github.com/epenet/home-assistant-core/tree/samsungtvws-onoff/homeassistant/components/samsungtv

Or this one: https://download-directory.github.io/?url=https://github.com/epenet/home-assistant-core/tree/samsungtvws-onoff/homeassistant/components/samsungtv

jeffdeal commented 2 years ago

Thanks - I just downloaded the files, moving them in place now.

From: epenet @.> Sent: Thursday, March 3, 2022 10:41 AM To: home-assistant/core @.> Cc: jeffdeal @.>; Mention @.> Subject: Re: [home-assistant/core] Samsung Q80A TV state cycles between on and off many times per hour (Issue #65908)

Maybe this DownGit link works (untested): https://minhaskamal.github.io/DownGit/#/home?url=https://github.com/epenet/home-assistant-core/tree/samsungtvws-onoff/homeassistant/components/samsungtv https://nam12.safelinks.protection.outlook.com/?url=https%3A%2F%2Fminhaskamal.github.io%2FDownGit%2F%23%2Fhome%3Furl%3Dhttps%3A%2F%2Fgithub.com%2Fepenet%2Fhome-assistant-core%2Ftree%2Fsamsungtvws-onoff%2Fhomeassistant%2Fcomponents%2Fsamsungtv&data=04%7C01%7C%7C91f9ae3846134cc14aa808d9fd2c4903%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C637819188909884404%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&sdata=a8CvZAKr%2FPcbCsBZX2D8trHs858M3bLe9JuZi35sjvU%3D&reserved=0

— Reply to this email directly, view it on GitHubhttps://nam12.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fhome-assistant%2Fcore%2Fissues%2F65908%23issuecomment-1058170153&data=04%7C01%7C%7C91f9ae3846134cc14aa808d9fd2c4903%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C637819188909884404%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&sdata=nfpRNS73sITK6ZS%2F6fyKMqwQbauIYOjrsBPKyPHhiA8%3D&reserved=0, or unsubscribehttps://nam12.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FARIKP2P42QQXV742CLPWGHLU6DMSTANCNFSM5NVOIFIA&data=04%7C01%7C%7C91f9ae3846134cc14aa808d9fd2c4903%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C637819188909884404%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&sdata=Bpn%2B4CH1gqM4LD2jsJcfYZ%2FzRQvfwOA4sGLd3Yg21vQ%3D&reserved=0. Triage notifications on the go with GitHub Mobile for iOShttps://nam12.safelinks.protection.outlook.com/?url=https%3A%2F%2Fapps.apple.com%2Fapp%2Fapple-store%2Fid1477376905%3Fct%3Dnotification-email%26mt%3D8%26pt%3D524675&data=04%7C01%7C%7C91f9ae3846134cc14aa808d9fd2c4903%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C637819188909884404%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&sdata=DJS69%2F9Lla4IANMtDHKelxtGUcKARu06%2BIuZ970OvJw%3D&reserved=0 or Androidhttps://nam12.safelinks.protection.outlook.com/?url=https%3A%2F%2Fplay.google.com%2Fstore%2Fapps%2Fdetails%3Fid%3Dcom.github.android%26referrer%3Dutm_campaign%253Dnotification-email%2526utm_medium%253Demail%2526utm_source%253Dgithub&data=04%7C01%7C%7C91f9ae3846134cc14aa808d9fd2c4903%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C637819188909884404%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&sdata=jKMV4ZzQdAbdyCJyRDwE32eNG%2BwzxxdvrkDbGoyjE4o%3D&reserved=0. You are receiving this because you were mentioned.Message ID: @.***>

jeffdeal commented 2 years ago

I downloaded the files, placed them in a new samsungtv folder in custom_components, edited the manifest.json file as recommended, and restarted the HA core. I've had two on-off sequences in the logbook, so the behavior has not changed. How can I confirm that the new custom_component files are being used? I'm not familiar with the HA architecture, but how would a change within the custom_components folder tell the samsungtv integration to not use the built-in version?

From: epenet @.> Sent: Thursday, March 3, 2022 10:41 AM To: home-assistant/core @.> Cc: jeffdeal @.>; Mention @.> Subject: Re: [home-assistant/core] Samsung Q80A TV state cycles between on and off many times per hour (Issue #65908)

Maybe this DownGit link works (untested): https://minhaskamal.github.io/DownGit/#/home?url=https://github.com/epenet/home-assistant-core/tree/samsungtvws-onoff/homeassistant/components/samsungtv https://nam12.safelinks.protection.outlook.com/?url=https%3A%2F%2Fminhaskamal.github.io%2FDownGit%2F%23%2Fhome%3Furl%3Dhttps%3A%2F%2Fgithub.com%2Fepenet%2Fhome-assistant-core%2Ftree%2Fsamsungtvws-onoff%2Fhomeassistant%2Fcomponents%2Fsamsungtv&data=04%7C01%7C%7C91f9ae3846134cc14aa808d9fd2c4903%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C637819188909884404%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&sdata=a8CvZAKr%2FPcbCsBZX2D8trHs858M3bLe9JuZi35sjvU%3D&reserved=0

— Reply to this email directly, view it on GitHubhttps://nam12.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fhome-assistant%2Fcore%2Fissues%2F65908%23issuecomment-1058170153&data=04%7C01%7C%7C91f9ae3846134cc14aa808d9fd2c4903%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C637819188909884404%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&sdata=nfpRNS73sITK6ZS%2F6fyKMqwQbauIYOjrsBPKyPHhiA8%3D&reserved=0, or unsubscribehttps://nam12.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FARIKP2P42QQXV742CLPWGHLU6DMSTANCNFSM5NVOIFIA&data=04%7C01%7C%7C91f9ae3846134cc14aa808d9fd2c4903%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C637819188909884404%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&sdata=Bpn%2B4CH1gqM4LD2jsJcfYZ%2FzRQvfwOA4sGLd3Yg21vQ%3D&reserved=0. Triage notifications on the go with GitHub Mobile for iOShttps://nam12.safelinks.protection.outlook.com/?url=https%3A%2F%2Fapps.apple.com%2Fapp%2Fapple-store%2Fid1477376905%3Fct%3Dnotification-email%26mt%3D8%26pt%3D524675&data=04%7C01%7C%7C91f9ae3846134cc14aa808d9fd2c4903%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C637819188909884404%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&sdata=DJS69%2F9Lla4IANMtDHKelxtGUcKARu06%2BIuZ970OvJw%3D&reserved=0 or Androidhttps://nam12.safelinks.protection.outlook.com/?url=https%3A%2F%2Fplay.google.com%2Fstore%2Fapps%2Fdetails%3Fid%3Dcom.github.android%26referrer%3Dutm_campaign%253Dnotification-email%2526utm_medium%253Demail%2526utm_source%253Dgithub&data=04%7C01%7C%7C91f9ae3846134cc14aa808d9fd2c4903%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C637819188909884404%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&sdata=jKMV4ZzQdAbdyCJyRDwE32eNG%2BwzxxdvrkDbGoyjE4o%3D&reserved=0. You are receiving this because you were mentioned.Message ID: @.***>

epenet commented 2 years ago

A custom integration with the same name as the core automatically overrides it. The log file should have a note at the top to confirm it has taken effect: 2022-03-03 16:26:46 WARNING (SyncWorker_0) [homeassistant.loader] We found a custom integration samsungtv which has not been tested by Home Assistant. This component might cause stability problems, be sure to disable it if you experience issues with Home Assistant

jeffdeal commented 2 years ago

Looks like I have a typo in the file. Thanks for the explanation of how it works and what I should expect to see in the log. Stand by...

From: epenet @.> Sent: Thursday, March 3, 2022 11:06 AM To: home-assistant/core @.> Cc: jeffdeal @.>; Mention @.> Subject: Re: [home-assistant/core] Samsung Q80A TV state cycles between on and off many times per hour (Issue #65908)

A custom integration with the same name as the core automatically overrides it. The log file should have a note at the top to confirm it has taken effect: 2022-03-03 16:26:46 WARNING (SyncWorker_0) [homeassistant.loader] We found a custom integration samsungtv which has not been tested by Home Assistant. This component might cause stability problems, be sure to disable it if you experience issues with Home Assistant

— Reply to this email directly, view it on GitHubhttps://nam12.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fhome-assistant%2Fcore%2Fissues%2F65908%23issuecomment-1058204228&data=04%7C01%7C%7Ce8b103c38f0a4a46b28508d9fd2fd974%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C637819204214629895%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&sdata=%2Fid02JtDdTnjRJ4G9bI5tAXD8NRddw%2FxzP%2Fgvg8XMYE%3D&reserved=0, or unsubscribehttps://nam12.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FARIKP2PDARLVX3KSUW7LDHDU6DPSHANCNFSM5NVOIFIA&data=04%7C01%7C%7Ce8b103c38f0a4a46b28508d9fd2fd974%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C637819204214629895%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&sdata=JqJTWCd090juGshUR5VINiGftx4w5mEJ%2F531eHCAVRw%3D&reserved=0. Triage notifications on the go with GitHub Mobile for iOShttps://nam12.safelinks.protection.outlook.com/?url=https%3A%2F%2Fapps.apple.com%2Fapp%2Fapple-store%2Fid1477376905%3Fct%3Dnotification-email%26mt%3D8%26pt%3D524675&data=04%7C01%7C%7Ce8b103c38f0a4a46b28508d9fd2fd974%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C637819204214629895%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&sdata=yR3FKuVpl%2B6ttjIPdNZb3fk36L%2Fd%2FKSY%2BQa8YkMSuew%3D&reserved=0 or Androidhttps://nam12.safelinks.protection.outlook.com/?url=https%3A%2F%2Fplay.google.com%2Fstore%2Fapps%2Fdetails%3Fid%3Dcom.github.android%26referrer%3Dutm_campaign%253Dnotification-email%2526utm_medium%253Demail%2526utm_source%253Dgithub&data=04%7C01%7C%7Ce8b103c38f0a4a46b28508d9fd2fd974%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C637819204214629895%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&sdata=Sej8eOdL3OuXrTAaexHACAf8ybJu5tw9CHnvdSdMPYs%3D&reserved=0. You are receiving this because you were mentioned.Message ID: @.***>

epenet commented 2 years ago

Please also adjust your configuration file for logging:

logger:
    ...
    logs:
        ...
        custom_components.samsungtv: debug

jeffdeal commented 2 years ago

Got it. I verified that the custom component is being loaded now, I turned logging on, restarting HA. Should have some observations for you soon. My on-off sequence has been happening about every 5 minutes.

From: epenet @.> Sent: Thursday, March 3, 2022 11:15 AM To: home-assistant/core @.> Cc: jeffdeal @.>; Mention @.> Subject: Re: [home-assistant/core] Samsung Q80A TV state cycles between on and off many times per hour (Issue #65908)

Please also adjust your configuration file for logging:

... logs: ... custom_components.samsungtv: debug

— Reply to this email directly, view it on GitHubhttps://nam12.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fhome-assistant%2Fcore%2Fissues%2F65908%23issuecomment-1058218518&data=04%7C01%7C%7C9aa8905ce2344a8341fe08d9fd310acb%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C637819209338514438%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&sdata=Up8vXNAWP7p2v5Zx0vWIPS4qJxf8rZgLCq480eBdrA0%3D&reserved=0, or unsubscribehttps://nam12.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FARIKP2IVCALRX2LR6SX3KY3U6DQSHANCNFSM5NVOIFIA&data=04%7C01%7C%7C9aa8905ce2344a8341fe08d9fd310acb%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C637819209338514438%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&sdata=xf1%2F6tOd1YqadXDfHq3jCOJ2BVtPfRNqe2%2FFt%2BLICgY%3D&reserved=0. Triage notifications on the go with GitHub Mobile for iOShttps://nam12.safelinks.protection.outlook.com/?url=https%3A%2F%2Fapps.apple.com%2Fapp%2Fapple-store%2Fid1477376905%3Fct%3Dnotification-email%26mt%3D8%26pt%3D524675&data=04%7C01%7C%7C9aa8905ce2344a8341fe08d9fd310acb%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C637819209338514438%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&sdata=BfIDRVwS%2BkQU734vUdB1uwAhRaXzUBlEHS2fX35VSgY%3D&reserved=0 or Androidhttps://nam12.safelinks.protection.outlook.com/?url=https%3A%2F%2Fplay.google.com%2Fstore%2Fapps%2Fdetails%3Fid%3Dcom.github.android%26referrer%3Dutm_campaign%253Dnotification-email%2526utm_medium%253Demail%2526utm_source%253Dgithub&data=04%7C01%7C%7C9aa8905ce2344a8341fe08d9fd310acb%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C637819209338514438%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&sdata=cDFR80rhKQ%2B7sVNf5D8GFPZJadGZRrCoXTXfFECK8OA%3D&reserved=0. You are receiving this because you were mentioned.Message ID: @.***>

jeffdeal commented 2 years ago

Initial results look good! The on-off periodic events in the logbook for my Q80A have stopped. I was able to use the HA media player to turn both of my smart TVs on and off, control volume, input source, mute, etc.

There are lots of these events in the log:

2022-03-03 11:41:22 DEBUG (SyncWorker_8) [custom_components.samsungtv] Create SamsungTVLegacyBridge for name (192.168.1.127) 2022-03-03 11:41:26 DEBUG (MainThread) [custom_components.samsungtv] Checking if TV 192.168.1.174 is on using device info 2022-03-03 11:41:26 DEBUG (MainThread) [custom_components.samsungtv] Checking if TV 192.168.1.168 is on using device info

I'd be glad to do anything else that would be helpful.

From: epenet @.> Sent: Thursday, March 3, 2022 11:15 AM To: home-assistant/core @.> Cc: jeffdeal @.>; Mention @.> Subject: Re: [home-assistant/core] Samsung Q80A TV state cycles between on and off many times per hour (Issue #65908)

Please also adjust your configuration file for logging:

... logs: ... custom_components.samsungtv: debug

— Reply to this email directly, view it on GitHubhttps://nam12.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fhome-assistant%2Fcore%2Fissues%2F65908%23issuecomment-1058218518&data=04%7C01%7C%7C9aa8905ce2344a8341fe08d9fd310acb%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C637819209338514438%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&sdata=Up8vXNAWP7p2v5Zx0vWIPS4qJxf8rZgLCq480eBdrA0%3D&reserved=0, or unsubscribehttps://nam12.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FARIKP2IVCALRX2LR6SX3KY3U6DQSHANCNFSM5NVOIFIA&data=04%7C01%7C%7C9aa8905ce2344a8341fe08d9fd310acb%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C637819209338514438%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&sdata=xf1%2F6tOd1YqadXDfHq3jCOJ2BVtPfRNqe2%2FFt%2BLICgY%3D&reserved=0. Triage notifications on the go with GitHub Mobile for iOShttps://nam12.safelinks.protection.outlook.com/?url=https%3A%2F%2Fapps.apple.com%2Fapp%2Fapple-store%2Fid1477376905%3Fct%3Dnotification-email%26mt%3D8%26pt%3D524675&data=04%7C01%7C%7C9aa8905ce2344a8341fe08d9fd310acb%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C637819209338514438%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&sdata=BfIDRVwS%2BkQU734vUdB1uwAhRaXzUBlEHS2fX35VSgY%3D&reserved=0 or Androidhttps://nam12.safelinks.protection.outlook.com/?url=https%3A%2F%2Fplay.google.com%2Fstore%2Fapps%2Fdetails%3Fid%3Dcom.github.android%26referrer%3Dutm_campaign%253Dnotification-email%2526utm_medium%253Demail%2526utm_source%253Dgithub&data=04%7C01%7C%7C9aa8905ce2344a8341fe08d9fd310acb%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C637819209338514438%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&sdata=cDFR80rhKQ%2B7sVNf5D8GFPZJadGZRrCoXTXfFECK8OA%3D&reserved=0. You are receiving this because you were mentioned.Message ID: @.***>

epenet commented 2 years ago

I suggest that you add a comment on #67541 to confirm that you have tested it locally and it's working as expected.

epenet commented 2 years ago

You will need to remember to remove the custom component when the patch is released...

jeffdeal commented 2 years ago

Thanks for the reminder. I added a comment to the issue as well. This has allowed me to remove the 90 second delay for turning on the backlight. Very nice, thank you!

From: epenet @.> Sent: Thursday, March 3, 2022 11:56 AM To: home-assistant/core @.> Cc: jeffdeal @.>; Mention @.> Subject: Re: [home-assistant/core] Samsung Q80A TV state cycles between on and off many times per hour (Issue #65908)

You will need to remember to remove the custom component when the patch is released...

— Reply to this email directly, view it on GitHubhttps://nam12.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fhome-assistant%2Fcore%2Fissues%2F65908%23issuecomment-1058258767&data=04%7C01%7C%7Cc9a640f2a74049d8392308d9fd36b97f%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C637819233751044529%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&sdata=PFpk2q4RaNUzq2Rg7Skr81nZ%2BEoyEOvJjsALhboNQXM%3D&reserved=0, or unsubscribehttps://nam12.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FARIKP2OIF76CFH7Q4WL3FI3U6DVKZANCNFSM5NVOIFIA&data=04%7C01%7C%7Cc9a640f2a74049d8392308d9fd36b97f%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C637819233751044529%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&sdata=kuCaTXdeVGPpgCcXKGqojHEUpE1xsDF%2Fx%2BjOOOGwREI%3D&reserved=0. Triage notifications on the go with GitHub Mobile for iOShttps://nam12.safelinks.protection.outlook.com/?url=https%3A%2F%2Fapps.apple.com%2Fapp%2Fapple-store%2Fid1477376905%3Fct%3Dnotification-email%26mt%3D8%26pt%3D524675&data=04%7C01%7C%7Cc9a640f2a74049d8392308d9fd36b97f%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C637819233751201221%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&sdata=XKqAKQeUZEUbuDSX8%2BmlQlV6iBg0gC08zSq%2BPZcnFQk%3D&reserved=0 or Androidhttps://nam12.safelinks.protection.outlook.com/?url=https%3A%2F%2Fplay.google.com%2Fstore%2Fapps%2Fdetails%3Fid%3Dcom.github.android%26referrer%3Dutm_campaign%253Dnotification-email%2526utm_medium%253Demail%2526utm_source%253Dgithub&data=04%7C01%7C%7Cc9a640f2a74049d8392308d9fd36b97f%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C637819233751201221%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&sdata=%2BX9cXwWgK2HRGtqJPKfte4Tm8Iv0EWtSTvSQ9C2CjOo%3D&reserved=0. You are receiving this because you were mentioned.Message ID: @.***>

epenet commented 2 years ago

The patch has been merged, but it is too interwined with the latest refactoring to be tagged in a patch release. It will be available in 2022.4 Feel free to use it as a custom component until then...

jeffdeal commented 2 years ago

I will eagerly await 2022.4 and in the meantime will enjoy the custom component. Thanks for all your efforts!

From: epenet @.> Sent: Thursday, March 3, 2022 2:11 PM To: home-assistant/core @.> Cc: jeffdeal @.>; Mention @.> Subject: Re: [home-assistant/core] Samsung Q80A TV state cycles between on and off many times per hour (Issue #65908)

The patch has been merged, but it is too interwined with the latest refactoring to be tagged in a patch release. It will be available in 2022.4 Feel free to use it as a custom component until then...

— Reply to this email directly, view it on GitHubhttps://nam12.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fhome-assistant%2Fcore%2Fissues%2F65908%23issuecomment-1058394946&data=04%7C01%7C%7C4f59e149802a46fea8e208d9fd49a0ab%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C637819314932928917%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&sdata=hMFtl05CXuX2moivT%2BJwUFEEtIkJhybrs2E1%2F%2BpiRQg%3D&reserved=0, or unsubscribehttps://nam12.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FARIKP2JRUDWG3WX5KWNVEC3U6EFGHANCNFSM5NVOIFIA&data=04%7C01%7C%7C4f59e149802a46fea8e208d9fd49a0ab%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C637819314932928917%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&sdata=GEYWXVwzbq4GAh7AoGeKu7IBqVi9UBG9ab5ashTegIw%3D&reserved=0. Triage notifications on the go with GitHub Mobile for iOShttps://nam12.safelinks.protection.outlook.com/?url=https%3A%2F%2Fapps.apple.com%2Fapp%2Fapple-store%2Fid1477376905%3Fct%3Dnotification-email%26mt%3D8%26pt%3D524675&data=04%7C01%7C%7C4f59e149802a46fea8e208d9fd49a0ab%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C637819314932928917%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&sdata=YAx319dHEZ0oxx5E%2FTnrqFqtvpWxHbtWkYN7cT0AB8Y%3D&reserved=0 or Androidhttps://nam12.safelinks.protection.outlook.com/?url=https%3A%2F%2Fplay.google.com%2Fstore%2Fapps%2Fdetails%3Fid%3Dcom.github.android%26referrer%3Dutm_campaign%253Dnotification-email%2526utm_medium%253Demail%2526utm_source%253Dgithub&data=04%7C01%7C%7C4f59e149802a46fea8e208d9fd49a0ab%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C637819314933085137%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&sdata=6kh42SwmRGBdlq6qibDdsPjjKSfjKbGBdKHMP0H25dM%3D&reserved=0. You are receiving this because you were mentioned.Message ID: @.***>

jeffdeal commented 2 years ago

All I did was just insert the "version" key within the existing code. The rest of it stays the same. Be precise when you put the key in, I mistakenly had the colon within the quotes and of course that won't work. You can check to make sure the component is being loaded in the HA log after a restart.

From: matteo @.> Sent: Saturday, March 5, 2022 7:26 AM To: home-assistant/core @.> Cc: jeffdeal @.>; Mention @.> Subject: Re: [home-assistant/core] Samsung Q80A TV state cycles between on and off many times per hour (Issue #65908)

A much better way to test:

create a new custom_components\samsungtv folder in your HA config folder
copy all the files (including the translations) into the new folder
edit custom_components\samsungtv\manifest.json to add a new version key:

{ "domain": "samsungtv", "name": "Samsung Smart TV", "version": "2022.4.0-dev", "documentation": "https://www.home-assistant.io/integrations/samsungtv", "...", }

[image]https://nam12.safelinks.protection.outlook.com/?url=https%3A%2F%2Fuser-images.githubusercontent.com%2F6771947%2F156597687-acca540f-5ccf-458e-b3e0-92c480384f8f.png&data=04%7C01%7C%7Cd2e9b459be0d4bbfb36508d9fea357bc%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C637820799772051314%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&sdata=8id7r7lGgWpvwqNt%2BV98OrX5J5Wi5qAw07wU12l8mhE%3D&reserved=0

i must delete all the code on manifest.json and insert new code?

— Reply to this email directly, view it on GitHubhttps://nam12.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fhome-assistant%2Fcore%2Fissues%2F65908%23issuecomment-1059754421&data=04%7C01%7C%7Cd2e9b459be0d4bbfb36508d9fea357bc%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C637820799772051314%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&sdata=J9WtHBUW5NwGYtS1AqCwOEq9pOj%2BaqZHwpNgjS%2FWsOs%3D&reserved=0, or unsubscribehttps://nam12.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FARIKP2NHXELXVETJVLD4GNTU6NHGNANCNFSM5NVOIFIA&data=04%7C01%7C%7Cd2e9b459be0d4bbfb36508d9fea357bc%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C637820799772051314%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&sdata=UKSGrcMORArrDRFtm%2B56MtHd6QN9jheaB%2BJkOgdkJq0%3D&reserved=0. Triage notifications on the go with GitHub Mobile for iOShttps://nam12.safelinks.protection.outlook.com/?url=https%3A%2F%2Fapps.apple.com%2Fapp%2Fapple-store%2Fid1477376905%3Fct%3Dnotification-email%26mt%3D8%26pt%3D524675&data=04%7C01%7C%7Cd2e9b459be0d4bbfb36508d9fea357bc%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C637820799772051314%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&sdata=GARnQCo6zlExNdOJyy8FmHwON4vikUF%2FhIYtsQ6xXdU%3D&reserved=0 or Androidhttps://nam12.safelinks.protection.outlook.com/?url=https%3A%2F%2Fplay.google.com%2Fstore%2Fapps%2Fdetails%3Fid%3Dcom.github.android%26referrer%3Dutm_campaign%253Dnotification-email%2526utm_medium%253Demail%2526utm_source%253Dgithub&data=04%7C01%7C%7Cd2e9b459be0d4bbfb36508d9fea357bc%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C637820799772051314%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&sdata=vsj76LqyyElspT813rx9Os%2BcKDFZiBo6XiWfnxZKco4%3D&reserved=0. You are receiving this because you were mentioned.Message ID: @.***>

home-assistant / core