This change breaks the AA integration completely when MyFan is enabled:

scidoner commented 2 years ago

Logger: homeassistant.components.advantage_air
Source: components/advantage_air/__init__.py:41
Integration: Advantage Air ([documentation](https://www.home-assistant.io/integrations/advantage_air), [issues](https://github.com/home-assistant/home-assistant/issues?q=is%3Aissue+is%3Aopen+label%3A%22integration%3A+advantage_air%22))
First occurred: 4:33:24 PM (2 occurrences)
Last logged: 4:34:06 PM

Unexpected error fetching Advantage Air data: 'ac1'
Traceback (most recent call last):
  File "/usr/src/homeassistant/homeassistant/helpers/update_coordinator.py", line 187, in _async_refresh
    self.data = await self._async_update_data()
  File "/usr/src/homeassistant/homeassistant/helpers/update_coordinator.py", line 147, in _async_update_data
    return await self.update_method()
  File "/usr/src/homeassistant/homeassistant/components/advantage_air/__init__.py", line 41, in async_get
    return await api.async_get()
  File "/usr/local/lib/python3.9/site-packages/advantage_air/__init__.py", line 54, in async_get
    if data['aircons'][ac]["info"].get("aaAutoFanModeEnabled") and data[ac]["info"].get("fan") == "autoAA":
KeyError: 'ac1'

Originally posted by @scidoner in https://github.com/home-assistant/core/issues/62362#issuecomment-1041240445

probot-home-assistant[bot] commented 2 years ago

advantage_air documentation advantage_air source _{^{(message by IssueLinks)}}

probot-home-assistant[bot] commented 2 years ago

Hey there @bre77, mind taking a look at this issue as it has been labeled with an integration (advantage_air) you are listed as a code owner for? Thanks! _{^{(message by CodeOwnersMention)}}

Bre77 commented 2 years ago

Thanks @scidoner , I will fix this issue.

achuman commented 2 years ago

Came here to report this issue but I see you've already merged a fix, thanks for the quick response!

Bre77 commented 2 years ago

This issue should be fixed in the 2022.03 beta. Please let me know ASAP if you try the beta and it is not fixed. https://rc.home-assistant.io/changelogs/core-2022.3

home-assistant / core

This change breaks the AA integration completely when MyFan is enabled: #66642