home-assistant / core

:house_with_garden: Open source home automation that puts local control and privacy first.
https://www.home-assistant.io
Apache License 2.0
73.74k stars 30.85k forks source link

ClimaCell Integration #66958

Closed marc-gist closed 2 years ago

marc-gist commented 2 years ago

The problem

It appears that ClimaCell no longer exists and that its now called Tomorrow.io, therefore, URLs have changed. Please update the package! :) Thank you!

What version of Home Assistant Core has the issue?

core-2022.2.9

What was the last working version of Home Assistant Core?

No response

What type of installation are you running?

Home Assistant Container

Integration causing the issue

No response

Link to integration documentation on our website

https://www.home-assistant.io/integrations/climacell/

Diagnostics information

n/a

Example YAML snippet

n/a

Anything in the logs that might be useful for us?

Cannot connect when trying to setup the integration. I removed and tried to add it again.

Additional information

No response

probot-home-assistant[bot] commented 2 years ago

climacell documentation climacell source (message by IssueLinks)

probot-home-assistant[bot] commented 2 years ago

Hey there @raman325, mind taking a look at this issue as it has been labeled with an integration (climacell) you are listed as a code owner for? Thanks! (message by CodeOwnersMention)

marc-gist commented 2 years ago

I confirmed. the URL's in const.py need to be updated to api.tomorrow.io thanks.

raman325 commented 2 years ago

thanks, I was hoping that the new tomorrowio integration https://github.com/home-assistant/core/pull/59698 would be merged before we hit this but this will get fixed for 2022.03 because I doubt we will do another patch release

raman325 commented 2 years ago

It appears the old integration and endpoints still work. As linked above, I am trying to move to a new integration with the correct long term domain, but I don't think there is anything to fix here yet

marc-gist commented 2 years ago

It appears the old integration and endpoints still work. As linked above, I am trying to move to a new integration with the correct long term domain, but I don't think there is anything to fix here yet

not true. the domain no longer resolves for me. I have updated the source code myself with the correct FQDN app.tomorrow.io on my install and it is now working. but that will "break" when I next update unless the code here is fixed.

Thanks.

marc-gist commented 2 years ago

that's a quick auto close. has the domain name been properly updated in the code yet? Thank you!

raman325 commented 2 years ago

Yes, the new tomorrowio integration was merged. For V4 API key users, the config entry will automatically migrate to the new integration with the correct domain. For V3 users, you will need to finish the migration by providing a V4 API key but everything else will happen automatically.

are you still using a v3 api key? I am on V4 and the climacell integration still works for me 🤷🏾

marc-gist commented 2 years ago

@raman325 thank you. It appears mine updated just fine. I didn't notice as I simply setup my router to respond with the correct IP using the old dns name to get it working until the code was update :) I assumed when this closed it would have pointed to a change/accepted pull request is all. Thanks again.

raman325 commented 2 years ago

here's the final PR for the migration: https://github.com/home-assistant/core/pull/68156