izone integration broken in recent bridge firmware change

[paulojr]

The problem

Have installed an updated izone bridge where the "unknown" fan speed which has been reported for years for 4 speed systems has finally been addressed however unfortunately this has broken the izone home assistant integration which is not aware of the new 4-speed value. I was able to test the code changes necessary to pickup the new value. They are modifying this section in controller.py and add in 4-speed

_VALID_FAN_MODES = { 'disabled': [Fan.LOW, Fan.MED, Fan.HIGH], 'unknown': [Fan.LOW, Fan.MED, Fan.HIGH, Fan.TOP, Fan.AUTO], '4-speed': [Fan.LOW, Fan.MED, Fan.HIGH, Fan.TOP, Fan.AUTO], '3-speed': [Fan.LOW, Fan.MED, Fan.HIGH, Fan.AUTO], '2-speed': [Fan.LOW, Fan.HIGH, Fan.AUTO], 'var-speed': [Fan.LOW, Fan.MED, Fan.HIGH, Fan.AUTO], } # type: Dict[str, List[Fan]]

Note, this is how the SystemSettings url now responds with the V4.16 firmware.

{"AirStreamDeviceUId":"000049XXXX","DeviceType":"ASH","SysOn":"off","SysMode":"vent","SysFan":"auto","SleepTimer":0,"UnitType":"Mitsubishi Heavy Industries","Supply":"20.1","Setpoint":"22.0","Temp":"24.6","RAS":"zones","CtrlZone":4,"Tag1":"","Tag2":"","Warnings":"none","ACError":" OK","Id":0,"EcoLock":"true","EcoMax":"30.0","EcoMin":"15.0","NoOfConst":1,"NoOfZones":12,"SysType":"320","AirflowLock":"onMin","UnitLocked":"false","FreeAir":"on","FanAuto":"4-speed","OemMake":0}

What version of Home Assistant Core has the issue?

core-2022.4.5

What was the last working version of Home Assistant Core?

core-2022.4.5

What type of installation are you running?

Home Assistant Core

Integration causing the issue

izone

Link to integration documentation on our website

https://www.home-assistant.io/integrations/izone/

Diagnostics information

No response

Example YAML snippet

No response

Anything in the logs that might be useful for us?

I think the issue is very straight forward and I am fairly certainly I am the first with the V4.16 bridge as the firmware was released at my request, so unlikely to need diagnostic logs give the code changes I made work on my installation (portable hass). I also confirmed failure on latest version on raspberry pi however unable to apply a fix.

Additional information

No response

[probot-home-assistant[bot]]

izone documentation izone source _{^{(message by IssueLinks)}}

[probot-home-assistant[bot]]

Hey there @swamp-ig, mind taking a look at this issue as it has been labeled with an integration (izone) you are listed as a code owner for? Thanks! _{^{(message by CodeOwnersMention)}}

[Swamp-Ig]

Would you be able to create a PR for this?

I also really need some people willing to code review iZone changes, I have got a pending PR that's been sitting there unreviewed for ages so it can't get merged.

[paulojr]

Hi Penny Happy to co contribute and also test changes.

Assume pull request should be against dev, I'll set it up as soon as I can.

So far I have setup a fork of the pizone code only. Also need some help working out how to deploy the test code to a raspberry pi install, I've just started migrating from a portable install which allowed open access to the integration code to test changes. Pi setup is quite different. Paul

On Mon, 18 Apr 2022, 11:05 am Penny Wood, @.***> wrote:

Would you be able to create a PR for this?

I also really need some people willing to code review iZone changes, I have got a pending PR that's been sitting there unreviewed for ages so it can't get merged.

— Reply to this email directly, view it on GitHub https://github.com/home-assistant/core/issues/70193#issuecomment-1100995203, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAEHOXRD5O5I5R6N2LATYSTVFSYOXANCNFSM5TUD7Y6Q . You are receiving this because you authored the thread.Message ID: @.***>

[Swamp-Ig]

Yeh PR against dev

With pizone, you can run this directly on a PC, doesn't need to be under linux. That's how I've done my testing=