search

home-assistant / core

:house_with_garden: Open source home automation that puts local control and privacy first.
https://www.home-assistant.io
Apache License 2.0
72.76k stars 30.47k forks source link

Upgrade NUT to Latest 2.8 Version #71669

Closed timnolte closed 2 years ago

timnolte commented 2 years ago

The problem

In order to more fully support more devices and sensors please upgrade NUT to the latest 2.8 release. Specifically, I can't use the usbhid-ups driver with my Tripp Lite UPS even though it is supported with more sensors on the latest 2.8 version of NUT. I am forced to use the older tripplite_usb driver.

What version of Home Assistant Core has the issue?

2022.5.3

What was the last working version of Home Assistant Core?

No response

What type of installation are you running?

Home Assistant OS

Integration causing the issue

Network UPS Tools (NUT)

Link to integration documentation on our website

https://www.home-assistant.io/integrations/nut/

Diagnostics information

No response

Example YAML snippet

No response

Anything in the logs that might be useful for us?

No response

Additional information

No response

probot-home-assistant[bot] commented 2 years ago

nut documentation nut source (message by IssueLinks)

probot-home-assistant[bot] commented 2 years ago

Hey there @bdraco, @ollo69, mind taking a look at this issue as it has been labeled with an integration (nut) you are listed as a code owner for? Thanks! (message by CodeOwnersMention)

frenck commented 2 years ago

I'm confused by this report @timnolte,

the integration integrates with NUT, but doesn't provide NUT itself. There is nothing to upgrade for that matter?

I think you are potentially mixing something up?

../Frenck

timnolte commented 2 years ago

The NUT package has to be installed somehow. If the add-on doesn't install the package then this must be a HassOS distribution issue?

frenck commented 2 years ago

If the add-on

This is the issue tracker of Home Assistant Core, not an add-on... (That was the potential mixup I was referring to).

Please report issues with add-ons with the issue tracker/project of that add-on.

timnolte commented 2 years ago

The add-on is also the integration. It all pointed to here for feedback and support.

frenck commented 2 years ago

The add-on is also the integration

Integrations and add-ons are NOT the same things.

Home Assistant Core itself provides integrations, not add-ons. We don't have NUT installed here, nor do we provide an installation of NUT. Home Assistant Core integrates (hence integration) with a NUT service provided by a NUT server (e.g., provided by an add-on).

Please report issues with add-ons with the add-on source.

timnolte commented 2 years ago

This is not a problem with the add-on. This is a problem with the version of NUT that HassOS has installed. Unless HassOS is not installing that package but the additional add-on is.

timnolte commented 2 years ago

Where does the NUT system package come from? The very fact that there is a Core Integration makes me believe that this is being managed by HA not the other add-on. Which also appears you are the one that maintains it. https://github.com/hassio-addons/addon-nut/releases/tag/v0.10.0

frenck commented 2 years ago

This is a problem with the version of NUT that HassOS has installed.

HassOS doesn't install NUT. And again, this is the issue tracker of Home Assistant Core; this repository provides Home Assistant Core itself and its built-in integrations. There is no NUT in this project/issue tracker.

frenck commented 2 years ago

Which also appears you are the one that maintains it. hassio-addons/addon-nut@v0.10.0 (release)

Sure, if that is what you are using, please report it in the issue tracker there. That project is not related to the Home Assistant Core project.

timnolte commented 2 years ago

I don't understand what the breakdown here is. The Linux package for NUT needs to be updated. Whether it is the integration or add-on that is using it is besides the point.

timnolte commented 2 years ago

@frenck I decided to take a closer look at the add-on repo. So the add-on is actually a Docker container that provides NUT. I can see in the Dockerfile where NUT is being installed. I will open up an issue over there. However, what version of NUT is installed in HA Core for the integration? I would want to be sure they were running the same version for maximum compatibility.

timnolte commented 2 years ago

@frenck OK, after going and searching through the HA Core code I see that HA isn't using the NUT Linux package to serve as a NUT client but using pynut2 in order to access a NUT server. I'll open up the request for the NUT upgrade on the add-on. Thanks!