home-assistant / core

:house_with_garden: Open source home automation that puts local control and privacy first.
https://www.home-assistant.io
Apache License 2.0
71.34k stars 29.88k forks source link

Humidifier entity reports target humidity as humidity in state attributes #72722

Closed vlebourl closed 2 years ago

vlebourl commented 2 years ago

The problem

Some humidifiers may have their own humidity sensor and could report its value as a state attribute. But attribute humidity is already used to report the target humidity here https://github.com/home-assistant/core/blob/45e4dd379b54847174b1f69ca138ba5fe73d24f9/homeassistant/components/humidifier/__init__.py#L168. Renaming that attribute to target_humidity for instance would allow to have humidity as the current humidity if available.

What version of Home Assistant Core has the issue?

core-2022.5.5

What was the last working version of Home Assistant Core?

No response

What type of installation are you running?

Home Assistant OS

Integration causing the issue

humidifier

Link to integration documentation on our website

No response

Diagnostics information

No response

Example YAML snippet

No response

Anything in the logs that might be useful for us?

No response

Additional information

No response

frenck commented 2 years ago

Thank you for reaching out. We use GitHub for tracking issues, not for providing support or tracking feature requests.

If you want to suggest a feature, you should try our Community Forum: Feature Requests.

If you have additional questions, feel free to join our Discord chat server.

Thanks! 👍

vlebourl commented 2 years ago

Sorry, I thought that was an issue. my bad I guess. Cheers

frenck commented 2 years ago

Don't worry about it! We are here to help 👍