home-assistant / core

:house_with_garden: Open source home automation that puts local control and privacy first.
https://www.home-assistant.io
Apache License 2.0
72.41k stars 30.3k forks source link

Garbage data coming from Govee H5052 sensors #76489

Closed adilapi closed 2 years ago

adilapi commented 2 years ago

The problem

Since adding a Govee H5052 with the release of the new Bluetooth/Govee modules, I get wildly nonsensical temperature and humidity values that are nowhere near accurate. The Govee home app reports the correct values. Attached are a few illustrative screenshots.

E9436BBE-659D-4670-9BC2-FC3046001AA8 B0BEB140-0E27-4F0C-BABF-CC4F1255A250 23E88636-FF82-44C3-B866-E7DC8A185604

What version of Home Assistant Core has the issue?

2022.8.2

What was the last working version of Home Assistant Core?

No response

What type of installation are you running?

Home Assistant OS

Integration causing the issue

Govee Bluetooth

Link to integration documentation on our website

https://www.home-assistant.io/integrations/govee_ble

Diagnostics information

No response

Example YAML snippet

No response

Anything in the logs that might be useful for us?

No response

Additional information

No response

probot-home-assistant[bot] commented 2 years ago

govee_ble documentation govee_ble source (message by IssueLinks)

probot-home-assistant[bot] commented 2 years ago

Hey there @bdraco, mind taking a look at this issue as it has been labeled with an integration (govee_ble) you are listed as a code owner for? Thanks! (message by CodeOwnersMention)

bdraco commented 2 years ago

Please turn on debug logging for homeassistant.components.bluetooth and post the advertisements the device is sending.

bdraco commented 2 years ago

I'm guessing some version of these are little endian and some are big endian. I wonder if they changed hardware versions at some point. It would have been nice if they changed the model number when they changed the adv format

adilapi commented 2 years ago

Please let me know if you require anything else:

2022-08-08 17:42:05.775 DEBUG (MainThread) [homeassistant.components.bluetooth] Device detected: 3F:46:0D:81:E8:1B with advertisement_data: AdvertisementData(local_name='Govee_H5052_E81B', manufacturer_data={60552: b'\x00\x1c\x01\xa7\x14;\x00\x00\x02'}, service_uuids=['0000180a-0000-1000-8000-00805f9b34fb', '0000fef5-0000-1000-8000-00805f9b34fb', '0000ec88-0000-1000-8000-00805f9b34fb']) matched domains: {'govee_ble'} 2022-08-08 17:42:08.769 DEBUG (MainThread) [homeassistant.components.bluetooth] Device detected: 3F:46:0D:81:E8:1B with advertisement_data: AdvertisementData(local_name='Govee_H5052_E81B', manufacturer_data={60552: b'\x00\x1e\x01\xa9\x14:\x00\x00\x02'}, service_uuids=['0000180a-0000-1000-8000-00805f9b34fb', '0000fef5-0000-1000-8000-00805f9b34fb', '0000ec88-0000-1000-8000-00805f9b34fb']) matched domains: set() 2022-08-08 17:44:52.764 DEBUG (MainThread) [homeassistant.components.bluetooth] Device detected: 3F:46:0D:81:E8:1B with advertisement_data: AdvertisementData(local_name='Govee_H5052_E81B', manufacturer_data={60552: b'\x00O\x01\xe4\x1e;\x00\x00\x02'}, service_uuids=['0000180a-0000-1000-8000-00805f9b34fb', '0000fef5-0000-1000-8000-00805f9b34fb', '0000ec88-0000-1000-8000-00805f9b34fb']) matched domains: set()

Aaron

From: J. Nick Koston @.> Sent: Monday, August 8, 2022 5:15 PM To: home-assistant/core @.> Cc: Aaron DiLapi @.>; Author @.> Subject: Re: [home-assistant/core] Garbage data coming from Govee H5052 sensors (Issue #76489)

Please turn on debug logging for homeassistant.components.bluetooth and post the advertisements the device is sending.

- Reply to this email directly, view it on GitHubhttps://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fhome-assistant%2Fcore%2Fissues%2F76489%23issuecomment-1208617409&data=05%7C01%7Caaron.dilapi%40tylin.com%7Cf9170f8f34bd4f10dbd108da79830dca%7Cffa1e51c7cbc49398cb093c3775db5f1%7C0%7C0%7C637955901028786584%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=ZxHqhJk%2FX%2FMCNOkFFLxwxXRCW2VWQMmIc4oM94bFybo%3D&reserved=0, or unsubscribehttps://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAM5EUVXZAFMURXQ7G7HCTZDVYF2FHANCNFSM556OGDAQ&data=05%7C01%7Caaron.dilapi%40tylin.com%7Cf9170f8f34bd4f10dbd108da79830dca%7Cffa1e51c7cbc49398cb093c3775db5f1%7C0%7C0%7C637955901028786584%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=wLAtiPI%2BBrX1oKek40ztEG4DHrZnpeFDU%2BmBipOLA2M%3D&reserved=0. You are receiving this because you authored the thread.Message ID: @.**@.>>

bdraco commented 2 years ago

What is the temperature in that advertisement?

bdraco commented 2 years ago

Oh this is a 5052. We only have support for the 5072s

bdraco commented 2 years ago

Since its being discovered and its the same format as the 5072s with just the endianness reversed, I think its ok to fix in a patch