home-assistant / core

:house_with_garden: Open source home automation that puts local control and privacy first.
https://www.home-assistant.io
Apache License 2.0
73.43k stars 30.66k forks source link

Somfy blind motors cannot be assigned to a room #77928

Closed DCEM closed 2 years ago

DCEM commented 2 years ago

The problem

Somfy motors will return None as serial number via the Velux KLF-200: Handle devices without serial numbers.

This serial is usesd as unique id here: core/homeassistant/components/velux/init.py#L114

Could it be reasonable to return the node name instead of None?

            if self.node.serial_number:
                return self.node.serial_number
            elif self.node.name:
                return self.node.name
            else:
                return "velux_#" + str(self.node.node_id)

What version of Home Assistant Core has the issue?

2022.8.7

What was the last working version of Home Assistant Core?

No response

What type of installation are you running?

Home Assistant OS

Integration causing the issue

Velux

Link to integration documentation on our website

https://www.home-assistant.io/integrations/velux/

Diagnostics information

No response

Example YAML snippet

No response

Anything in the logs that might be useful for us?

No response

Additional information

Related issues: 66262 35935 74009

probot-home-assistant[bot] commented 2 years ago

velux documentation velux source (message by IssueLinks)

probot-home-assistant[bot] commented 2 years ago

Hey there @julius2342, mind taking a look at this issue as it has been labeled with an integration (velux) you are listed as a code owner for? Thanks! (message by CodeOwnersMention)

ahorseman commented 2 years ago

Hello. I have this same issue. Could it be possible to create a unique ID for HA?