home-assistant / core

:house_with_garden: Open source home automation that puts local control and privacy first.
https://www.home-assistant.io
Apache License 2.0
71.61k stars 29.93k forks source link

Growatt integration - Not obtaining all sensors/entities #78149

Closed riffy99 closed 1 year ago

riffy99 commented 2 years ago

The problem

Integration install and login to Growatt servers work as expected. Plant is added but it only gets the following sensors:

image

What version of Home Assistant Core has the issue?

2022.9.1

What was the last working version of Home Assistant Core?

No response

What type of installation are you running?

Home Assistant Supervised

Integration causing the issue

Growatt

Link to integration documentation on our website

https://www.home-assistant.io/integrations/growatt_server/

Diagnostics information

No response

Example YAML snippet

No response

Anything in the logs that might be useful for us?

No response

Additional information

Growatt inverter -

Device Type:SPA1~3k TL BL

probot-home-assistant[bot] commented 2 years ago

growatt_server documentation growatt_server source (message by IssueLinks)

probot-home-assistant[bot] commented 2 years ago

Hey there @indykoning, @muppet3000, @jasperplant, mind taking a look at this issue as it has been labeled with an integration (growatt_server) you are listed as a code owner for? Thanks! (message by CodeOwnersMention)

jolaca01 commented 2 years ago

Same problem here, although I do get more solar power related sensors. My issue is that I do not get any sensor related to load consumption, energy imported form grid or energy exported to grid.

wurliwax commented 2 years ago

I do have the same problem. Just installed the Growatt inverter + battery setup and can see all data on the growatt server. I installed the growatt integration two days ago and see only sensors as depicted above by @riffy99

Edit: I found it by myself - there is a second device registered with the name of the inverter and containing a lot of sensors... unfortunatly not yet anything of the battery I have attached... but that might be another ticket.

Benchamoneh commented 1 year ago

I have the same issue. I don't believe these devices are supported at present. After enabling debug logging in HA for the Growatt component I found this in the logs: 2022-09-21 10:14:35.409 DEBUG (MainThread) [homeassistant.components.growatt_server.sensor] Device type SPA3000 was found but is not supported right now

I have an SPA3000 which identifies on the Growatt platform as an 'AC Couple' type, but looking at the component code it looks like only 'inverter', 'storage', 'tlx' and 'mixed' types are supported.

@indykoning, @muppet3000, @JasperPlant, I think that adding support for 'ac couple' types to function as storage would solve this problem?. I've tried to read through your code to make sense of it and submit a PR but afraid I'm just not that familiar with HA component code standards.

coleburg commented 1 year ago

I have the same inverter and would like this supported too. @muppet3000 :-)

davelegg83 commented 1 year ago

I also have the same inverter, SPA3000 and can only get the 6 entities listed above. If this inverter could be added that would be great @muppet3000

muppet3000 commented 1 year ago

Hi All,

I'm in the process of collating all of the issues logged against the Growatt integration and trying to de-duplicate and then prioritise.

Can you all do me a favour and log into the Growatt Web UI: https://server.growatt.com and then tell me what type of system your setup is defined as (example screen-grab below). image

coleburg commented 1 year ago

Hi, thank you @muppet3000 , mine says 'Ac Couple'. its the (SPA3000) Will your changes include a mode switch as that would be HUGE!!! :-)

muppet3000 commented 1 year ago

Hi, thank you @muppet3000 , mine says 'Ac Couple'. its the (SPA3000) Will your changes include a mode switch as that would be HUGE!!! :-)

Let's just get it working reading values first shall we :) If you're interested in seeing something I wrote for my own 'hybrid' system take a look over here: https://github.com/muppet3000/growatt-weather-based-charger But let's keep this thread on topic for 'lack of support for X system'

davelegg83 commented 1 year ago

Mine also says AC Coupled

muppet3000 commented 1 year ago

Hi All,

This is a massive cross-post on all the Growatt tickets so apologies for it's generic format. I've collated all of the open issues and prioritised them here: https://community.home-assistant.io/t/growatt-integration-prioritised-list-of-features-for-implementation-fixing/483850

I will be working through them in order and updating that post as well as the affected tickets. Using that method I can be sure to correctly track everything associated with the integration.

Watch this space!

jolaca01 commented 1 year ago

Hi, mine shows this:

Hope it helps!!

El jue, 3 nov 2022 21:59, muppet3000 @.***> escribió:

Hi All,

I'm in the process of collating all of the issues logged against the Growatt integration and trying to de-duplicate and then prioritise.

Can you all do me a favour and log into the Growatt Web UI: https://server.growatt.com and then tell me what type of system your setup is defined as (example screen-grab below). [image: image] https://user-images.githubusercontent.com/10612068/199832908-06483a90-aa5d-473a-978e-62ae8d1d9e7f.png

— Reply to this email directly, view it on GitHub https://github.com/home-assistant/core/issues/78149#issuecomment-1302656111, or unsubscribe https://github.com/notifications/unsubscribe-auth/AEOY2WSDJ43G45CHOFKLPQ3WGQRS3ANCNFSM6AAAAAAQI2KKF4 . You are receiving this because you commented.Message ID: @.***>

jolaca01 commented 1 year ago

And:

El jue, 3 nov 2022 22:58, Jorge Lacomba Cámara @.***> escribió:

Hi, mine shows this:

Hope it helps!!

El jue, 3 nov 2022 21:59, muppet3000 @.***> escribió:

Hi All,

I'm in the process of collating all of the issues logged against the Growatt integration and trying to de-duplicate and then prioritise.

Can you all do me a favour and log into the Growatt Web UI: https://server.growatt.com and then tell me what type of system your setup is defined as (example screen-grab below). [image: image] https://user-images.githubusercontent.com/10612068/199832908-06483a90-aa5d-473a-978e-62ae8d1d9e7f.png

— Reply to this email directly, view it on GitHub https://github.com/home-assistant/core/issues/78149#issuecomment-1302656111, or unsubscribe https://github.com/notifications/unsubscribe-auth/AEOY2WSDJ43G45CHOFKLPQ3WGQRS3ANCNFSM6AAAAAAQI2KKF4 . You are receiving this because you commented.Message ID: @.***>

riffy99 commented 1 year ago

Mine also shows AcCouple.

Many thanks, Richard

On Thu, 3 Nov 2022 at 22:00, jolaca01 @.***> wrote:

And:

El jue, 3 nov 2022 22:58, Jorge Lacomba Cámara @.***> escribió:

Hi, mine shows this:

Hope it helps!!

El jue, 3 nov 2022 21:59, muppet3000 @.***> escribió:

Hi All,

I'm in the process of collating all of the issues logged against the Growatt integration and trying to de-duplicate and then prioritise.

Can you all do me a favour and log into the Growatt Web UI: https://server.growatt.com and then tell me what type of system your setup is defined as (example screen-grab below). [image: image] < https://user-images.githubusercontent.com/10612068/199832908-06483a90-aa5d-473a-978e-62ae8d1d9e7f.png

— Reply to this email directly, view it on GitHub < https://github.com/home-assistant/core/issues/78149#issuecomment-1302656111 , or unsubscribe < https://github.com/notifications/unsubscribe-auth/AEOY2WSDJ43G45CHOFKLPQ3WGQRS3ANCNFSM6AAAAAAQI2KKF4

. You are receiving this because you commented.Message ID: @.***>

— Reply to this email directly, view it on GitHub https://github.com/home-assistant/core/issues/78149#issuecomment-1302723194, or unsubscribe https://github.com/notifications/unsubscribe-auth/AP4VMX764HERIKWVHRROVM3WGQYXZANCNFSM6AAAAAAQI2KKF4 . You are receiving this because you were mentioned.Message ID: @.***>

jasongoff commented 1 year ago

Hi

Mine shows Hybrid Inverter. I see a load of sensors but I can't then select them in the Energy dashboard for import/export for daily readings. HA docs suggest this link: https://developers.home-assistant.io/docs/core/entity/sensor/#long-term-statistics

image

muppet3000 commented 1 year ago

Hi

Mine shows Hybrid Inverter. I see a load of sensors but I can't then select them in the Energy dashboard for import/export for daily readings. HA docs suggest this link: https://developers.home-assistant.io/docs/core/entity/sensor/#long-term-statistics

image

Hybrid inverters work, including the correct value being available in the Energy Dashboard. Not all statistics are considered 'long term statistics', you need to use the values for "today" or "lifetime" on the Energy Dashboard and the clever logic in HA itself tracks the amount used per hour/day/week/month/year etc.

jasongoff commented 1 year ago

Perfect, thank you for the quick reply!


From: Chris Straffon @.> Sent: 04 January 2023 8:16 PM To: home-assistant/core @.> Cc: Jason Goff @.>; Comment @.> Subject: Re: [home-assistant/core] Growatt integration - Not obtaining all sensors/entities (Issue #78149)

Hi

Mine shows Hybrid Inverter. I see a load of sensors but I can't then select them in the Energy dashboard for import/export for daily readings. HA docs suggest this link: https://developers.home-assistant.io/docs/core/entity/sensor/#long-term-statistics

[image]https://user-images.githubusercontent.com/4741507/210610962-ba217c6a-160c-495c-ae52-a4c401becc9e.png

Hybrid inverters work, including the correct value being available in the Energy Dashboard. Not all statistics are considered 'long term statistics', you need to use the values for "today" or "lifetime" on the Energy Dashboard and the clever logic in HA itself tracks the amount used per hour/day/week/month/year etc.

— Reply to this email directly, view it on GitHubhttps://github.com/home-assistant/core/issues/78149#issuecomment-1371375342, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ABEFTA57WFDMWPJKN5JN4BLWQXLDJANCNFSM6AAAAAAQI2KKF4. You are receiving this because you commented.Message ID: @.***>

muppet3000 commented 1 year ago

Hi Everyone (apologies for the cross-posting but I'm posting this on all open Growatt integration tickets)!

As discussed in more detail here I have started the process of moving the Growatt Server integration out of Home Assistant Core and into a custom integration. This will allow for much faster responses when there are issues with authenticating against the Growatt Servers as we've seen in recent months.

Over the next few weeks I will be removing the Growatt integration from the Core repository of Home Assistant, however, to give people time to switch over to the new integration I have already published it here (new repo) with a comprehensive guide on how to install it (it's quite straight forward).

Once you have it installed, delete the previous integration and then switch to using the new one, step-by-step with pictures here

IMPORTANT: The new integration is the only place that new fixes & features will be released

Next steps:

I apologise for the inconvenience that this causes, however it's in the interest of the stability of Home Assistant Core as well as the ability to provide swift responses to issues in the plugin that I'm making this change.

Any questions related to this, please add them as issues on the new repo here (issues) and I'll respond as fast as I can.

frenck commented 1 year ago

I've hidden your comment @muppet3000. The Home Assistant project does not recommend or support the use of custom integrations.

../Frenck

davelegg83 commented 1 year ago

That's a shame frenck. Reminds me of the iOS vs Android debate. iOS - Main apps updated only via a system update Android - Individual apps updated via the Google Play Store. I believe what @muppet3000 is doing in regards to Growatt is the best for the community, and I fully support and applaud all the time and effort he puts into it.

muppet3000 commented 1 year ago

That's a shame frenck. Reminds me of the iOS vs Android debate. iOS - Main apps updated only via a system update Android - Individual apps updated via the Google Play Store. I believe what @muppet3000 is doing in regards to Growatt is the best for the community, and I fully support and applaud all the time and effort he puts into it.

Let's not let this descend into Reddit.......

The team of maintainers for HA Core work tirelessly to maintain incredibly high standards, they have a process and I'm not going to stand in the way of that. The information is still there, it's hidden, but it's there. I'm sure people will find it as/when they need it.

I've separately reached out directly to @frenck for advice on how to move forward cleanly and with visibility for all.

frenck commented 1 year ago

I believe what @muppet3000 is doing in regards to Growatt is the best for the community,

No doubt, yet, they aren't reviewed. It being posted may come across as the recommended or endorsed solution. The fact is, we don't recommend using it at all, as it is a custom integration.

davelegg83 commented 1 year ago

No offence intended on either part and I appreciate all the work that goes on behind the scenes.

frenck commented 1 year ago

Adding to it, as stated by @muppet3000

IMPORTANT: The new integration is the only place that new fixes & features will be released

I want to mention that that is not true. We (the Home Assistant project) are happy to accept PRs and contributions to the core integration by anyone willing to add or extend features.

../Frenck

muppet3000 commented 1 year ago

Adding to it, as stated by @muppet3000

IMPORTANT: The new integration is the only place that new fixes & features will be released

I want to mention that that is not true. We (the Home Assistant project) are happy to accept PRs and contributions to the core integration by anyone willing to add or extend features.

../Frenck

This isn't the place to have a detailed discussion about this, however....

Obviously if someone has more luck engaging with Growatt than I've had in order to make this plugin more stable then of course I'll support them, I was encouraged to move this into a custom component by Martin from the core team back when we were having all of the recent stability issues see here: https://github.com/home-assistant/core/issues/81951#issuecomment-1323271756

@frenck - I've send you an email to the address listed on your Github in an attempt to engage on this outside of the comments on Github to work out the smoothest way of making this transition. Given that this course of action was suggested by one of the core maintainers I didn't anticipate this response, I've tried my best to do it cleanly so that everyone was aware of the change.

If I'm able to get some engagement from Growatt or find an alternative method of pulling in the data without being blocked by the firewalls then once I've integrated it I'd love to re-introduce the integration to Core, but right now it's not stable enough to do that.

frenck commented 1 year ago

I've send you an email to the address listed on your Github in an attempt to engage on this outside of the comments on Github to work out the smoothest way of making this transition.

Sorry, I have no interest in communicating in private in an open-source project. Nor is that address in active use (it will just go into a void).

You are free to create a custom integration if you like. If you or others are willing to improve on the core integration, that is fine as well.

../Frenck

muppet3000 commented 1 year ago

Ok, if you're happy to engage here great, I was mainly just trying to keep the ticket focussed on the issue rather than this side-topic. If you don't want to engage here though that's cool I'll just hope that everyone finds the information as/when they need it.

This is what was in the body of the email: """ Would the team at least accept me updating the documentation here: https://www.home-assistant.io/integrations/growatt_server/ to say that it is being deprecated due to stability issues and then point people towards the Custom Integration?

I'd also like to submit a PR which adds a WARNING log to the Growatt Integration in Core saying that it is being deprecated and to direct them to the documentation.

I've only done this because it was suggested by Martin Hjelmare here: https://github.com/home-assistant/core/issues/81951#issuecomment-1323271756

I'm just trying to give the user base of the integration the information so that they don't have the integration just vanish from them in a future release. """

frenck commented 1 year ago

Would the team at least accept me updating the documentation here: home-assistant.io/integrations/growatt_server to say that it is being deprecated due to stability issues and then point people towards the Custom Integration?

I don't think so; if they can be addressed in custom integration, they can also be addressed in our core. As far as I'm aware and heard, this integration is currently in a working state.

I'd also like to submit a PR which adds a WARNING log to the Growatt Integration in Core saying that it is being deprecated and to direct them to the documentation.

We don't use logs for that; otherwise same reasoning as above.

../Frenck

muppet3000 commented 1 year ago

A great suggestion has been made on the above (see hidden comment) forum link to continue support of the Core integration by taking a monthly roll-up of the changes in the HACS version of the integration and submitting them via the formal review process into Core. This will ensure that the integration continues to meet the standards expected of a Core integration.

Therefore, those of you that wish to continue using just the Core version of the integration will still be able to it will just receive updates/fixes at a slightly slower rate.

I will continue to monitor & respond to bugs and issues raised in Core but they will be first fixed externally before making it into a Core PR.

I hope this provides the best of both worlds for everyone involved.

frenck commented 1 year ago

Please note that that model does have downsides; for example, we will be changing the core version to keep up with core changes and will not contribute those fixes and changes to custom integrations.

Additionally, custom integrations have to take into account multiple versions of Home Assistant in the same codebase (e.g., take care of compatibility differences), while core integrations do not need such logic.

The code base, therefore, will there diverge and not be the same. Your statement is therefore, something that generally can't be achieved.

@muppet3000 Will you please stop crossposting the same message on all issues related to growatt_server? Consider that a warning, please. That is not wished for.

../Frenck

muppet3000 commented 1 year ago

Noted and understood (just posting this on this one given this is where the conversation took place yesterday).

I'll try my best to get the right balance for the Integration's implementation going forward.

Apologies for the disruption and cross-posting, it was not my intention to irritate or mis-use the ticketing system, I was just trying to share the situation with the user base.

frenck commented 1 year ago

The situation you are sharing isn't relevant for Core. Custom integration isn't supported, endorsed, or recommended by the Home Assistant project (as pointed out before). Thus not relevant to the issue at hand either, as they are about the core integration.

Onlinepeter commented 1 year ago

I have the same problem/issue and mine say MAX/MID/MAC

stintov commented 1 year ago

Hi All,

I'm in the process of collating all of the issues logged against the Growatt integration and trying to de-duplicate and then prioritise.

Can you all do me a favour and log into the Growatt Web UI: https://server.growatt.com and then tell me what type of system your setup is defined as (example screen-grab below). image

My SPA3000 says AC Inverter and I have this issue where only 6 sensors are displayed. Really appreciate your work on this. Any updates on whe this issue will be fixed please?

issue-triage-workflows[bot] commented 1 year ago

There hasn't been any activity on this issue recently. Due to the high number of incoming GitHub notifications, we have to clean some of the old issues, as many of them have already been resolved with the latest updates. Please make sure to update to the latest Home Assistant version and check if that solves the issue. Let us know if that works for you by adding a comment 👍 This issue has now been marked as stale and will be closed if no further activity occurs. Thank you for your contributions.