home-assistant / core

:house_with_garden: Open source home automation that puts local control and privacy first.
https://www.home-assistant.io
Apache License 2.0
71.16k stars 29.84k forks source link

Full size video feed restricted to preview size in generic camera #81519

Closed Axsgranted closed 1 year ago

Axsgranted commented 1 year ago

The problem

I believe the recent change from: https://github.com/home-assistant/core/pull/71269

that added new Camera preview functionality to the entity, created an issue with the full size Video feed. It's now restricted to the preview size (580x320), introduced by this change, when Selecting a Video feed, of a Generic IP Camera, from an entity card.

Video windows size, prior to this change was working as original Feed Resolution.

What version of Home Assistant Core has the issue?

2022.11.1

What was the last working version of Home Assistant Core?

2022.10

What type of installation are you running?

Home Assistant OS

Integration causing the issue

Generic Camera

Link to integration documentation on our website

https://www.home-assistant.io/integrations/generic/

Diagnostics information

{ "home_assistant": { "installation_type": "Home Assistant OS", "version": "2022.11.1", "dev": false, "hassio": true, "virtualenv": false, "python_version": "3.10.7", "docker": true, "arch": "x86_64", "timezone": "America/Phoenix", "os_name": "Linux", "os_version": "5.15.74", "supervisor": "2022.10.2", "host_os": "Home Assistant OS 9.3", "docker_version": "20.10.18", "chassis": "embedded", "run_as_root": true }, "custom_components": { "hacs": { "version": "1.28.3", "requirements": [ "aiogithubapi>=22.2.4" ] }, "alarmdotcom": { "version": "0.2.15", "requirements": [ "beautifulsoup4==4.10.0", "pyalarmdotcomajax==0.4.6" ] }, "weatheralerts": { "version": "0.1.5", "requirements": [] }, "alexa_media": { "version": "4.3.2", "requirements": [ "alexapy==1.26.4", "packaging>=20.3", "wrapt>=1.12.1" ] } }, "integration_manifest": { "domain": "generic", "name": "Generic Camera", "config_flow": true, "requirements": [ "ha-av==10.0.0", "pillow==9.2.0" ], "dependencies": [ "http" ], "documentation": "https://www.home-assistant.io/integrations/generic", "codeowners": [ "@davet2001" ], "iot_class": "local_push", "is_built_in": true }, "data": { "title": "mybackyard_com", "data": {}, "options": { "stream_source": "rtsp://mybackyard.com", "authentication": "basic", "username": "REDACTED", "password": "REDACTED", "framerate": 2.0, "verify_ssl": false, "rtsp_transport": "tcp", "content_type": "image/jpeg", "limit_refetch_to_url_change": false } } }

Example YAML snippet

No response

Anything in the logs that might be useful for us?

No response

Additional information

No response

home-assistant[bot] commented 1 year ago

Hey there @davet2001, mind taking a look at this issue as it has been labeled with an integration (generic) you are listed as a code owner for? Thanks!

Code owner commands Code owners of `generic` can trigger bot actions by commenting: - `@home-assistant close` Closes the issue. - `@home-assistant rename Awesome new title` Change the title of the issue. - `@home-assistant reopen` Reopen the issue. - `@home-assistant unassign generic` Removes the current integration label and assignees on the issue, add the integration domain after the command.

(message by CodeOwnersMention)


generic documentation generic source (message by IssueLinks)

davet2001 commented 1 year ago

@Axsgranted I think it is very unlikely that the preview feature introduced this problem.

The preview only works for the still image, and creates an independent preview URL. The creation of the final camera entity should not have been changed by the PR.

Please can you describe:

rchiileea commented 1 year ago

@davet2001 confirmed have this issue

update to 2022.11

touch or click on camera preview and camera opens to live full screen popup

camera pops up live view in the same size as preview on dash.

image

davet2001 commented 1 year ago

To avoid confusion, the preview in #71269 refers to a temporary image that is displayed while configuring the camera settings on the UI.

Is the issue here referring to the small image 'preview' on the dashboard that you click to show the stream?

@uvjustin @hunterjm any ideas on what this might be?

rchiileea commented 1 year ago

the preview on dashboard is fine, its when you click to show stream, the size has changed from almost full screen to a size simular to the preview

uvjustin commented 1 year ago

Seems like a frontend issue that has been resolved: https://github.com/home-assistant/frontend/issues/13581

rchiileea commented 1 year ago

Seems like a frontend issue that has been resolved: home-assistant/frontend#13581

maybe the update caused it to pop back up 2022.11.1?

rchiileea commented 1 year ago

Tried with various intergrations to rule them being the cause out, generic, onvif etc, have also noticed that one feed actually is not showing the live stream when clicked as well, going to shut down the server a few times to double check.

uvjustin commented 1 year ago

Which browser are you using? Have you tried it in a different browser? This is likely a frontend issue, and frontend behavior can vary between browsers. (FWIW I tried it on Windows MS Edge and the behavior seems similar to what you describe)

rchiileea commented 1 year ago

so Its the same on ms edge, chrome, firefox and fully kiosk

uvjustin commented 1 year ago

Actually, try clicking on the text (In your case "Drive Way Camera"). That should toggle the settings window size.

rchiileea commented 1 year ago

Actually, try clicking on the text (In your case "Drive Way Camera"). That should toggle the settings window size.

that worked, is that new then as it just popped up full before?

uvjustin commented 1 year ago

I haven't followed all the frontend changes, but it does seem like the behavior has changed somewhat. See https://github.com/home-assistant/frontend/pull/14179 for more info. Closing this as it's not a core issue.

Scope666 commented 1 year ago

My 2 cents, the extra click is kind of annoying. 9 times out of 10 if you're clicking on the video thumbnail, it's because you want to see it bigger.

uvjustin commented 1 year ago

I agree. Perhaps open an issue on the frontend repo?