home-assistant / core

:house_with_garden: Open source home automation that puts local control and privacy first.
https://www.home-assistant.io
Apache License 2.0
72.74k stars 30.46k forks source link

Mill integration gives an error when used in a scene #82825

Closed jm-cook closed 1 year ago

jm-cook commented 1 year ago

The problem

If a device from the MILL integration is used in a scene, the whole scene fails to turn on. The error being raised is in the stack trace below, but here for convenience:

File "/usr/src/homeassistant/homeassistant/components/climate/init.py", line 493, in set_hvac_mode raise NotImplementedError()

I have a gen 3 mill panel heater and am using the direct integration (ie not cloud)

When used in a scene, the scene controller tries to set the target temperature. This works with other climate devices.

What version of Home Assistant Core has the issue?

2022.11.4

What was the last working version of Home Assistant Core?

No response

What type of installation are you running?

Home Assistant OS

Integration causing the issue

Mill

Link to integration documentation on our website

https://www.home-assistant.io/integrations/mill

Diagnostics information

mill-diagostics.log

Example YAML snippet

example scenes.yaml:

- id: '1610369717606'
  name: Cozy comfort
  entities:
    climate.vh87_lvrm_htr:
      hvac_modes:
      - heat
      min_temp: 5
      max_temp: 35
      target_temp_step: 0.5
      current_temperature: 21.9
      temperature: 22
      hvac_action: heating
      friendly_name: VH87 lvrm htr
      supported_features: 1
      state: heat
  metadata: {}

Anything in the logs that might be useful for us?

File "/usr/src/homeassistant/homeassistant/components/climate/__init__.py", line 493, in set_hvac_mode
    raise NotImplementedError()

Additional information

The above yaml is generated when using the scene editor. Add the mill device to a scene using the scene editor and you will see the error immediately.

home-assistant[bot] commented 1 year ago

Hey there @danielhiversen, mind taking a look at this issue as it has been labeled with an integration (mill) you are listed as a code owner for? Thanks!

Code owner commands Code owners of `mill` can trigger bot actions by commenting: - `@home-assistant close` Closes the issue. - `@home-assistant rename Awesome new title` Change the title of the issue. - `@home-assistant reopen` Reopen the issue. - `@home-assistant unassign mill` Removes the current integration label and assignees on the issue, add the integration domain after the command.

(message by CodeOwnersMention)


mill documentation mill source (message by IssueLinks)

Danielhiversen commented 1 year ago

set_hvac_mode is not support by the mill integration