home-assistant / core

:house_with_garden: Open source home automation that puts local control and privacy first.
https://www.home-assistant.io
Apache License 2.0
73.88k stars 30.95k forks source link

Sonarr integration returning wrong disk space #84318

Open h3llrais3r opened 1 year ago

h3llrais3r commented 1 year ago

The problem

Similar as #67520, which seems to be closed due to inactivity. Sonarr mentions all disk space from all drives configured on the system (/api/v3/diskspace). image

Radarr (and lidarr) only reports disk space from configured root folders (/api/v3/rootfolder). image

Would be nice if Sonarr filters in the same way as Radarr does, so it only shows disk space for configured root folders.

What version of Home Assistant Core has the issue?

2022.12.7

What was the last working version of Home Assistant Core?

No response

What type of installation are you running?

Home Assistant OS

Integration causing the issue

sonarr

Link to integration documentation on our website

No response

Diagnostics information

No response

Example YAML snippet

No response

Anything in the logs that might be useful for us?

No response

Additional information

No response

home-assistant[bot] commented 1 year ago

Hey there @ctalkington, mind taking a look at this issue as it has been labeled with an integration (sonarr) you are listed as a code owner for? Thanks!

Code owner commands Code owners of `sonarr` can trigger bot actions by commenting: - `@home-assistant close` Closes the issue. - `@home-assistant rename Awesome new title` Change the title of the issue. - `@home-assistant reopen` Reopen the issue. - `@home-assistant unassign sonarr` Removes the current integration label and assignees on the issue, add the integration domain after the command.

(message by CodeOwnersMention)


sonarr documentation sonarr source (message by IssueLinks)

issue-triage-workflows[bot] commented 1 year ago

There hasn't been any activity on this issue recently. Due to the high number of incoming GitHub notifications, we have to clean some of the old issues, as many of them have already been resolved with the latest updates. Please make sure to update to the latest Home Assistant version and check if that solves the issue. Let us know if that works for you by adding a comment πŸ‘ This issue has now been marked as stale and will be closed if no further activity occurs. Thank you for your contributions.

h3llrais3r commented 1 year ago

Bump

taw123 commented 1 year ago

Let me add to the diagnosis here....

I am of the opinion the issue lies (at least im my case with Sonarr as the data provider.

If I hit Sonarr's disk space API directly (from a browser) I get a response returned of

http://nn.nn.nn.nn:8989/api/diskspace?apikey=secret_api_key)

[]

Same query this time for Sonarr's queue returns good/appropriate data, demonstrating the key entered above is correct and no issue with network access to Sonarr as a data provider.

So while there might be something ALSO amiss with the Integration, until Sonarr is correctly providing data through it's published API we won't know. I am planning to continue reviewing Sonarr's issue list though I have yet to find anything current and appropriate so I will likely open a new issue there (and link back to here for Devs to circle back when appropriate). HOPEFULLY this will move the issue along.

BTW I DO have a SLIGHTLY unusual deployment as I am running ZFS on may "Arr" Server/NAS and thus the less traditional disk structure and thus the Web app also shows no volume but works fine. HOWEVER Radarr Web app (and thus HA integration for Radarr) DO show the correct disk space remaining for the ZFS shared folder.

Let me know if I can help further (beyond filing the issue against directly against Sonarr dev)

--T

issue-triage-workflows[bot] commented 1 year ago

There hasn't been any activity on this issue recently. Due to the high number of incoming GitHub notifications, we have to clean some of the old issues, as many of them have already been resolved with the latest updates. Please make sure to update to the latest Home Assistant version and check if that solves the issue. Let us know if that works for you by adding a comment πŸ‘ This issue has now been marked as stale and will be closed if no further activity occurs. Thank you for your contributions.

h3llrais3r commented 1 year ago

Bump

issue-triage-workflows[bot] commented 1 year ago

There hasn't been any activity on this issue recently. Due to the high number of incoming GitHub notifications, we have to clean some of the old issues, as many of them have already been resolved with the latest updates. Please make sure to update to the latest Home Assistant version and check if that solves the issue. Let us know if that works for you by adding a comment πŸ‘ This issue has now been marked as stale and will be closed if no further activity occurs. Thank you for your contributions.

h3llrais3r commented 1 year ago

Bump

JeroenM1 commented 11 months ago

Bumping this. ItΒ΄s an enoying "bug" that should be taken a look at.

taw123 commented 8 months ago

Bump to prevent closing... This shouldn't be a difficult fix as other Arrs do work as I mentioned above issue still present in CURRENT Sonarr version: 4.0.2.1183. Radarr (NOW both Sonarr AND Radarr based on the SAME core code 'Arr' code) STILL reports correctly. For bonus points Lidarr also reports correctly (not add/doubleing disk space)

taw123 commented 7 months ago

Since my earlier bug was closed without investigation....

I'll again state- API call to Sonarr:

http://192.168.42.84:8989/api/v3/diskspace?apikey=not_telling

[
  {
    "path": "/",
    "label": "",
    "freeSpace": 1274930643968,
    "totalSpace": 1275156161536
  },
  {
    "path": "/config",
    "label": "",
    "freeSpace": 247228962816,
    "totalSpace": 536870912000
  },
  {
    "path": "/data",
    "label": "",
    "freeSpace": 5206473063424,
    "totalSpace": 75092135002624
  },
  {
    "path": "/data/@Recently-Snapshot",
    "label": "",
    "freeSpace": 5206473063424,
    "totalSpace": 5206473314816
  },
  {
    "path": "/wait-for",
    "label": "",
    "freeSpace": 247228962816,
    "totalSpace": 536870912000
  }
]

/data is of course the volume to report up through the integration.....

We just need this Integration turned to stop adding volumes. Isn't this integration actually SUPPORTED? Or have devs abandoned it. Original issue filed by David back on MAY 2022 (2 years ago), and in that time the integration HAS even updated.... (scratching his head) https://github.com/home-assistant/core/issues/67520

issue-triage-workflows[bot] commented 4 months ago

There hasn't been any activity on this issue recently. Due to the high number of incoming GitHub notifications, we have to clean some of the old issues, as many of them have already been resolved with the latest updates. Please make sure to update to the latest Home Assistant version and check if that solves the issue. Let us know if that works for you by adding a comment πŸ‘ This issue has now been marked as stale and will be closed if no further activity occurs. Thank you for your contributions.

taw123 commented 4 months ago

Bump

SvenPegels commented 3 months ago

Wouldn't the easiest solution just be to have an entity for each disk location? Or do can entities not be added dynamically like that?

issue-triage-workflows[bot] commented 1 week ago

There hasn't been any activity on this issue recently. Due to the high number of incoming GitHub notifications, we have to clean some of the old issues, as many of them have already been resolved with the latest updates. Please make sure to update to the latest Home Assistant version and check if that solves the issue. Let us know if that works for you by adding a comment πŸ‘ This issue has now been marked as stale and will be closed if no further activity occurs. Thank you for your contributions.

webash commented 1 week ago

Not fixed, don't close