home-assistant / core

:house_with_garden: Open source home automation that puts local control and privacy first.
https://www.home-assistant.io
Apache License 2.0
73.19k stars 30.57k forks source link

Netgear Integration (And other device_tracker routers) Delete Devices Now Possible #85076

Closed birdwing closed 1 year ago

birdwing commented 1 year ago

The problem

My wife and I just got new cell phones. I use a netgear router with device tracker. It is very useful for tracking our phones and a few other devices on the network. However like others, I have always taken issue with the fact that I have numerous "Devices" setup with the netgear integration, despite the fact that for the last 3 months, only 9 devices have ever been on my network. Currently the integration shows 23 devices.

I have tried everything to get Netgear to remove the devices. Even removing the "offline" devices in Nighthawk does nothing. I am referencing a prior issue here:

@broyuken at least you can disable all in bulk using one click if you go into entities. However I do agree with you, I would like to see some better method for this. Please continue the discussion in the architecture issue.

Originally posted by @starkillerOG in https://github.com/home-assistant/core/issues/57193#issuecomment-937717964

I bring this up because as of at least October 26th, 2022 Home Assistant allows integrations to Opt-in to allowing users to delete devices: https://developers.home-assistant.io/docs/device_registry_index/#removing-devices

This would remove what I myself, and a lot of other users, feel is an issue with this and other device tracking routers. The inability to remove old devices that will never again be on the network. Either it was replaced or it died. However removing the entire integration is not a viable solution because then I would have to go in and rename all my entities.

What version of Home Assistant Core has the issue?

core-2022.12.9

What was the last working version of Home Assistant Core?

No response

What type of installation are you running?

Home Assistant OS

Integration causing the issue

Netgear

Link to integration documentation on our website

https://www.home-assistant.io/integrations/netgear/

Diagnostics information

No response

Example YAML snippet

No response

Anything in the logs that might be useful for us?

No response

Additional information

Perhaps integrations that provide device_tracker entities should be set to allow users to delete those devices by Default. The biggest complaint about needing to delete devices is with network based device trackers.

home-assistant[bot] commented 1 year ago

Hey there @hacf-fr, @quentame, @starkillerog, mind taking a look at this issue as it has been labeled with an integration (netgear) you are listed as a code owner for? Thanks!

Code owner commands Code owners of `netgear` can trigger bot actions by commenting: - `@home-assistant close` Closes the issue. - `@home-assistant rename Awesome new title` Change the title of the issue. - `@home-assistant reopen` Reopen the issue. - `@home-assistant unassign netgear` Removes the current integration label and assignees on the issue, add the integration domain after the command.

(message by CodeOwnersMention)


netgear documentation netgear source (message by IssueLinks)

stefanuytterhoeven commented 1 year ago

Hey there https://github.com/hacf-fr, @Quentame, @starkillerOG, mind taking a look at this issue as it has been labeled with an integration (netgear) you are listed as a code owner for? Thanks!

starkillerOG commented 1 year ago

@birdwing @stefanuytterhoeven I just implemented the ability to remove devices that are no longer on the network in this PR: https://github.com/home-assistant/core/pull/87849. (If the device is still in the network there is no point in removing it because it will be re-added on the next update a minute later).

Sorry for taking so long, I have been very bussy with other integrations

If you appreciate the Netgear integration and want to support its development, please consider sponsering the upstream library.

stefanuytterhoeven commented 1 year ago

Great! 👍

issue-triage-workflows[bot] commented 1 year ago

There hasn't been any activity on this issue recently. Due to the high number of incoming GitHub notifications, we have to clean some of the old issues, as many of them have already been resolved with the latest updates. Please make sure to update to the latest Home Assistant version and check if that solves the issue. Let us know if that works for you by adding a comment 👍 This issue has now been marked as stale and will be closed if no further activity occurs. Thank you for your contributions.