home-assistant / core

:house_with_garden: Open source home automation that puts local control and privacy first.
https://www.home-assistant.io
Apache License 2.0
73.48k stars 30.7k forks source link

Missing Characteristics for Airversa Air Purifier #85475

Closed dcmeglio closed 1 year ago

dcmeglio commented 1 year ago

The problem

The Airversa Air Purifier essentially gets detected as an air quality monitor, it just reports Air Quality and PM2.5. However, this device has a fan with multi-speed control and various switches and sensors that are exposed to Homekit. These items are not exposed in Home Assistant. Attached is the device diagnostics (also shared on Discord via DM) of the various Homekit characteristics

What version of Home Assistant Core has the issue?

2023.1.1

What was the last working version of Home Assistant Core?

No response

What type of installation are you running?

Home Assistant OS

Integration causing the issue

homekit_controller

Link to integration documentation on our website

https://www.home-assistant.io/integrations/homekit_controller/

Diagnostics information

homekit_controller-c5829887fe82964b3bd6bd6c65cf4a9f-Airversa AP2 1808-111788ab92e63db9f3d11b708a4c1864.json.txt

Example YAML snippet

No response

Anything in the logs that might be useful for us?

No response

Additional information

No response

home-assistant[bot] commented 1 year ago

Hey there @jc2k, @bdraco, mind taking a look at this issue as it has been labeled with an integration (homekit_controller) you are listed as a code owner for? Thanks!

Code owner commands Code owners of `homekit_controller` can trigger bot actions by commenting: - `@home-assistant close` Closes the issue. - `@home-assistant rename Awesome new title` Change the title of the issue. - `@home-assistant reopen` Reopen the issue. - `@home-assistant unassign homekit_controller` Removes the current integration label and assignees on the issue, add the integration domain after the command.

(message by CodeOwnersMention)


homekit_controller documentation homekit_controller source (message by IssueLinks)

issue-triage-workflows[bot] commented 1 year ago

There hasn't been any activity on this issue recently. Due to the high number of incoming GitHub notifications, we have to clean some of the old issues, as many of them have already been resolved with the latest updates. Please make sure to update to the latest Home Assistant version and check if that solves the issue. Let us know if that works for you by adding a comment 👍 This issue has now been marked as stale and will be closed if no further activity occurs. Thank you for your contributions.

TheAlphaLaw commented 1 year ago

This same problem exists for all purifiers, there is no entity but people have been asking for years. If HA read them as fans, that would do the trick temporarily too. @Jc2k Is the above possible?

Jc2k commented 1 year ago

See https://github.com/home-assistant/core/pull/88337.

The complexity comes from (at a protocol level) homekit purifiers sometimes being an air purifier and some times being an air purifier and a fan. So if you map it to a fan you might get 2 fan entities that behave in weird ways (one will turn both on but not both off etc).

TheAlphaLaw commented 1 year ago

mekit purifiers sometimes being an air purifier and some times being an air purifier and a fan. So if you map it to a fan you might get 2 fan entities that behave in weird ways (one will turn both on but not both off etc).

Yes, makes sense. I actually have the Govee Units H7122 and H7121. They show Air sensor and then fan in Homekit. Would it be worthwhile to submit a new issue? Would love to be able to control the fan in HA.

Jc2k commented 1 year ago

Please don't. We don't use GitHub for feature requests, and there are already PRs that move in the direction of what you want with discussion ongoing about how to get all the way there.

TheAlphaLaw commented 1 year ago

Please don't. We don't use GitHub for feature requests, and there are already PRs that move in the direction of what you want with discussion ongoing about how to get all the way there.

Sorry, I already did. Had no idea since I've used Git this way for many other things. How do we make feature requests that would not otherwise be handled? I've seen this issue posted on the HA forums since 2017.

Jc2k commented 1 year ago

Specifically the feature request forum.

Sorry you've been waiting for a long time. Each integration in HA is maintained by different people. homekit_controller doesn't have many maintainers and there are lots of requests to process in people's spare time.

The reality is making more feature requests doesn't help if there are no volunteers to do the work.