home-assistant / core

:house_with_garden: Open source home automation that puts local control and privacy first.
https://www.home-assistant.io
Apache License 2.0
73.56k stars 30.74k forks source link

HA 2023.2.1 broken synology dsm intergation #87334

Closed Shemmmy closed 1 year ago

Shemmmy commented 1 year ago

The problem

after updating ha to version 2023.2.1 synology dsm integration generate failed to set up error

What version of Home Assistant Core has the issue?

2023.2.1

What was the last working version of Home Assistant Core?

2023.2.0

What type of installation are you running?

Home Assistant Supervised

Integration causing the issue

Synology DSM

Link to integration documentation on our website

https://www.home-assistant.io/integrations/synology_dsm

Diagnostics information

No response

Example YAML snippet

No response

Anything in the logs that might be useful for us?

Error setting up entry 192.168.41.3 for synology_dsm
Traceback (most recent call last):
  File "/usr/src/homeassistant/homeassistant/config_entries.py", line 382, in async_setup
    result = await component.async_setup_entry(hass, self)
  File "/usr/src/homeassistant/homeassistant/components/synology_dsm/__init__.py", line 68, in async_setup_entry
    await api.async_setup()
  File "/usr/src/homeassistant/homeassistant/components/synology_dsm/common.py", line 94, in async_setup
    await self.dsm.surveillance_station.update()
  File "/usr/local/lib/python3.10/site-packages/synology_dsm/api/surveillance_station/__init__.py", line 25, in update
    raw_data = await self._dsm.get(self.CAMERA_API_KEY, "List", max_version=7)
  File "/usr/local/lib/python3.10/site-packages/synology_dsm/synology_dsm.py", line 207, in get
    return await self._request("GET", api, method, params, **kwargs)
  File "/usr/local/lib/python3.10/site-packages/synology_dsm/synology_dsm.py", line 282, in _request
    response = await self._execute_request(request_method, url, params, **kwargs)
  File "/usr/local/lib/python3.10/site-packages/synology_dsm/synology_dsm.py", line 308, in _execute_request
    response = await self._session.get(url, params=params, **kwargs)
  File "/usr/local/lib/python3.10/site-packages/aiohttp/client.py", line 919, in get
    self._request(hdrs.METH_GET, url, allow_redirects=allow_redirects, **kwargs)
TypeError: ClientSession._request() got an unexpected keyword argument 'max_version'

Additional information

I have an old synology NAS DS 412+ DSM version 6.2.4-25556

home-assistant[bot] commented 1 year ago

Hey there @hacf-fr, @quentame, @mib1185, mind taking a look at this issue as it has been labeled with an integration (synology_dsm) you are listed as a code owner for? Thanks!

Code owner commands Code owners of `synology_dsm` can trigger bot actions by commenting: - `@home-assistant close` Closes the issue. - `@home-assistant rename Awesome new title` Change the title of the issue. - `@home-assistant reopen` Reopen the issue. - `@home-assistant unassign synology_dsm` Removes the current integration label and assignees on the issue, add the integration domain after the command.

(message by CodeOwnersMention)


synology_dsm documentation synology_dsm source (message by IssueLinks)

estofira commented 1 year ago

After updating to 2023.2.1 i'v got the same error. I had ds920+ running dsm 7.1.1 so it is not only a dsm6 specific problem

midget1234 commented 1 year ago

Same here: DS918+ with DSM 7.1.1

merti29 commented 1 year ago

same Problem here: latest 7.1.1 on a 918+ after update to 2023.2.1: Traceback (most recent call last): File "/usr/src/homeassistant/homeassistant/config_entries.py", line 382, in async_setup result = await component.async_setup_entry(hass, self) File "/usr/src/homeassistant/homeassistant/components/synology_dsm/init.py", line 68, in async_setup_entry await api.async_setup() File "/usr/src/homeassistant/homeassistant/components/synology_dsm/common.py", line 94, in async_setup await self.dsm.surveillance_station.update() File "/usr/local/lib/python3.10/site-packages/synology_dsm/api/surveillance_station/init.py", line 25, in update raw_data = await self._dsm.get(self.CAMERA_API_KEY, "List", max_version=7) File "/usr/local/lib/python3.10/site-packages/synology_dsm/synology_dsm.py", line 207, in get return await self._request("GET", api, method, params, kwargs) File "/usr/local/lib/python3.10/site-packages/synology_dsm/synology_dsm.py", line 282, in _request response = await self._execute_request(request_method, url, params, kwargs) File "/usr/local/lib/python3.10/site-packages/synology_dsm/synology_dsm.py", line 308, in _execute_request response = await self._session.get(url, params=params, kwargs) File "/usr/local/lib/python3.10/site-packages/aiohttp/client.py", line 919, in get self._request(hdrs.METH_GET, url, allow_redirects=allow_redirects, kwargs) TypeError: ClientSession._request() got an unexpected keyword argument 'max_version'

pas86qual86 commented 1 year ago

Hi all, same error for me with a Synology DS918+ and last version DSM 7.1.1-42962 Update 2.

mib1185 commented 1 year ago