search

home-assistant / core

:house_with_garden: Open source home automation that puts local control and privacy first.
https://www.home-assistant.io
Apache License 2.0
73.56k stars 30.74k forks source link

Synology Integration Failing to after upgrade to 2023.2.1 #87357

Closed foxalerts23 closed 1 year ago

foxalerts23 commented 1 year ago

The problem

After upgrading to 2023.2.1 the Synology DSM integration is failing on 1 of the 2 Synology boxes that I have integrated. It is failing on the one that has Surveillance Station. The other Synology is on the same DSM version, but is a backup with substantially fewer packages and it does not have Surveillance Station.

What version of Home Assistant Core has the issue?

2023.2.1

What was the last working version of Home Assistant Core?

2022.12.X

What type of installation are you running?

Home Assistant Container

Integration causing the issue

Synology DSM

Link to integration documentation on our website

https://www.home-assistant.io/integrations/synology_dsm/

Diagnostics information

No response

Example YAML snippet

No response

Anything in the logs that might be useful for us?

Error setting up entry 192.168.X.X for synology_dsm
Traceback (most recent call last):
  File "/usr/src/homeassistant/homeassistant/config_entries.py", line 382, in async_setup
    result = await component.async_setup_entry(hass, self)
  File "/usr/src/homeassistant/homeassistant/components/synology_dsm/__init__.py", line 68, in async_setup_entry
    await api.async_setup()
  File "/usr/src/homeassistant/homeassistant/components/synology_dsm/common.py", line 94, in async_setup
    await self.dsm.surveillance_station.update()
  File "/usr/local/lib/python3.10/site-packages/synology_dsm/api/surveillance_station/__init__.py", line 25, in update
    raw_data = await self._dsm.get(self.CAMERA_API_KEY, "List", max_version=7)
  File "/usr/local/lib/python3.10/site-packages/synology_dsm/synology_dsm.py", line 207, in get
    return await self._request("GET", api, method, params, **kwargs)
  File "/usr/local/lib/python3.10/site-packages/synology_dsm/synology_dsm.py", line 282, in _request
    response = await self._execute_request(request_method, url, params, **kwargs)
  File "/usr/local/lib/python3.10/site-packages/synology_dsm/synology_dsm.py", line 308, in _execute_request
    response = await self._session.get(url, params=params, **kwargs)
  File "/usr/local/lib/python3.10/site-packages/aiohttp/client.py", line 919, in get
    self._request(hdrs.METH_GET, url, allow_redirects=allow_redirects, **kwargs)
TypeError: ClientSession._request() got an unexpected keyword argument 'max_version'

Additional information

No response

home-assistant[bot] commented 1 year ago

Hey there @hacf-fr, @quentame, @mib1185, mind taking a look at this issue as it has been labeled with an integration (synology_dsm) you are listed as a code owner for? Thanks!

Code owner commands Code owners of `synology_dsm` can trigger bot actions by commenting: - `@home-assistant close` Closes the issue. - `@home-assistant rename Awesome new title` Change the title of the issue. - `@home-assistant reopen` Reopen the issue. - `@home-assistant unassign synology_dsm` Removes the current integration label and assignees on the issue, add the integration domain after the command.

(message by CodeOwnersMention)

synology_dsm documentation synology_dsm source (message by IssueLinks)

MeisterTR commented 1 year ago

same here

muok commented 1 year ago

I have the same issue as well.

tramperb commented 1 year ago

Me too. I have 2 Synology NAS, both running Surveillance Station, and both are failing - same error as above.

wildoracle commented 1 year ago

same here.

richlawson commented 1 year ago

It's also failing for me. Like the OP, my Synology also has Surveillance Station running.

Nkstr commented 1 year ago

same

NateEaton commented 1 year ago

I have the same issue with my Synology DS220+ which has Surveillance Station running.

I am running Hassos on rpi 4b and the error started as soon as I upgraded to 2023.2.1.

Here is the error log: Logger: homeassistant.config_entries Source: components/synology_dsm/common.py:94 First occurred: February 3, 2023 at 9:53:08 AM (3 occurrences) Last logged: February 3, 2023 at 10:41:07 AM

Error setting up entry NAS for synology_dsm Traceback (most recent call last): File "/usr/src/homeassistant/homeassistant/config_entries.py", line 382, in async_setup result = await component.async_setup_entry(hass, self) File "/usr/src/homeassistant/homeassistant/components/synology_dsm/init.py", line 68, in async_setup_entry await api.async_setup() File "/usr/src/homeassistant/homeassistant/components/synology_dsm/common.py", line 94, in async_setup await self.dsm.surveillance_station.update() File "/usr/local/lib/python3.10/site-packages/synology_dsm/api/surveillance_station/init.py", line 25, in update raw_data = await self._dsm.get(self.CAMERA_API_KEY, "List", max_version=7) File "/usr/local/lib/python3.10/site-packages/synology_dsm/synology_dsm.py", line 207, in get return await self._request("GET", api, method, params, kwargs) File "/usr/local/lib/python3.10/site-packages/synology_dsm/synology_dsm.py", line 282, in _request response = await self._execute_request(request_method, url, params, kwargs) File "/usr/local/lib/python3.10/site-packages/synology_dsm/synology_dsm.py", line 308, in _execute_request response = await self._session.get(url, params=params, kwargs) File "/usr/local/lib/python3.10/site-packages/aiohttp/client.py", line 919, in get self._request(hdrs.METH_GET, url, allow_redirects=allow_redirects, kwargs) TypeError: ClientSession._request() got an unexpected keyword argument 'max_version'

After reading this issue and the fact that running Surveillance Station seemed to be a factor, I shut it down, restarted my Home Assistant instance and now the Synology device/entities are functioning without error.

jobvanes commented 1 year ago

Same issue here. Running HAOS in VM on a Synology

theunknownstarman commented 1 year ago

Same to me :(

Traceback (most recent call last): File "/usr/src/homeassistant/homeassistant/config_entries.py", line 382, in async_setup result = await component.async_setup_entry(hass, self) File "/usr/src/homeassistant/homeassistant/components/synology_dsm/init.py", line 68, in async_setup_entry await api.async_setup() File "/usr/src/homeassistant/homeassistant/components/synology_dsm/common.py", line 94, in async_setup await self.dsm.surveillance_station.update() File "/usr/local/lib/python3.10/site-packages/synology_dsm/api/surveillance_station/init.py", line 25, in update raw_data = await self._dsm.get(self.CAMERA_API_KEY, "List", max_version=7) File "/usr/local/lib/python3.10/site-packages/synology_dsm/synology_dsm.py", line 207, in get return await self._request("GET", api, method, params, kwargs) File "/usr/local/lib/python3.10/site-packages/synology_dsm/synology_dsm.py", line 282, in _request response = await self._execute_request(request_method, url, params, kwargs) File "/usr/local/lib/python3.10/site-packages/synology_dsm/synology_dsm.py", line 308, in _execute_request response = await self._session.get(url, params=params, kwargs) File "/usr/local/lib/python3.10/site-packages/aiohttp/client.py", line 919, in get self._request(hdrs.METH_GET, url, allow_redirects=allow_redirects, kwargs) TypeError: ClientSession._request() got an unexpected keyword argument 'max_version'

irqnet commented 1 year ago

Same here

Logger: homeassistant.config_entries
Source: components/synology_dsm/common.py:94
First occurred: 07:18:28 (6 occurrences)
Last logged: 08:31:18

Error setting up entry 192.168.20.11 for synology_dsm
Traceback (most recent call last):
  File "/usr/src/homeassistant/homeassistant/config_entries.py", line 382, in async_setup
    result = await component.async_setup_entry(hass, self)
  File "/usr/src/homeassistant/homeassistant/components/synology_dsm/__init__.py", line 68, in async_setup_entry
    await api.async_setup()
  File "/usr/src/homeassistant/homeassistant/components/synology_dsm/common.py", line 94, in async_setup
    await self.dsm.surveillance_station.update()
  File "/usr/local/lib/python3.10/site-packages/synology_dsm/api/surveillance_station/__init__.py", line 25, in update
    raw_data = await self._dsm.get(self.CAMERA_API_KEY, "List", max_version=7)
  File "/usr/local/lib/python3.10/site-packages/synology_dsm/synology_dsm.py", line 207, in get
    return await self._request("GET", api, method, params, **kwargs)
  File "/usr/local/lib/python3.10/site-packages/synology_dsm/synology_dsm.py", line 282, in _request
    response = await self._execute_request(request_method, url, params, **kwargs)
  File "/usr/local/lib/python3.10/site-packages/synology_dsm/synology_dsm.py", line 308, in _execute_request
    response = await self._session.get(url, params=params, **kwargs)
  File "/usr/local/lib/python3.10/site-packages/aiohttp/client.py", line 919, in get
    self._request(hdrs.METH_GET, url, allow_redirects=allow_redirects, **kwargs)
TypeError: ClientSession._request() got an unexpected keyword argument 'max_version'
adixus commented 1 year ago

I have the same issue as well.

goegol commented 1 year ago

Wait for version 2302.2.2 In 2302.2.2 is a fix for Synology dsm integration

dails1987 commented 1 year ago

I have the same issue as well.

serb1906 commented 1 year ago

I have the same issue as well.

mib1185 commented 1 year ago