home-assistant / core

:house_with_garden: Open source home automation that puts local control and privacy first.
https://www.home-assistant.io
Apache License 2.0
73.56k stars 30.74k forks source link

Synology fails after update 2023.2.1 #87385

Closed misterymisery closed 1 year ago

misterymisery commented 1 year ago

The problem

Logger: homeassistant.config_entries Source: components/synology_dsm/common.py:94 First occurred: February 3, 2023 at 11:05:21 PM (11 occurrences) Last logged: 12:15:54 PM

Error setting up entry 192.168.1.20 for synology_dsm Traceback (most recent call last): File "/usr/src/homeassistant/homeassistant/config_entries.py", line 382, in async_setup result = await component.async_setup_entry(hass, self) File "/usr/src/homeassistant/homeassistant/components/synology_dsm/init.py", line 68, in async_setup_entry await api.async_setup() File "/usr/src/homeassistant/homeassistant/components/synology_dsm/common.py", line 94, in async_setup await self.dsm.surveillance_station.update() File "/usr/local/lib/python3.10/site-packages/synology_dsm/api/surveillance_station/init.py", line 25, in update raw_data = await self._dsm.get(self.CAMERA_API_KEY, "List", max_version=7) File "/usr/local/lib/python3.10/site-packages/synology_dsm/synology_dsm.py", line 207, in get return await self._request("GET", api, method, params, kwargs) File "/usr/local/lib/python3.10/site-packages/synology_dsm/synology_dsm.py", line 282, in _request response = await self._execute_request(request_method, url, params, kwargs) File "/usr/local/lib/python3.10/site-packages/synology_dsm/synology_dsm.py", line 308, in _execute_request response = await self._session.get(url, params=params, kwargs) File "/usr/local/lib/python3.10/site-packages/aiohttp/client.py", line 919, in get self._request(hdrs.METH_GET, url, allow_redirects=allow_redirects, kwargs) TypeError: ClientSession._request() got an unexpected keyword argument 'max_version'

What version of Home Assistant Core has the issue?

2023.2.1

What was the last working version of Home Assistant Core?

No response

What type of installation are you running?

Home Assistant OS

Integration causing the issue

Synology dsm

Link to integration documentation on our website

No response

Diagnostics information

No response

Example YAML snippet

No response

Anything in the logs that might be useful for us?

No response

Additional information

No response

Mask3007 commented 1 year ago

Seems to be a duplicate of: https://github.com/home-assistant/core/issues/87204

GigiPompieru commented 1 year ago

Seems to be a duplicate of: #87204

that one is for the previous version. the issue is still present in 2023.2.1.

Mask3007 commented 1 year ago

Yeah but fixed 17h ago. So would still be there in 2023.2.1 since this patch is older

mib1185 commented 1 year ago