home-assistant / core

:house_with_garden: Open source home automation that puts local control and privacy first.
https://www.home-assistant.io
Apache License 2.0
71.59k stars 29.91k forks source link

Upgrade to 2023.2.1 breaks Synology DSM integration #87419

Closed thedude911 closed 1 year ago

thedude911 commented 1 year ago

The problem

My DSM integration was running fine, until the upgrade to 2023.2.1. Now there is a protocol error and also removing the integration and creating it from scratch did not solve the issue.

Traceback (most recent call last): File "/usr/src/homeassistant/homeassistant/config_entries.py", line 382, in async_setup result = await component.async_setup_entry(hass, self) File "/usr/src/homeassistant/homeassistant/components/synology_dsm/init.py", line 68, in async_setup_entry await api.async_setup() File "/usr/src/homeassistant/homeassistant/components/synology_dsm/common.py", line 94, in async_setup await self.dsm.surveillance_station.update() File "/usr/local/lib/python3.10/site-packages/synology_dsm/api/surveillance_station/init.py", line 25, in update raw_data = await self._dsm.get(self.CAMERA_API_KEY, "List", max_version=7) File "/usr/local/lib/python3.10/site-packages/synology_dsm/synology_dsm.py", line 207, in get return await self._request("GET", api, method, params, kwargs) File "/usr/local/lib/python3.10/site-packages/synology_dsm/synology_dsm.py", line 282, in _request response = await self._execute_request(request_method, url, params, kwargs) File "/usr/local/lib/python3.10/site-packages/synology_dsm/synology_dsm.py", line 308, in _execute_request response = await self._session.get(url, params=params, kwargs) File "/usr/local/lib/python3.10/site-packages/aiohttp/client.py", line 919, in get self._request(hdrs.METH_GET, url, allow_redirects=allow_redirects, kwargs) TypeError: ClientSession._request() got an unexpected keyword argument 'max_version'

What version of Home Assistant Core has the issue?

2023.2.1

What was the last working version of Home Assistant Core?

2023.1.x

What type of installation are you running?

Home Assistant OS

Integration causing the issue

Synology DSM

Link to integration documentation on our website

https://www.home-assistant.io/integrations/synology_dsm

Diagnostics information

Logger: homeassistant.components.synology_dsm.config_flow Source: components/synology_dsm/config_flow.py:247 Integration: Synology DSM (documentation, issues) First occurred: 20:53:18 (1 occurrences) Last logged: 20:53:18

{'api': None, 'code': -1, 'reason': 'Unknown', 'details': "ClientConnectorCertificateError = ConnectionKey(host='192.168.0.100', port=5333, is_ssl=True, ssl=None, proxy=None, proxy_auth=None, proxy_headers_hash=-6347515361654758992)"}

Example YAML snippet

No response

Anything in the logs that might be useful for us?

No response

Additional information

DSM is running with a custom port and valid Letsencrypt certificate

home-assistant[bot] commented 1 year ago

Hey there @hacf-fr, @quentame, @mib1185, mind taking a look at this issue as it has been labeled with an integration (synology_dsm) you are listed as a code owner for? Thanks!

Code owner commands Code owners of `synology_dsm` can trigger bot actions by commenting: - `@home-assistant close` Closes the issue. - `@home-assistant rename Awesome new title` Change the title of the issue. - `@home-assistant reopen` Reopen the issue. - `@home-assistant unassign synology_dsm` Removes the current integration label and assignees on the issue, add the integration domain after the command.

(message by CodeOwnersMention)


synology_dsm documentation synology_dsm source (message by IssueLinks)

bdraco commented 1 year ago

already fixed via https://github.com/home-assistant/core/pull/87324

tanderloco commented 1 year ago

Same error at start-up in 2023.2.2

bdraco commented 1 year ago

2023.2.2 isn't out yet so not sure how that's possible

tanderloco commented 1 year ago

Sorry, you are correct - I was mistakenly looking at the frontend version number.