home-assistant / core

:house_with_garden: Open source home automation that puts local control and privacy first.
https://www.home-assistant.io
Apache License 2.0
71.34k stars 29.88k forks source link

Expose child lock and open window detection ValveHeatingTemperatureInterface (io:HeatingValveIOComponent) #88811

Open iMicknl opened 1 year ago

iMicknl commented 1 year ago

The problem

Add a switch to enable/disable child lock and open window detection.

Will require changes to how switches work in Overkiz, since currently the ValveHeatingTemperatureInterface is already mapped to climate.

image image

What version of Home Assistant Core has the issue?

2023.2.5

What was the last working version of Home Assistant Core?

No response

What type of installation are you running?

Home Assistant OS

Integration causing the issue

overkiz

Link to integration documentation on our website

https://www.home-assistant.io/integrations/overkiz/

Diagnostics information

No response

Example YAML snippet

No response

Anything in the logs that might be useful for us?

No response

Additional information

No response

home-assistant[bot] commented 1 year ago

Hey there @vlebourl, @tetienne, @nyrodev, mind taking a look at this issue as it has been labeled with an integration (overkiz) you are listed as a code owner for? Thanks!

Code owner commands Code owners of `overkiz` can trigger bot actions by commenting: - `@home-assistant close` Closes the issue. - `@home-assistant rename Awesome new title` Renames the issue. - `@home-assistant reopen` Reopen the issue. - `@home-assistant unassign overkiz` Removes the current integration label and assignees on the issue, add the integration domain after the command.

(message by CodeOwnersMention)


overkiz documentation overkiz source (message by IssueLinks)

iMicknl commented 1 year ago
    OverkizSwitchDescription(
        key=UIWidget.VALVE_HEATING_TEMPERATURE_INTERFACE,
        name="Open window detection",
        turn_on=OverkizCommand.SET_VALVE_SETTINGS,
        turn_on_args={OverkizCommandParam.OPEN_WINDOW: True},
        turn_off=OverkizCommand.SET_VALVE_SETTINGS,
        turn_off_args={OverkizCommandParam.OPEN_WINDOW: False},
        is_on=lambda select_state: (
            select_state(OverkizState.CORE_OPEN_WINDOW_DETECTION_ACTIVATION)
            == OverkizCommandParam.ACTIVE
        ),
        icon="mdi:window-open",
        entity_category=EntityCategory.CONFIG,
    ),
    OverkizSwitchDescription(
        key=UIWidget.VALVE_HEATING_TEMPERATURE_INTERFACE,
        name="Child lock",
        turn_on=OverkizCommand.SET_VALVE_SETTINGS,
        turn_on_args={OverkizCommandParam.LOCK_KEY: True},
        turn_off=OverkizCommand.SET_VALVE_SETTINGS,
        turn_off_args={OverkizCommandParam.LOCK_KEY: False},
        is_on=lambda select_state: (
            select_state(OverkizState.IO_LOCK_KEY_ACTIVATION)
            == OverkizCommandParam.ENABLE
        ),
        icon="mdi:lock",
        entity_category=EntityCategory.CONFIG,
    ),
legantois commented 1 year ago

Do you know when this would be available ?

iMicknl commented 1 year ago

Currently I don't have time to work on this. It needs a partly rewrite of the Switch entity, thus not easy for me to just squeeze in when I have some spare time.

legantois commented 1 year ago

Hello Mick. How could we help you 😀?

issue-triage-workflows[bot] commented 1 year ago

There hasn't been any activity on this issue recently. Due to the high number of incoming GitHub notifications, we have to clean some of the old issues, as many of them have already been resolved with the latest updates. Please make sure to update to the latest Home Assistant version and check if that solves the issue. Let us know if that works for you by adding a comment 👍 This issue has now been marked as stale and will be closed if no further activity occurs. Thank you for your contributions.

legantois commented 1 year ago

Issue not solved

issue-triage-workflows[bot] commented 9 months ago

There hasn't been any activity on this issue recently. Due to the high number of incoming GitHub notifications, we have to clean some of the old issues, as many of them have already been resolved with the latest updates. Please make sure to update to the latest Home Assistant version and check if that solves the issue. Let us know if that works for you by adding a comment 👍 This issue has now been marked as stale and will be closed if no further activity occurs. Thank you for your contributions.

legantois commented 9 months ago

not solved

issue-triage-workflows[bot] commented 6 months ago

There hasn't been any activity on this issue recently. Due to the high number of incoming GitHub notifications, we have to clean some of the old issues, as many of them have already been resolved with the latest updates. Please make sure to update to the latest Home Assistant version and check if that solves the issue. Let us know if that works for you by adding a comment 👍 This issue has now been marked as stale and will be closed if no further activity occurs. Thank you for your contributions.

issue-triage-workflows[bot] commented 3 months ago

There hasn't been any activity on this issue recently. Due to the high number of incoming GitHub notifications, we have to clean some of the old issues, as many of them have already been resolved with the latest updates. Please make sure to update to the latest Home Assistant version and check if that solves the issue. Let us know if that works for you by adding a comment 👍 This issue has now been marked as stale and will be closed if no further activity occurs. Thank you for your contributions.

legantois commented 3 months ago

not done yet

issue-triage-workflows[bot] commented 2 weeks ago

There hasn't been any activity on this issue recently. Due to the high number of incoming GitHub notifications, we have to clean some of the old issues, as many of them have already been resolved with the latest updates. Please make sure to update to the latest Home Assistant version and check if that solves the issue. Let us know if that works for you by adding a comment 👍 This issue has now been marked as stale and will be closed if no further activity occurs. Thank you for your contributions.

legantois commented 2 weeks ago

Not solved