home-assistant / core

:house_with_garden: Open source home automation that puts local control and privacy first.
https://www.home-assistant.io
Apache License 2.0
71.75k stars 30k forks source link

Issue with livisi integration, climate devices, turn off and temp #90630

Closed ThMFlive closed 1 year ago

ThMFlive commented 1 year ago

The problem

What version of Home Assistant Core has the issue?

2023.4.0b3

What was the last working version of Home Assistant Core?

2023.3

What type of installation are you running?

Home Assistant Core

Integration causing the issue

livisi

Link to integration documentation on our website

No response

Diagnostics information

No response

Example YAML snippet

hvac_modes:
  - heat
min_temp: 7
max_temp: 35
current_temperature: 16.3
temperature: 7
current_humidity: 61.5
friendly_name: xxxxxxxxx
supported_features: 1

Anything in the logs that might be useful for us?

No response

Additional information

No response

home-assistant[bot] commented 1 year ago

Hey there @stefaniacoblivisi, @planbnet, mind taking a look at this issue as it has been labeled with an integration (livisi) you are listed as a code owner for? Thanks!

Code owner commands Code owners of `livisi` can trigger bot actions by commenting: - `@home-assistant close` Closes the issue. - `@home-assistant rename Awesome new title` Renames the issue. - `@home-assistant reopen` Reopen the issue. - `@home-assistant unassign livisi` Removes the current integration label and assignees on the issue, add the integration domain after the command.

(message by CodeOwnersMention)


livisi documentation livisi source (message by IssueLinks)

planbnet commented 1 year ago

You are right, the min and max temperature can (and should) be read from the controller, but afaik there's no possibility to turn off a climate device. How would you do so in the Livisi web ui?

ThMFlive commented 1 year ago

If I turn the temperature at the wall thermostat or heating thermostat completely down, "Off" is displayed and only the frost protection is activated in the background.

planbnet commented 1 year ago

In the Livisi integration, the room climate is controlled, not a single thermostat (though even those don't seem to have an "off" property). I guess it simply displays "off" if the temp equals the frost protection temp (which is 6°C by default)

qschneider commented 1 year ago

Hi, we discussed the current tvr behaviour in more detail in the german livisi forum #165

To me the discussed problems could be fixed by a. implementing the HVACMode.OFF (that could be internally setting the set-temperature to min-temperature b. implementing HVACAction.OFF, HVACAction.HEATING and HVACAction.IDLE to display the correct behavior in the lovelace card and diagrams. Also this could be achieved by internally comparing temperature to current_temperature and setting the HVACAction accordingly.

for more detail https://developers.home-assistant.io/docs/core/entity/climate/

If i use a custom climate component i can achieve the desired behavior vs the current implemented as you can see in the screenshots.

Bildschirmfoto 2023-03-30 um 20 28 17 Bildschirmfoto 2023-03-30 um 20 28 04
planbnet commented 1 year ago

Thanks for pointing in the right direction @qschneider. I'm not sure if emulating HVACMode.OFF mode is helpful though. There's no indication what that value should be set to when it is changed back to HEAT in the UI. The way I see it, the Livsi climate devcies only support HEAT (there are only theromostat devices, no AC units and they can't be turned off completely). The correct way would probably be to also support AUTO (if there are temperatures schedules defined in the controller), but that would require the possibility to enable and disable the schedules from within HASS.

qschneider commented 1 year ago

Hi, is there any chance that you fix the state that shows "heating" all the time even if the temperature is above set-temperature and the valve is closed? Does it maybe help to look at other manufactures climate implementations? I know that tado, among others, is showing the state as expected. Thanks for your efforts and your time as i know this work is done by the community! Regards

planbnet commented 1 year ago

It does not show the state as „heating“. Is shows the flame icon because the thermostat mode is „heating“. This is the only possible mode for this device, because there is no AC, Fan or schedule mode (well in fact there would be a schedule mode but as this is it explicitly declared in the livisi controller that’s not as simple to map). In my first attempt to “fix“ this, I set the available modes to an empty list which fixed the problem you are seeing (it does not show any icon at all) but that is not allowed in hass.

The closest to fixing this is correctly implementing the HVACAction (as you propose) which will then show the state as "Heating", "Idle" or "Off" (but the mode will still be HVACMode.HEAT). This will draw the "red fills"correctly like in your second screenshot. See https://github.com/home-assistant/core/pull/90716

qschneider commented 1 year ago

That would be great! This will also offer livisi users to use an easy "multi-sensor" climate implementation like the following so they can make the most use of their hardware. https://github.com/KartoffelToby/better_thermostat

ThMFlive commented 1 year ago

It seems like there is no action on the linked bugfix for more than a week.

https://github.com/home-assistant/core/pull/90716

A review is outstanding. Is there no priority on this bugfixes to use the new devices correctly?

frenck commented 1 year ago

As per review in PR #90716, this device doesn't support reporting its current HVAC action, therefore, Home Assistant cannot/should not report it either.

Closing this issue as well, as it is not a bug, but a limitation of the device.

../Frenck