home-assistant / core

:house_with_garden: Open source home automation that puts local control and privacy first.
https://www.home-assistant.io
Apache License 2.0
69.75k stars 28.91k forks source link

Problem with Command in new JVC Projector Integration #94531

Closed CineMAC-HA closed 4 months ago

CineMAC-HA commented 1 year ago

The problem

First thanks for the great Integration!! The Command "setting_memory" not function on my JVC NP5 Projector. All the other commands functionally fine.

What version of Home Assistant Core has the issue?

2023.6.1

What was the last working version of Home Assistant Core?

No response

What type of installation are you running?

Home Assistant OS

Integration causing the issue

No response

Link to integration documentation on our website

No response

Diagnostics information

No response

Example YAML snippet

No response

Anything in the logs that might be useful for us?

No response

Additional information

No response

home-assistant[bot] commented 1 year ago

Hey there @steveeasley, mind taking a look at this issue as it has been labeled with an integration (jvc_projector) you are listed as a code owner for? Thanks!

Code owner commands Code owners of `jvc_projector` can trigger bot actions by commenting: - `@home-assistant close` Closes the issue. - `@home-assistant rename Awesome new title` Renames the issue. - `@home-assistant reopen` Reopen the issue. - `@home-assistant unassign jvc_projector` Removes the current integration label and assignees on the issue, add the integration domain after the command.

(message by CodeOwnersMention)


jvc_projector documentation jvc_projector source (message by IssueLinks)

CineMAC-HA commented 1 year ago

Hi, any news to this "issue" or is that a compatibility Problem from my NP5? I wondering because all other commands working fine. I am very happy about this integration. Thanks again for this great work! :-)

issue-triage-workflows[bot] commented 9 months ago

There hasn't been any activity on this issue recently. Due to the high number of incoming GitHub notifications, we have to clean some of the old issues, as many of them have already been resolved with the latest updates. Please make sure to update to the latest Home Assistant version and check if that solves the issue. Let us know if that works for you by adding a comment 👍 This issue has now been marked as stale and will be closed if no further activity occurs. Thank you for your contributions.

CineMAC-HA commented 9 months ago

Thanks for response. The Problem ist not fix for me. I thing I am alone with this ;-) Maybe the problem is only by the NP5 Model. I don't know.

Thanks and Regards Frank

Pauldy commented 9 months ago

You aren't alone, I have an NZ8 and I just tried it, doesn't work on 2023.10. I was going to use it to set aspect ratio based off what was in the lense profile for plex movies.

Pauldy commented 9 months ago

I'll add picture_mode, mpc are also non functional from the list of available commands. The remote control calls do work.

Pauldy commented 9 months ago

So I got a bit of time to poke around and it looks like the culprit is here.

https://pypi.org/project/pyjvcprojector/

This is the library used to control the projector from home assistant. I haven't found the specs they are using yet but I suspect the wrong code for those items on newer ilda firmware.

CineMAC-HA commented 9 months ago

Hello, thank you for your answer. I thought I had to buy a new projector ;-) Let's hope that the problem can still be solved. I would be happy

FlanLucky commented 8 months ago

Hello,

I own the JVC DLA-X7900 projector but it seems the HA integration is also missing some commands (memorised custom lens modes : Mode1, Mode2, Mode3) I am listing below the remote control codes extracted from the projector guide that should be used (hightlighted in yellow)

image

Thanks a lot if the developer could give us some feedback. Have a nice day.

anupmurarka commented 5 months ago

Confirming that mpc, picture_mode, setting_memory don't work for DLA-NZ7. The model info returned by JvcProjector::get_info() is {'model': 'ILAFPJ-B5A3', 'mac': 'redacted'}.

A similar library (bezmi/jvc_projector) does have a working setting_memory command but calls it installation_mode

anupmurarka commented 5 months ago

I submitted a PR to the upstream python library to correct the 3 non-working codes and added the 3 MODE codes described above by @FlanLucky.

Once this is merged, hopefully Steve will submit a PR for the integration to use the new codes. I can do it if he's unable to get to it. The updated codes should work as long as python library gets updated somehow within my installation - I still need to learn how/if that happens.

SteveEasley commented 5 months ago

Thanks for the PR @anupmurarka. That fixes the two invalid remote codes, and I added a handful of new ones as well. Hopefully will get into the next HA release soon.

CineMAC-HA commented 5 months ago

That are top news and I am very happy about this. Thank you all for this great integration and our private time for this.

Thanks and regards Frank

anupmurarka commented 4 months ago

thanks @SteveEasley changes are live with 2024.2.0 - initial testing is positive so far, previously reported non-working codes are fixed.

FlanLucky commented 4 months ago

Testing positive also for mode1 mode2 mode3 codes. Thanks so much for your time. Just great.

SteveEasley commented 4 months ago

@home-assistant close