home-assistant / core

:house_with_garden: Open source home automation that puts local control and privacy first.
https://www.home-assistant.io
Apache License 2.0
71.15k stars 29.82k forks source link

Unable to disable Assist integration #94932

Closed acshef closed 10 months ago

acshef commented 1 year ago

The problem

Expected behavior: With default_config and conversation commented out in configuration.yaml, the Assist integration should not load (and there should be no icon in the top-right of the menu bar).

Current (incorrect) behavior: Assist integration seems to be enabled (icon is present in functional, "Voice assistants" setting is present in more-info entity dialog, etc.) even if default_config, conversation, and mobile_app is commented out in configuration.yaml.

What version of Home Assistant Core has the issue?

core-2023.6.2

What was the last working version of Home Assistant Core?

No response

What type of installation are you running?

Home Assistant OS

Integration causing the issue

conversation

Link to integration documentation on our website

https://www.home-assistant.io/voice_control/

Diagnostics information

No response

Example YAML snippet

# Configuration.yaml (some sections redacted with "...")

homeassistant:
    ...

api:
automation: !include automations.yaml
binary_sensor: !include binary_sensors.yaml
# cloud:
config:
# conversation:
counter:
# default_config:
device_tracker: !include device_tracker.yaml
dhcp:
# discovery:
google_assistant: !include google_assistant.yaml
group: !include groups.yaml
hardware:
history:
homeassistant_alerts:
homekit: !include homekit.yaml
image_upload:
input_boolean:
input_button:
input_datetime:
input_number:
input_select:
input_text:
logbook:
logger:
# map:
mobile_app:
mqtt: !include mqtt_config.yaml
my:
network:
notify: !include notify.yaml
person:
python_script:
recorder: !include recorder.yaml
rest: !include rest.yaml
scene: !include scenes.yaml
schedule:
scrape: !include scrape.yaml
script: !include scripts.yaml
sensor: !include sensors.yaml
ssdp:
stream:
sun:
switch: !include switches.yaml
system_health:
template: !include template_config.yaml
usb:
wake_on_lan:
webhook:
zeroconf:
zone:

http:
    ...

ffmpeg:
    ...

frontend:
    themes: !include_dir_merge_named themes # Required directive for HACS themes
    ...

rest_command:
    ...

shell_command:
    ...

timer:
    ...

command_line:
    ...

Anything in the logs that might be useful for us?

No response

Additional information

No response

acshef commented 1 year ago

Paging code owner @synesthesiam - the issue didn't seem to get tagged with the conversation integration label.

home-assistant[bot] commented 1 year ago

Hey there @home-assistant/core, @synesthesiam, mind taking a look at this issue as it has been labeled with an integration (conversation) you are listed as a code owner for? Thanks!

Code owner commands Code owners of `conversation` can trigger bot actions by commenting: - `@home-assistant close` Closes the issue. - `@home-assistant rename Awesome new title` Renames the issue. - `@home-assistant reopen` Reopen the issue. - `@home-assistant unassign conversation` Removes the current integration label and assignees on the issue, add the integration domain after the command.

(message by CodeOwnersMention)


conversation documentation conversation source (message by IssueLinks)

synesthesiam commented 1 year ago

Do you use ESPHome or VoIP? Those will pull in Assist too.

acshef commented 1 year ago

Do you use ESPHome or VoIP? Those will pull in Assist too.

@synesthesiam I am using ESPHome. So, two questions:

  1. How did you know which other integrations load the conversation? Hopefully it's not tribal knowledge -- is there some analysis of the Home Assistant codebase that I can use to determine this in the future?
  2. Are there plans to actually allow opting out of the conversational components of Home Assistant? I don't have concerns about privacy or anything, but I don't have devices that can make use of the TTS/STT (just a desktop PC and/or a wall-mounted tablet, none with a microphone), and I have no intentions of pursuing them. Obviously a big draw to Home Assistant is the modularity and customizability, and I value the ability to conserve screen real estate and whatever meager resources I can on my system that runs Home Assistant.

Thanks in advance.

synesthesiam commented 1 year ago

ESPHome has a dependency on the assist_pipeline integration, which depends on conversation. This is in their respective manifest files.

I believe these could be made optional with "after dependencies": https://developers.home-assistant.io/docs/creating_integration_manifest/#after-dependencies

PR's are always welcome 🙂

issue-triage-workflows[bot] commented 11 months ago

There hasn't been any activity on this issue recently. Due to the high number of incoming GitHub notifications, we have to clean some of the old issues, as many of them have already been resolved with the latest updates. Please make sure to update to the latest Home Assistant version and check if that solves the issue. Let us know if that works for you by adding a comment 👍 This issue has now been marked as stale and will be closed if no further activity occurs. Thank you for your contributions.