home-assistant / core

:house_with_garden: Open source home automation that puts local control and privacy first.
https://www.home-assistant.io
Apache License 2.0
73.43k stars 30.67k forks source link

Jewish Times doesn't show the right hebcal values relative to the Hebcal website #95111

Closed salonluden closed 1 year ago

salonluden commented 1 year ago

The problem

The Jewish Times integration shows different times than on their website. For example, todays date is June 23, 2023. On the hebcal website, the time for candle lighting is 19:21 (link here)

image

(later on this value can be seen by clicking on the calendar button).

However, in Home Assistant, the value is 19:33. Even when forcing the latitude and longtitude to use the HebCal supported values (from here according to here), the values are 19:33.

What version of Home Assistant Core has the issue?

2023.6.2

What was the last working version of Home Assistant Core?

No response

What type of installation are you running?

Home Assistant OS

Integration causing the issue

jewish_calendar

Link to integration documentation on our website

https://www.home-assistant.io/integrations/jewish_calendar

Diagnostics information

No response

Example YAML snippet

jewish_calendar:
  language: hebrew
  latitude: 32.56645 # and without
  longitude: 34.95628 # and without
  diaspora: False

Anything in the logs that might be useful for us?

No response

Additional information

No response

home-assistant[bot] commented 1 year ago

Hey there @tsvi, mind taking a look at this issue as it has been labeled with an integration (jewish_calendar) you are listed as a code owner for? Thanks!

Code owner commands Code owners of `jewish_calendar` can trigger bot actions by commenting: - `@home-assistant close` Closes the issue. - `@home-assistant rename Awesome new title` Renames the issue. - `@home-assistant reopen` Reopen the issue. - `@home-assistant unassign jewish_calendar` Removes the current integration label and assignees on the issue, add the integration domain after the command.

(message by CodeOwnersMention)


jewish_calendar documentation jewish_calendar source (message by IssueLinks)

tsvi commented 1 year ago

The reason for that is because Zihron Yaakov uses the non-defualt value of 30 minutes before sundown. You can set this offset for the integration as specified here: https://www.home-assistant.io/integrations/jewish_calendar#candle_lighting_minutes_before_sunset

salonluden commented 1 year ago

Ah interesting. I changed it and the values work as expected - thanks!