home-assistant / core

:house_with_garden: Open source home automation that puts local control and privacy first.
https://www.home-assistant.io
Apache License 2.0
73.51k stars 30.71k forks source link

Mismatched units in zhimi.fan.za5 Delay Off Countdown input #95195

Open Gvolten opened 1 year ago

Gvolten commented 1 year ago

The problem

Probably due to this (#94428) Pull Request, the Delay Off Countdown entity has seconds as its input instead of minutes, but the min unit is still displayed in the UI. (At least in the Czech version. I'm not sure about the others.)

What version of Home Assistant Core has the issue?

core-2023.6.2

What was the last working version of Home Assistant Core?

No response

What type of installation are you running?

Home Assistant OS

Integration causing the issue

Xiaomi Miio

Link to integration documentation on our website

https://www.home-assistant.io/integrations/xiaomi_miio

Diagnostics information

No response

Example YAML snippet

No response

Anything in the logs that might be useful for us?

No response

Additional information

No response

home-assistant[bot] commented 1 year ago

Hey there @rytilahti, @syssi, @starkillerog, mind taking a look at this issue as it has been labeled with an integration (xiaomi_miio) you are listed as a code owner for? Thanks!

Code owner commands Code owners of `xiaomi_miio` can trigger bot actions by commenting: - `@home-assistant close` Closes the issue. - `@home-assistant rename Awesome new title` Renames the issue. - `@home-assistant reopen` Reopen the issue. - `@home-assistant unassign xiaomi_miio` Removes the current integration label and assignees on the issue, add the integration domain after the command.

(message by CodeOwnersMention)


xiaomi_miio documentation xiaomi_miio source (message by IssueLinks)

Gvolten commented 1 year ago

The issue is still present in core-2023.6.3 For some reason, the upper bound on the input is also just 480 seconds (just 8 minutes), which definitely is not enough.

Gvolten commented 1 year ago

I think that the original PR was supposed to make it in minutes (based on this issue https://github.com/home-assistant/core/issues/91824), but my model (zhimi.fan.za5) accepts the input in seconds.

syssi commented 1 year ago

It's due to #94428. We fixed the unit conversion for other models here which did break the behaviour of your device. The root cause should be fixed here: https://github.com/rytilahti/python-miio/issues/1786

Jonnas90 commented 1 year ago

I just got a new zhimi.fan.za5 and the issue occurs again. I'm on home assistant core 2023.8.2. Thanks in advance!

rbakkers commented 1 year ago

I have the same issue. If you set the delay in the Mii app to one hour it show up correctly as 3600 in the Home Assistant UI. But you cannot set the value to anything higher than 480. Which is indeed 8 minutes.

issue-triage-workflows[bot] commented 11 months ago

There hasn't been any activity on this issue recently. Due to the high number of incoming GitHub notifications, we have to clean some of the old issues, as many of them have already been resolved with the latest updates. Please make sure to update to the latest Home Assistant version and check if that solves the issue. Let us know if that works for you by adding a comment 👍 This issue has now been marked as stale and will be closed if no further activity occurs. Thank you for your contributions.

Gvolten commented 11 months ago

Still an issue

issue-triage-workflows[bot] commented 8 months ago

There hasn't been any activity on this issue recently. Due to the high number of incoming GitHub notifications, we have to clean some of the old issues, as many of them have already been resolved with the latest updates. Please make sure to update to the latest Home Assistant version and check if that solves the issue. Let us know if that works for you by adding a comment 👍 This issue has now been marked as stale and will be closed if no further activity occurs. Thank you for your contributions.

Gvolten commented 8 months ago

Still an issue

rapejim commented 5 months ago

The same problem with zhimi.fan.za4 model.

ramos45 commented 3 months ago

Same problem on zhimi.fan.za4

mbaiti commented 2 months ago

Also on zhimi.fan.za5