home-assistant / core

:house_with_garden: Open source home automation that puts local control and privacy first.
https://www.home-assistant.io
Apache License 2.0
69.72k stars 28.87k forks source link

Adding inverter doesn't add inverter name to entity ID #96606

Open thibaultmol opened 11 months ago

thibaultmol commented 11 months ago

The problem

I'm guessing this was done on purpose since most people only have one inverter.

But it's a problem for people like me who have 3 inverters. If I add three. Then I would like to rename the device (and then it's Entitiy id's) to say INVERTER1, INVERTER2, INVERTER3. But I can't use the auto rename of the entity id's because the device name isn't in the entity id when you first add the device to HA.

What version of Home Assistant Core has the issue?

core-2023.7.2

What was the last working version of Home Assistant Core?

No response

What type of installation are you running?

Home Assistant OS

Integration causing the issue

Goodwe

Link to integration documentation on our website

https://www.home-assistant.io/integrations/goodwe/

Diagnostics information

No response

Example YAML snippet

No response

Anything in the logs that might be useful for us?

No response

Additional information

No response

home-assistant[bot] commented 11 months ago

Hey there @mletenay, @starkillerog, mind taking a look at this issue as it has been labeled with an integration (goodwe) you are listed as a code owner for? Thanks!

Code owner commands Code owners of `goodwe` can trigger bot actions by commenting: - `@home-assistant close` Closes the issue. - `@home-assistant rename Awesome new title` Renames the issue. - `@home-assistant reopen` Reopen the issue. - `@home-assistant unassign goodwe` Removes the current integration label and assignees on the issue, add the integration domain after the command.

(message by CodeOwnersMention)


goodwe documentation goodwe source (message by IssueLinks)

issue-triage-workflows[bot] commented 8 months ago

There hasn't been any activity on this issue recently. Due to the high number of incoming GitHub notifications, we have to clean some of the old issues, as many of them have already been resolved with the latest updates. Please make sure to update to the latest Home Assistant version and check if that solves the issue. Let us know if that works for you by adding a comment 👍 This issue has now been marked as stale and will be closed if no further activity occurs. Thank you for your contributions.

thibaultmol commented 8 months ago

still an issue

mletenay commented 8 months ago

@thibaultmol To be honest, I do not understand the problem. What are you suggesting the integration should do ?

bjoernwolter commented 6 months ago

Same problem with my installation

@thibaultmol To be honest, I do not understand the problem. What are you suggesting the integration should do ?

The Integration creates entity ids without the inverters name as prefix. For example it creates an entity with the id sensor.load or sensor.warning_code this is of course not very meaningful. Better would be an id like sensor.goodwe_load order sensor.goodwe_warning_code

Since the integration creates over 140 entities, it is very time-consuming to rename them all by hand

issue-triage-workflows[bot] commented 3 months ago

There hasn't been any activity on this issue recently. Due to the high number of incoming GitHub notifications, we have to clean some of the old issues, as many of them have already been resolved with the latest updates. Please make sure to update to the latest Home Assistant version and check if that solves the issue. Let us know if that works for you by adding a comment 👍 This issue has now been marked as stale and will be closed if no further activity occurs. Thank you for your contributions.

thibaultmol commented 3 months ago

I think the integration should create devices/entity's with unique names. Currently i think it creates devices using a standard name. which means if you add more than one inverter it starts creating names that are harder to rename

issue-triage-workflows[bot] commented 1 week ago

There hasn't been any activity on this issue recently. Due to the high number of incoming GitHub notifications, we have to clean some of the old issues, as many of them have already been resolved with the latest updates. Please make sure to update to the latest Home Assistant version and check if that solves the issue. Let us know if that works for you by adding a comment 👍 This issue has now been marked as stale and will be closed if no further activity occurs. Thank you for your contributions.

thibaultmol commented 1 week ago

(still relevant)