home-assistant / core

:house_with_garden: Open source home automation that puts local control and privacy first.
https://www.home-assistant.io
Apache License 2.0
71.11k stars 29.79k forks source link

Change of Tilt functionality breaks KNX covers #98566

Closed h3rbst closed 8 months ago

h3rbst commented 1 year ago

The problem

Hi, I updated to the newest Version 2023.8 of Home Assistant. I do not understand the reason for Pullrequest #96192 , but theses changes for me break my KNX covers. Before the update I was able to tilt my covers step by step in the UI. Now this is not possible anymore, since it does not use the move_short address anymore and just sends the angle position 0 e.g. Please revert this pullrequest or give an option to use the move_short address again.

What version of Home Assistant Core has the issue?

core-2023.8.1

What was the last working version of Home Assistant Core?

core-2023.7.3

What type of installation are you running?

Home Assistant OS

Integration causing the issue

KNX

Link to integration documentation on our website

https://www.home-assistant.io/integrations/knx/

Diagnostics information

No response

Example YAML snippet

No response

Anything in the logs that might be useful for us?

No response

Additional information

No response

home-assistant[bot] commented 1 year ago

Hey there @julius2342, @farmio, @marvin-w, mind taking a look at this issue as it has been labeled with an integration (knx) you are listed as a code owner for? Thanks!

Code owner commands Code owners of `knx` can trigger bot actions by commenting: - `@home-assistant close` Closes the issue. - `@home-assistant rename Awesome new title` Renames the issue. - `@home-assistant reopen` Reopen the issue. - `@home-assistant unassign knx` Removes the current integration label and assignees on the issue, add the integration domain after the command.

(message by CodeOwnersMention)


knx documentation knx source (message by IssueLinks)

farmio commented 1 year ago

Hi 👋! See https://github.com/home-assistant/core/issues/96129 for the reason behind the change.

Unfortunately the UIs default cover card just calls the close_cover_tilt method. It is not expected to do stepwise movements. I guess the intended way is to hit the "stop" button.

There are 3 workarounds coming to my mind currently

h3rbst commented 1 year ago

I'm very sorry but totally not with you. I think in the past it worked 100% as it should, because it worked like normal KNX-Button/Panel. There you can move the covers, in my case raffstores, a) completely up or down with long press b) move them step by step so that the lamellae turn around and you can try out which angle fits best

For me it makes absolutely no sense to have two buttons where I can "differentiate" between a) Lamellae are completely closed and no sun comes through b) Lamellae are completely (but the other way around) closed and no sun comes through → same result as a)

Are you using Raffstores as well? Can not imagine you want it in another way :-P

The workarounds for me does not make sense since:

  1. This is already programmed in the KNX shutter actuator and is differently between windows (some are 25%, some are 10% per step)
  2. As you wrote, not only slider will not work, something like 50% (which is perfect against sun but still can see through) will not work too
  3. My wife will kill me

Would really love if we could find a way so it worked like before and to be KNX STANDARD again

h3rbst commented 12 months ago

@farmio how could we go on here to fit both worlds needs?

farmio commented 12 months ago

Unfortunately it is not possible. The UI element calls the cover.close_cover_tilt and the service expects the cover tilt to close. There is no "close cover stepwise" service in HA. Imho it was implemented wrong before.

Feel free to get a second opinion about that - I don't even have tiltable covers, so no idea how other integrations manage those things.

Ad 1: you can use knx.send to send the telegram you like.

h3rbst commented 12 months ago

@farmio So why does the KNX integration offers the possibility to maintain the move_short_address when it is not possible to use it?

Edit: And the documentation says move_short_address: "KNX group address for moving the cover stepwise up or down. "

h3rbst commented 12 months ago

@marvin-w would love to hear you opinion as well if possible? Do you have raffstores or just normal roller shutters?

farmio commented 12 months ago

To stop the cover. Or to move covers that don't support angle positions.

h3rbst commented 12 months ago

@farmio Home Assistant KNX documentation says move_short_address: "KNX group address for moving the cover stepwise up or down. "

elupus commented 11 months ago

@h3rbst yes that is correct. It's the address for moving step wise. The problem is that HA architecture have no notion/api to perform that command. The buttons in UI that was used before was not intended for that purpose. KNX integration need to adhere to how home assistant architecture is defined.

I do agree stepwise move would make sense in both the tilt and position features. But it needs to be fixed at another level first.

issue-triage-workflows[bot] commented 8 months ago

There hasn't been any activity on this issue recently. Due to the high number of incoming GitHub notifications, we have to clean some of the old issues, as many of them have already been resolved with the latest updates. Please make sure to update to the latest Home Assistant version and check if that solves the issue. Let us know if that works for you by adding a comment 👍 This issue has now been marked as stale and will be closed if no further activity occurs. Thank you for your contributions.