home-assistant / core

:house_with_garden: Open source home automation that puts local control and privacy first.
https://www.home-assistant.io
Apache License 2.0
71.82k stars 30.08k forks source link

ASUSWRT integration failed to set up #99346

Closed Eisoniq closed 1 year ago

Eisoniq commented 1 year ago

The problem

Since Home Assistant version 2023.8.0 the ASUSWRT integration seems to be broken, it says "Failed to set up" and all my previous entities are now unavailable, on 2023.7.3 this was/is still working correctly. My router is an Asus RT-AX88U on the latest Merlin firmware, tried multiple router firmwares and none seemed to work after Home Asstistant version 2023.8.0.

What version of Home Assistant Core has the issue?

core-2023.8.0

What was the last working version of Home Assistant Core?

core-2023.7.3

What type of installation are you running?

Home Assistant Container

Integration causing the issue

ASUSWRT

Link to integration documentation on our website

https://www.home-assistant.io/integrations/asuswrt/

Diagnostics information

No response

Example YAML snippet

No response

Anything in the logs that might be useful for us?

No response

Additional information

No response

home-assistant[bot] commented 1 year ago

Hey there @kennedyshead, @ollo69, mind taking a look at this issue as it has been labeled with an integration (asuswrt) you are listed as a code owner for? Thanks!

Code owner commands Code owners of `asuswrt` can trigger bot actions by commenting: - `@home-assistant close` Closes the issue. - `@home-assistant rename Awesome new title` Renames the issue. - `@home-assistant reopen` Reopen the issue. - `@home-assistant unassign asuswrt` Removes the current integration label and assignees on the issue, add the integration domain after the command.

(message by CodeOwnersMention)


asuswrt documentation asuswrt source (message by IssueLinks)

ollo69 commented 1 year ago

Can you provide error logs from HA?

Eisoniq commented 1 year ago

Where would I find a the errors logs, "Download diagnostics" isn't an option?

ollo69 commented 1 year ago

No, is not diagnostics. For logs go to Settings -> System -> Registry. You could also try to download diagnostic, but if integration fail to load probably it doesn't contain information.

Eisoniq commented 1 year ago

I've got this one in Settings -> System -> Logs:

Logger: homeassistant.config_entries
Source: helpers/entity_registry.py:905
First occurred: 19:07:49 (1 occurrences)
Last logged: 19:07:49

Error setting up entry 192.168.50.1 for asuswrt
Traceback (most recent call last):
  File "/usr/src/homeassistant/homeassistant/config_entries.py", line 388, in async_setup
    result = await component.async_setup_entry(hass, self)
             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/src/homeassistant/homeassistant/components/asuswrt/__init__.py", line 17, in async_setup_entry
    await router.setup()
  File "/usr/src/homeassistant/homeassistant/components/asuswrt/router.py", line 256, in setup
    self._migrate_entities_unique_id()
  File "/usr/src/homeassistant/homeassistant/components/asuswrt/router.py", line 217, in _migrate_entities_unique_id
    entity_reg.async_update_entity(entity_id, new_unique_id=unique_id)
  File "/usr/src/homeassistant/homeassistant/helpers/entity_registry.py", line 959, in async_update_entity
    return self._async_update_entity(
           ^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/src/homeassistant/homeassistant/helpers/entity_registry.py", line 905, in _async_update_entity
    raise ValueError(
ValueError: Unique id '3d2b0d525c0c76f0fc03bd1b95bc8dab_sensor_tx_bytes' is already in use by 'sensor.asuswrt_upload
ollo69 commented 1 year ago

This is a strange condition, looks like you have duplicated entities ID for your entry. I think that faster solution is to remove this configuration entry and reconfigure your router. Could you try this?

Eisoniq commented 1 year ago

Ugh, thank you, simply removing and then re-adding it fixed it, should've tried that myself before coming here Thank you very much for the help, fast replies and making this integration, sorry for wasting your time

ollo69 commented 1 year ago

sorry for wasting your time

Not wasting my time at all, good to know that this fixed.👍 For sure there is a little bug in entity ID migration introduced in 2023.8, but I think that is related to some very limited configuration condition and for sure is faster reconfigure the integration that try to provide a fix and wait for a new release.