home-assistant / developers.home-assistant

Developers website for Home Assistant.
https://developers.home-assistant.io
Other
295 stars 933 forks source link

Improve documentation of collapsible sections in data entry flows #2288

Closed emontnemery closed 2 weeks ago

emontnemery commented 2 weeks ago

Proposed change

Improve documentation of collapsible sections in data entry flows

Type of change

Additional information

Summary by CodeRabbit

coderabbitai[bot] commented 2 weeks ago
Walkthrough ## Walkthrough The changes introduce enhancements to the `ExampleConfigFlow` class within the `data_entry_flow` module, focusing on the organization of input fields. A new section for grouping input fields has been added, detailing the structure for visual organization. Additionally, a new key, `section`, has been incorporated into form translations, allowing for improved naming and description of sections, as well as the organization of fields within those sections. ## Changes | Files | Change Summary | |-----------------------------------------|----------------------------------------------------------------------------------------------------| | docs/data_entry_flow_index.md | Added a new section on grouping input fields and expanded the form translations to include a `section` key. | ## Sequence Diagram(s) ```mermaid sequenceDiagram participant User participant ConfigFlow participant FormTranslations User->>ConfigFlow: Request input form ConfigFlow->>FormTranslations: Fetch field translations FormTranslations-->>ConfigFlow: Return translations including sections ConfigFlow-->>User: Display organized input form with sections ```

Recent review details **Configuration used: CodeRabbit UI** **Review profile: CHILL**
Commits Files that changed from the base of the PR and between 613d1190f31809dfeb828a4d8e787aefcee5e42a and 9f13bb612ba5a56f51a798e55ad991385b240b2e.
Files selected for processing (1) * docs/data_entry_flow_index.md (2 hunks)
Additional context used
Path-based instructions (1)
docs/data_entry_flow_index.md (6) Pattern `*/**(html|markdown|md)`: - For instructional content in documentation, use a direct and authoritative tone. Avoid expressions of politeness such as 'may' or 'please', and ensure the goal of the instruction is fronted. - Apply the Microsoft Style Guide to ensure documentation maintains clarity and conciseness. - In step-by-step instructions, front the location phrase in the instructional sentence. - In step-by-step instructions, front the 'goal' in the instructional sentence. - In step-by-step instructions, if in doubt what to front, front the 'goal' before the location phrase in the instructional sentence. - do not hyphenate terms like 'top-right' or 'bottom-left' with 'corner' --- Pattern `*/**(html|markdown|md)`: - Use bold to mark UI strings. - If "" are used to mark UI strings, replace them by bold. --- Pattern `*/**(html|markdown|md)`: - Be brief in your replies and don't add fluff like "thank you for..." and "Please let me know if" --- Pattern `*/**(html|markdown|md)`: - Use sentence-style capitalization also in headings. --- Pattern `*/**(html|markdown|md)`: do not comment on HTML used for icons --- Pattern `*/**(html|markdown|md)`: Avoid flagging inline HTML for embedding videos in future reviews for this repository.
LanguageTool
docs/data_entry_flow_index.md
[grammar] ~179-~179: Possible typo detected: Did you mean to write ‘from’ instead of ‘form’? Context: ...----------- | | `title` | Form heading | Do not include your brand... (TYPO_FORM_FROM)
Additional comments not posted (4)
docs/data_entry_flow_index.md (4)
`154-171`: **LGTM!** The new section "Grouping of input fields" is clear and concise. It effectively explains how to group input fields and provides a helpful example. The code changes are approved. --- `177-183`: **LGTM!** The addition of the `section` key to the form translations table is a valuable enhancement. It provides clearer guidelines for developers on how to name and describe sections and specify field data and descriptions within those sections. The code changes are approved.
Tools
LanguageTool
[grammar] ~179-~179: Possible typo detected: Did you mean to write ‘from’ instead of ‘form’? Context: ...----------- | | `title` | Form heading | Do not include your brand... (TYPO_FORM_FROM)
--- `195-211`: **LGTM!** The example of the field labels and descriptions dictionary is clear and effectively demonstrates how to use the `section` key in the form translations. The code changes are approved. --- `179-179`: **Correct the typo.** Possible typo detected: Did you mean to write ‘from’ instead of ‘form’? Apply this diff to fix the typo: ```diff - Form heading + From heading ``` > Likely invalid or redundant comment.
Tools
LanguageTool
[grammar] ~179-~179: Possible typo detected: Did you mean to write ‘from’ instead of ‘form’? Context: ...----------- | | `title` | Form heading | Do not include your brand... (TYPO_FORM_FROM)
--- Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?
Share - [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)
Tips ### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit .` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai generate interesting stats about this repository and render them as a table.` - `@coderabbitai show all the console.log statements in this repository.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` - `@coderabbitai help me debug CodeRabbit configuration file.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (invoked as PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger an incremental review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai full review` to do a full review from scratch and review all the files again. - `@coderabbitai summary` to regenerate the summary of the PR. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai configuration` to show the current CodeRabbit configuration for the repository. - `@coderabbitai help` to get help. Additionally, you can add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. ### CodeRabbit Configuration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - Please see the [configuration documentation](https://docs.coderabbit.ai/guides/configure-coderabbit) for more information. - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json` ### Documentation and Community - Visit our [Documentation](https://coderabbit.ai/docs) for detailed information on how to use CodeRabbit. - Join our [Discord Community](https://discord.com/invite/GsXnASn26c) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.