search

home-assistant / devices

Collection of devices
https://home-assistant.github.io/devices/
5 stars 13 forks source link

Not all devices are getting discovered #29

Open raman325 opened 2 weeks ago

raman325 commented 2 weeks ago

I ran into another issue with via_device where the via_device device was not included in the device list. This is happening because the template will only return devices that have entities attached to them. As a result, for hub integrations, you may miss the hubs themselves.

balloob commented 2 weeks ago

I feel like we should instead get a method to just iterate all devices instead of the back this template does. We have same for areas etc

raman325 commented 2 weeks ago

I agree that having a proper export/websocket integration would be better for the device database. But I think this template would be beneficial in general. Example would be to heal every node in a zwave network. Whats your concern with this?

This may not be the right implementation so happy to adjust scope/design based on the convo. Btw this is the same logic reapplied from integration_entities

balloob commented 2 weeks ago

The concern is that bdraco had mentioned the other day that integration_entities is always high up on the profiling list as an expensive function, because of the way it finds integrations. It's also possible that it breaks because integration titles are not unique.