Map card in more-info for persons became not square

ildar170975 commented 2 years ago

Checklist

[X] I have updated to the latest available Home Assistant version.
[X] I have cleared the cache of my browser.
[X] I have tried a different browser to see if it is related to my browser.

Describe the issue you are experiencing

The map card for a person's more-info became not square - which is not good for a map. This is a MAP - not a CAMERA view or something.

Here is a look from 2022.7.4 - here the map is "almost square" (1920x1200 monitor):

The more-info pop-up now has more tabs - so it became wider as it was earlier; but I propose to keep a square (-ish) aspect ratio for a map.

Describe the behavior you expected

The map should be square.

Steps to reproduce the issue

Open a more-info pop-up for a person.

What version of Home Assistant Core has the issue?

2022.11.1

What was the last working version of Home Assistant Core?

No response

In which browser are you experiencing the issue with?

Chrome 107.0.5304.88

Which operating system are you using to run this browser?

Win10x64

State of relevant entities

No response

Problem-relevant frontend configuration

No response

Javascript errors shown in your browser console/inspector

No response

Additional information

No response

WRoss7 commented 2 years ago

I am having the same problem with the map of the robot hoover, now completely out of proportion. I am not familiar with TypeScript, but perhaps the problem is due to #14246.

ildar170975 commented 2 years ago

Could you post a screenshot of your problem? Not sure that these issues are related - probably your vacuum's map is of camera domain.

WRoss7 commented 2 years ago

Hi ildar170975

probably your vacuum's map is of camera domain.

Yes, but imo the problem lies in how the images are reproportioned after the latest UI changes

The card:

A piece of code: type: picture-elements camera_image: camera.xiaomi_cloud_map_extractor camera_view: live title: Roborock S5 elements:

type: icon icon: mdi:play title: Avvia la pulizia tap_action: action: call-service service: vacuum.start service_data: entity_id: vacuum.roborock_s5 style: transform: translate(0%, 0%) left: 30% bottom: 3% color: rgb(0, 0, 0)

ildar170975 commented 1 year ago

When zoomed:

github-actions[bot] commented 1 year ago

There hasn't been any activity on this issue recently. Due to the high number of incoming GitHub notifications, we have to clean some of the old issues, as many of them have already been resolved with the latest updates. Please make sure to update to the latest Home Assistant version and check if that solves the issue. Let us know if that works for you by adding a comment 👍 This issue has now been marked as stale and will be closed if no further activity occurs. Thank you for your contributions.

ildar170975 commented 1 year ago

up

matthiasdebaat commented 1 year ago

The map card for a person's more-info became not square - which is not good for a map. This is a MAP - not a CAMERA view or something.

Please add some rationale why a map needs to be square.

ildar170975 commented 1 year ago

OK, it may not be exactly square (check my post again - I talked about "square-ish") - but it should not be as "low" is it is now:

Especially when the window is stretched out:

When watching a map, a user expects to see where the person is located, and respectively to other objects/points too. When a map is a "band" (a low rectangle) - it is less convenient to use it.

Earlier the map was more "square-ish" and it was more convenient - check a picture from the 1st post:

github-actions[bot] commented 1 year ago

There hasn't been any activity on this issue recently. Due to the high number of incoming GitHub notifications, we have to clean some of the old issues, as many of them have already been resolved with the latest updates. Please make sure to update to the latest Home Assistant version and check if that solves the issue. Let us know if that works for you by adding a comment 👍 This issue has now been marked as stale and will be closed if no further activity occurs. Thank you for your contributions.

ildar170975 commented 1 year ago

up

matthiasdebaat commented 1 year ago

When watching a map, a user expects to see where the person is located, and respectively to other objects/points too. When a map is a "band" (a low rectangle) - it is less convenient to use it.

I find it hard to understand why the shape is the problem here. For example, Google Maps on your phone is a portrait rectangle and works perfectly. Is it more about the default zoom, that you can see other objects/points?

ildar170975 commented 1 year ago

Phone is a different case. Will have to be a rectangle (a small screen), less information can be shown. But for a large desktop monitor there is a possibility to show MORE information. This is not about a zooming - this is about "show more useful information". Thin wide map has LESS info than a more "squarish" map.

Check this: Here all info is important - which is on the left/right, which is on the top/bottom. But in the thin view the top/bottom info is cut.

And think why 2.35:1 movies are less preferable than "open matte".

github-actions[bot] commented 1 year ago

There hasn't been any activity on this issue recently. Due to the high number of incoming GitHub notifications, we have to clean some of the old issues, as many of them have already been resolved with the latest updates. Please make sure to update to the latest Home Assistant version and check if that solves the issue. Let us know if that works for you by adding a comment 👍 This issue has now been marked as stale and will be closed if no further activity occurs. Thank you for your contributions.

ildar170975 commented 12 months ago

Still think that this should be improved.

github-actions[bot] commented 9 months ago

There hasn't been any activity on this issue recently. Due to the high number of incoming GitHub notifications, we have to clean some of the old issues, as many of them have already been resolved with the latest updates. Please make sure to update to the latest Home Assistant version and check if that solves the issue. Let us know if that works for you by adding a comment 👍 This issue has now been marked as stale and will be closed if no further activity occurs. Thank you for your contributions.

ildar170975 commented 9 months ago

up

github-actions[bot] commented 6 months ago

There hasn't been any activity on this issue recently. Due to the high number of incoming GitHub notifications, we have to clean some of the old issues, as many of them have already been resolved with the latest updates. Please make sure to update to the latest Home Assistant version and check if that solves the issue. Let us know if that works for you by adding a comment 👍 This issue has now been marked as stale and will be closed if no further activity occurs. Thank you for your contributions.

ildar170975 commented 5 months ago

up

github-actions[bot] commented 2 months ago

There hasn't been any activity on this issue recently. Due to the high number of incoming GitHub notifications, we have to clean some of the old issues, as many of them have already been resolved with the latest updates. Please make sure to update to the latest Home Assistant version and check if that solves the issue. Let us know if that works for you by adding a comment 👍 This issue has now been marked as stale and will be closed if no further activity occurs. Thank you for your contributions.

ildar170975 commented 2 months ago

Up

home-assistant / frontend