home-assistant / frontend

:lollipop: Frontend for Home Assistant
https://demo.home-assistant.io
Other
4.08k stars 2.8k forks source link

Brand Icons for entities from multiple integrations #14620

Open RASBR opened 1 year ago

RASBR commented 1 year ago

Checklist

Describe the issue you are experiencing

I have some Shelly 1PM (and other models) devices I setup with the same exact steps. Those devices are provided to HA from two integrations Shelly and Unifi Network. The thing is that they are not represented the same in HA especially in regards to Brand Logo!

Attached some screenshots.

Describe the behavior you expected

Device brand icons to be represented according to their manufacturer.

Steps to reproduce the issue

  1. No specific steps!! 01 Multiple Integration Entities 02 Device ONE 03 Device TWO

What version of Home Assistant Core has the issue?

Home Assistant 2022.11.0

What was the last working version of Home Assistant Core?

No response

In which browser are you experiencing the issue with?

Version 108.0.5359.95 (Official Build) (64-bit)

Which operating system are you using to run this browser?

HA is installed on Intel NUC

State of relevant entities

No response

Problem-relevant frontend configuration

No response

Javascript errors shown in your browser console/inspector

No response

Additional information

No response

github-actions[bot] commented 1 year ago

There hasn't been any activity on this issue recently. Due to the high number of incoming GitHub notifications, we have to clean some of the old issues, as many of them have already been resolved with the latest updates. Please make sure to update to the latest Home Assistant version and check if that solves the issue. Let us know if that works for you by adding a comment πŸ‘ This issue has now been marked as stale and will be closed if no further activity occurs. Thank you for your contributions.

steverep commented 1 year ago

This is still relevant

github-actions[bot] commented 1 year ago

There hasn't been any activity on this issue recently. Due to the high number of incoming GitHub notifications, we have to clean some of the old issues, as many of them have already been resolved with the latest updates. Please make sure to update to the latest Home Assistant version and check if that solves the issue. Let us know if that works for you by adding a comment πŸ‘ This issue has now been marked as stale and will be closed if no further activity occurs. Thank you for your contributions.

steverep commented 1 year ago

Still relevant IMO

spacegaier commented 1 year ago

Yes, still relevant. There is an arch discussion that will potentially enhance the backend so we can reliably get the information from there. That would then help the frontend to show the correct info: https://github.com/home-assistant/architecture/discussions/936

steverep commented 1 year ago

@spacegaier I do believe that proposal would help the situation, but would not completely solve the icon issue. I'll comment more there.

mpoettgen commented 1 year ago

Experiencing the same problem for Shelly devices with a combination of the Shelly integration and a "AVM FRITZ!Box Tools" integration. Expecting to see Shelly icons for the Shelly devices, but some (not all) are represented by FRITZ icons.

vdrHorst commented 1 year ago

There seems to be an architectural discussion on auto determining primairy or secondary integration of a device. Hope that can be addressed soon as the different brand icons are at least confusing. But is there a workaround known for (manual) correction? Should I remove the second integration, so all double registrations fall back to its remaining integration as primary, after which I can reinstall the second integration? My concerned integrations on this topic are primary Shelly devices and secondary Ubiquity network.

GitHubGoody commented 1 year ago

+1

All of these should indicate ESPHome as the primary integration. I've even disabled the UniFi device tracker on each of them. image

github-actions[bot] commented 9 months ago

There hasn't been any activity on this issue recently. Due to the high number of incoming GitHub notifications, we have to clean some of the old issues, as many of them have already been resolved with the latest updates. Please make sure to update to the latest Home Assistant version and check if that solves the issue. Let us know if that works for you by adding a comment πŸ‘ This issue has now been marked as stale and will be closed if no further activity occurs. Thank you for your contributions.

ozwo71 commented 8 months ago

+1 I have the same issue. The icon in the device list should be configurable (set to the "main" integration). E.g. Sonos/Ubiquiti: grafik grafik grafik

Same with ESPHome/Ubiquiti: grafik

It seems that the icon in the device list is taken from the first integration that is listed in the device info.

It would be nice to make this configurable (set "main" integration for device).

Thank you

ozwo71 commented 8 months ago

This makes it clear: grafik

The icon is not taken from the "Manufacturer" but from the first entry in the "Integration" column of the device list. I would expect the icon is defined by manufacturer.

(Screenshot was taken from Frontend 20240306.0, Core/Supervisor 2024.3.0)

dacootmeister commented 7 months ago

I encounter the same with Asusrouter integration, Sonos, Samsung and Homewizard devices image image

Tomanic-glitch commented 7 months ago

Can confirm this happens to me as well, e.g. the TP-Link plugs sometimes having Nmap icons instead of TP-Link based on which integration is listed first

image

samedarkclouds commented 6 months ago

Still relevant. Battery notes and Unifi are destroying any sort by integration I attempt....

ThomasHeinrichSchmidt commented 6 months ago

Same issue, it's confusing, did not find a workaround to swap the integrations. Would like to see Shelly icon for all Shellies. Shelly devices

BDBAfH commented 6 months ago

+1

Snowrisk commented 5 months ago

Same here with Shelly, Devolo and ESPHome image

lee-booy commented 4 months ago

Same for me, makes it hard to quickly identify devices when everything has a Unifi icon against it :)

Cyruz143 commented 4 months ago

I'd also like to see this resolved.

If you wanted a nice, UX friendly solution, you could make the device info panel a list where you can drag the order of the integration around, top one being the primary.

E.g. image

samedarkclouds commented 4 months ago

Same... this really sucks when trying to organize.

smartypants1138 commented 4 months ago

I would like to see this resolved too, current implementation makes organization difficult and confusing. I propose an option that allows for setting a main vendor for each device.

jouster1974 commented 3 months ago

so I think I have similar wher e a device shows multiple installations....and Im also seeing when some devices are resatrt/changed, they then affect those other integrations

In the below example, the integration is Solarman...but its also showing as UNifi and Utility meter. There is an option to Remove device from Unifi (in red text) but it doesn seem to do anything

Strange behaviour is that if I ever change one of the link integrations, it then advsersely effects the others as well which I am sure shouldnt happen

image

image

smartypants1138 commented 3 months ago

I noticed this on a device page with the wrong icon, this is really sloppy and should be fixed: image

amjadsaadeh commented 2 months ago

Similat problem here, I got a Shelly device and it is primarly assognes to the FRITZ!Box Integration instead to the Shelly integration. It's mainly about the wrong icon.