home-assistant / frontend

:lollipop: Frontend for Home Assistant
https://demo.home-assistant.io
Other
4.13k stars 2.82k forks source link

Ecobee no "hazy" image #16334

Closed MV1707 closed 1 year ago

MV1707 commented 1 year ago

Checklist

Describe the issue you are experiencing

Ecobee integration : The "hazy" weather condition does not have an associated image/icon.

Hint : The actual term on the Ecobee thermostat is "haze"

Ecobee - No hazy image

Describe the behavior you expected

Should have an associated image/icon

Steps to reproduce the issue

1.Edit a custom Dashboard 2.Add a Card 3.Select Entity : wheather.<> 4.Weather condition must be "haze" on your Ecobee ...

What version of Home Assistant Core has the issue?

2023.4.6

What was the last working version of Home Assistant Core?

No response

In which browser are you experiencing the issue with?

Firefox, Edge

Which operating system are you using to run this browser?

W11 Family 22621.1555

State of relevant entities

haze

Problem-relevant frontend configuration

No response

Javascript errors shown in your browser console/inspector

No response

Additional information

No response

karwosts commented 1 year ago

I guess this map in the ecobee core integration is probably the reason:

# Translates ecobee API weatherSymbol to Home Assistant usable names
# https://www.ecobee.com/home/developer/api/documentation/v1/objects/WeatherForecast.shtml
ECOBEE_WEATHER_SYMBOL_TO_HASS = {
    0: ATTR_CONDITION_SUNNY,
    1: ATTR_CONDITION_PARTLYCLOUDY,
    2: ATTR_CONDITION_PARTLYCLOUDY,
    3: ATTR_CONDITION_CLOUDY,
    4: ATTR_CONDITION_CLOUDY,
    5: ATTR_CONDITION_CLOUDY,
    6: ATTR_CONDITION_RAINY,
    7: ATTR_CONDITION_SNOWY_RAINY,
    8: ATTR_CONDITION_POURING,
    9: ATTR_CONDITION_HAIL,
    10: ATTR_CONDITION_SNOWY,
    11: ATTR_CONDITION_SNOWY,
    12: ATTR_CONDITION_SNOWY_RAINY,
    13: "snowy-heavy",
    14: ATTR_CONDITION_HAIL,
    15: ATTR_CONDITION_LIGHTNING_RAINY,
    16: ATTR_CONDITION_WINDY,
    17: "tornado",
    18: ATTR_CONDITION_FOG,
    19: "hazy",
    20: "hazy",
    21: "hazy",
    -2: None,

These are the only conditions that have images in the frontend for weather:

export const weatherIcons = {
  "clear-night": mdiWeatherNight,
  cloudy: mdiWeatherCloudy,
  exceptional: mdiAlertCircleOutline,
  fog: mdiWeatherFog,
  hail: mdiWeatherHail,
  lightning: mdiWeatherLightning,
  "lightning-rainy": mdiWeatherLightningRainy,
  partlycloudy: mdiWeatherPartlyCloudy,
  pouring: mdiWeatherPouring,
  rainy: mdiWeatherRainy,
  snowy: mdiWeatherSnowy,
  "snowy-rainy": mdiWeatherSnowyRainy,
  sunny: mdiWeatherSunny,
  windy: mdiWeatherWindy,
  "windy-variant": mdiWeatherWindyVariant,
};

There are no icons for hazy, tornado, or snowy-heavy.

I know NWS integration maps haze to "exceptional", which displays a circle with an exclamation mark in it. Not claiming that's the right answer or not, but it's what another integration is doing. Meteo seems to map haze to cloudy.

Not sure what the solution should be, but this will just give some breadcrumbs to chase.

karwosts commented 1 year ago

Some of the history of these design decisions seems to be captured here:

https://github.com/home-assistant/architecture/issues/292 https://github.com/home-assistant/architecture/issues/263

https://github.com/home-assistant/frontend/pull/3726

piitaya commented 1 year ago

MDI have snowy-heavy, hazy and tornado icons now. But this needs a core change to support these conditions (see architecture link above) Most weather integrations map these conditions to ATTR_CONDITION_EXCEPTIONAL. The ecobee integration should do this as long as the other conditions are not added

github-actions[bot] commented 1 year ago

There hasn't been any activity on this issue recently. Due to the high number of incoming GitHub notifications, we have to clean some of the old issues, as many of them have already been resolved with the latest updates. Please make sure to update to the latest Home Assistant version and check if that solves the issue. Let us know if that works for you by adding a comment 👍 This issue has now been marked as stale and will be closed if no further activity occurs. Thank you for your contributions.