home-assistant / frontend

:lollipop: Frontend for Home Assistant
https://demo.home-assistant.io
Other
4.08k stars 2.8k forks source link

Wrong name ordering #18014

Closed Grandma-Betty closed 1 year ago

Grandma-Betty commented 1 year ago

Checklist

Describe the issue you are experiencing

Name ordering seems to be borked globally in the frontend, at least for the automations and scripts section so far.

Describe the behavior you expected

The name ordering should only have two behaviours when clicking on the "name" tag where automations/scripts are listed:

Somehow this does not work currently. To get the name order right, it is necessary to click three times on the "name" tag.

Steps to reproduce the issue

  1. Open automations or script menu
  2. Click on "name" tag to start ordering the list

Screenshot 2023-09-25 132058

What version of Home Assistant Core has the issue?

core-2023.9.3

What was the last working version of Home Assistant Core?

No response

In which browser are you experiencing the issue with?

Firefox, Edge

Which operating system are you using to run this browser?

Windows 11

State of relevant entities

No response

Problem-relevant frontend configuration

No response

Javascript errors shown in your browser console/inspector

No response

Additional information

No response

Grandma-Betty commented 1 year ago

Nevermind, I messed up. It's working as intended. Apologies.

ildar170975 commented 1 year ago

@Grandma-Betty Please explain yourself, do you think that sorting works properly? Because I observed a similar issue: https://github.com/home-assistant/frontend/issues/17222

Grandma-Betty commented 1 year ago

@ildar170975 I just mentioned when you move the mouse cursor away from the arrow/name tag after clicking until the list is not in order anymore then the arrow disappears. It was confusing me that the arrow remains there as long as you don't hover your mouse away from it.

ildar170975 commented 1 year ago

The “arrow” you mentioned is an icon located on the left of some column’s header label - correct? Presence or absence of that arrow is not a issue. Are values sorted or not in this column after tapping on that header, how are they sorted - this is the issue. When you created the Guthub issue - you described a wrong sorting. Now you say that there is something wrong with the arrow.

Grandma-Betty commented 1 year ago

Well in my case there are three different behaviours:

1st click: Arrow up: Sorting from A to Z 2nd click: Arrow down: Sorting from Z to A 3rd click: Arrow up (but only until the mouse is being hovered away, then the arrow disappears): No sorting at all

This behaviour seems correct but can confuse people as the "up"-arrow is only disappearing as soon as the mouse is being hovered away from the arrow. I think the perfect solution would be if the arrow would disappear as soon as the 3rd click is being clicked.

ildar170975 commented 1 year ago

No sorting at all

Means - "the initial sorting", right? Can you confirm that the sorting is same as before the 1st click? (open a page, refresh it to a default view - then start "clicking")