Multiple tip windows when dragging history graphs

tomjhou commented 1 year ago

Checklist

[X] I have updated to the latest available Home Assistant version.
[X] I have cleared the cache of my browser.
[X] I have tried a different browser to see if it is related to my browser.

Describe the issue you are experiencing

This issue affects the mobile version.

If I drag any history graph when scrolling the UI, a tip window pops up giving detailed info, even though 99% of the time that is not my intention. I am usually scrolling to see something ELSE (i.e. not the graph).

Not only that, these tip windows are hard to dismiss. They add to existing tip windows, rather than replacing them (see screenshot below with 3 tip windows). And unlike normal tip windows, they can only be dismissed by clicking the SAME graph where it was first triggered. And you have to be super careful, as attempting to dismiss these windows often just causes another to pop up.

Describe the behavior you expected

While it is normal that tapping a history graph opens a tip window, a drag/swipe tap should not do this, since user is usually scrolling to go elsewhere, i.e. NOT the graph. If a tip window does pop up, it should be dismissible the normal way, by clicking anywhere on the UI, not necessarily the exact same window where it first triggered.

Steps to reproduce the issue

Tap AND drag any history graph. This elicits a tool tip window that is hard to get rid of.
Dragging additional history graphs produces tip windows for all of them, with no apparent limit. ...

What version of Home Assistant Core has the issue?

Latest version (as of 2024.4.3).

What was the last working version of Home Assistant Core?

No response

In which browser are you experiencing the issue with?

Any mobile version

Which operating system are you using to run this browser?

Android

State of relevant entities

No response

Problem-relevant frontend configuration

No response

Javascript errors shown in your browser console/inspector

No response

Additional information

No response

RobertD502 commented 1 year ago

Experiencing a similar situation (although, perhaps different since I noticed this when viewing a graph from the History section) and it has made checking specific data points on a graph viewed in the History section when on the iOS companion app a no-go.

When clicking on a data point in the graph, it opens the entity card instead of showing me the value for the selected data point. Video recording below:

https://github.com/home-assistant/frontend/assets/52541649/bab04bdc-3e1d-4709-9411-996de63fff45

As you can see, as soon as I stop scrolling through the data on the graph (raise my finger off of the screen), a new window of the entity pops up. Same behavior occurs if clicking on a single point on the graph.

blandry3 commented 1 year ago

Same issue on 2023.10.1.

del13r commented 1 year ago

This has been annoying me since 2023.10 Only now have I been bothered enough to investigate if anyone else noticed it.

I was going to raise a new issue until I found this issue so I will add my 2cents.

Issue started with 2023.10 Issue occurs in both iOS app and chrome for iOS.

Here is what happens when I use my finger to scroll a page with multiple graphs on it

Then when I actually want to look at a particular graph, the tips shown on the previous page are carried over to the new page and are still visible making it very cluttered and confusing as they are not relevant to the isolated graph being shown.

ColColonCleaner commented 1 year ago

Similar issue here where I'm unable to reliably dismiss the popup once it's activated. Usually requires clicking on the same graph again in order to get the popup to go away.

https://github.com/home-assistant/frontend/assets/1903507/b54606b3-1d8e-4843-a46c-f77b0dd0b49f

del13r commented 10 months ago

Hi, is there any interest in fixing this issue? Issue started with 2023.10 We are now in 2024.1 and the issue is still present.

ColColonCleaner commented 10 months ago

It was there before 2023.10 if I'm remembering correctly. There was a patch for a similar issue around that time, but not this issue. Either way it would be great to see this fixed!

tomjhou commented 9 months ago

Hello, original poster here. I'm glad to see I'm not the only one bothered by this. I'm also surprised this issue is still not fixed. Also, it seems there is a whole other thread on this issue: https://github.com/home-assistant/frontend/issues/18198

github-actions[bot] commented 4 months ago

There hasn't been any activity on this issue recently. Due to the high number of incoming GitHub notifications, we have to clean some of the old issues, as many of them have already been resolved with the latest updates. Please make sure to update to the latest Home Assistant version and check if that solves the issue. Let us know if that works for you by adding a comment 👍 This issue has now been marked as stale and will be closed if no further activity occurs. Thank you for your contributions.

RobertD502 commented 4 months ago

bump

nistvan86 commented 1 month ago

Is there any way to disable pointer interaction with the graph in the meantime to not accidentally trigger this?

Mod: this seems to work. Install https://github.com/thomasloven/lovelace-card-mod (from HACS it's just next-next-finish) then in the YAML code of the graph card definition add

card_mod:
  style: |
    ha-card {
      pointer-events: none;
    }

A refresh of browser and in case of Android app a manual close and restart was required, but then touching the graph has no effect. Better than nothing.

tomjhou commented 1 month ago

Interesting idea, will give it a try! To clarify: I assume disabling pointer events will stop normal tip windows also? Those windows (elicited by simple tap without dragging) are actually useful. Whereas swipe gestures (i.e. tap + drag) produce zombie windows that just won't die.

nistvan86 commented 1 month ago

Yes this stops any tooltips from showing, as it won't register mouse/touch events on the graph anymore. If you find a better targeted CSS selector to only hide the erroneous popus, please share :)

home-assistant / frontend