home-assistant / frontend

:lollipop: Frontend for Home Assistant
https://demo.home-assistant.io
Other
3.9k stars 2.65k forks source link

Cover group buttons disabled by single member of group #18563

Open fishter opened 9 months ago

fishter commented 9 months ago

Conditions:

  1. A cover group containing at least one cover which does not give any feedback on position.
  2. When the cover(s) in the group which do report position are at fully open (or closed) Result: The open (or close) button on the group is disabled, removing the possibility to use the group control to open (or close) the non-reporting shutter.

If a cover does not report position then the buttons controlling that shutter should not be disabled, as the system cannot know the position of the shutter. The cover group shown here (top card) shows the close button disabled. The individual covers are shown in the bottom card; here we see that the second cover can be controlled. image

Describe the behavior you expected

If a cover group member is not reporting its position, it is wrong to assume it is in a particular position and then disable control buttons. If any member of a cover group does not report position then the UI should leave the open/close buttons enabled at all times.

Steps to reproduce the issue

  1. Create a cover group with at least two members. One cover reports position, the other does not.
  2. Close the reporting cover.
  3. You cannot now close the non-reporting cover using the group commands.

What version of Home Assistant Core has the issue?

2023.11.1

What was the last working version of Home Assistant Core?

No response

In which browser are you experiencing the issue with?

Google Chrome 119.0.6045.106

Which operating system are you using to run this browser?

Windows 11 22H@ 22621.206 1000.22677.1000.0

State of relevant entities

Cover 1 (closed)
current_position: 0
device_class: shutter
friendly_name: Velux Mezzanine
supported_features: 15

Cover 1 (open)
current_position: 100
device_class: shutter
friendly_name: Velux Mezzanine
supported_features: 15

Cover 2 (open or closed)
assumed_state: true
device_class: shutter
friendly_name: Volet Mezzanine
supported_features: 11

Cover group (cover 1 closed, cover 2 open or closed)
current_position: 0
entity_id:
  - cover.velux_mezzanine
  - cover.volet_mezzanine
friendly_name: Upstairs shutters
supported_features: 15

Cover group (cover 1 open, cover 2 open or closed)
current_position: 100
entity_id:
  - cover.velux_mezzanine
  - cover.volet_mezzanine
friendly_name: Upstairs shutters
supported_features: 15

Problem-relevant frontend configuration

- type: entities
        entities:
          - cover.upstairs_shutters
      - type: entities
        entities:
          - cover.velux_mezzanine
          - cover.volet_mezzanine

Javascript errors shown in your browser console/inspector

No response

Additional information

No response

piitaya commented 9 months ago

Does it worked before? The UI is based on cover capabilities using supported_features and assumed_state. Your cover group doesn't have assumed_state and have current_position = 0 so the close button is disabled.

It's a core issue for the cover group integration. @emontnemery Can this be related to https://github.com/home-assistant/core/pull/99391 ? Should we set assumed state for group if at least one children have assumed_state?

fishter commented 9 months ago

This may have worked before. I am a recent convert to Home Assistant, so may not have noticed if the change #99391 had an effect.

github-actions[bot] commented 6 months ago

There hasn't been any activity on this issue recently. Due to the high number of incoming GitHub notifications, we have to clean some of the old issues, as many of them have already been resolved with the latest updates. Please make sure to update to the latest Home Assistant version and check if that solves the issue. Let us know if that works for you by adding a comment 👍 This issue has now been marked as stale and will be closed if no further activity occurs. Thank you for your contributions.

fishter commented 6 months ago

This issue is not solved with the latest versions of Home Assistant. @piitaya's suggestion of the assumed state seems to be on the right track for solving this. As a workaround I have an automation that moves my shutter off the endstops (0% or 100%) to avoid the issue; but that's not a great solution.

github-actions[bot] commented 3 months ago

There hasn't been any activity on this issue recently. Due to the high number of incoming GitHub notifications, we have to clean some of the old issues, as many of them have already been resolved with the latest updates. Please make sure to update to the latest Home Assistant version and check if that solves the issue. Let us know if that works for you by adding a comment 👍 This issue has now been marked as stale and will be closed if no further activity occurs. Thank you for your contributions.

fishter commented 3 months ago

Issue still present in release 2024.5.2

fishter commented 1 month ago

Issue still present in 2024.7.1