Sliders (and maybe more) are missing on-primary styling

KTibow commented 7 months ago

Checklist

[X] I have updated to the latest available Home Assistant version.
[X] I have cleared the cache of my browser.
[X] I have tried a different browser to see if it is related to my browser.

Describe the issue you are experiencing

ha-slider has no on-primary styling this makes it look bad when the primary color isn't dark

Describe the behavior you expected

it should set on-primary to --text-primary-color

Steps to reproduce the issue

go to a more info of a media player with a volume slider or anywhere else with a slider. observe styles.

What version of Home Assistant Core has the issue?

2023.11.1

silamon commented 6 months ago

We need to come up with a default theme and some research should happen for material design 3. I think that should be done by the core team working on this. Unfortunately, it's not easy to pick this up, since the package isn't complete as of now and the codebase is large. I'm not sure right now, if we should continue to adopt this given that there's still many issues with it next to not being complete.

I will open a PR if you don't plan to fix this, so this one gets fixed.

github-actions[bot] commented 3 months ago

There hasn't been any activity on this issue recently. Due to the high number of incoming GitHub notifications, we have to clean some of the old issues, as many of them have already been resolved with the latest updates. Please make sure to update to the latest Home Assistant version and check if that solves the issue. Let us know if that works for you by adding a comment 👍 This issue has now been marked as stale and will be closed if no further activity occurs. Thank you for your contributions.

KTibow commented 3 months ago

/unstale

github-actions[bot] commented 1 week ago

There hasn't been any activity on this issue recently. Due to the high number of incoming GitHub notifications, we have to clean some of the old issues, as many of them have already been resolved with the latest updates. Please make sure to update to the latest Home Assistant version and check if that solves the issue. Let us know if that works for you by adding a comment 👍 This issue has now been marked as stale and will be closed if no further activity occurs. Thank you for your contributions.

KTibow commented 1 week ago

confirmed still present on https://demo.home-assistant.io

home-assistant / frontend