home-assistant / frontend

:lollipop: Frontend for Home Assistant
https://demo.home-assistant.io
Other
4.08k stars 2.79k forks source link

Color Temp should not change icon color #19435

Open damusmf opened 3 years ago

damusmf commented 3 years ago

The problem

https://github.com/home-assistant/core/pull/55219

this PR forces color temp lights to report RGB values to change the color of the icon, breaking the aesthetics of most themes and leaving it almost impossible to distinguish between lights that are on vs off at a glance. As lights that are off are white and lights that cool white are also the same white.

What is version of Home Assistant Core has the issue?

core-2021.9.5

What was the last working version of Home Assistant Core?

core-2021.8.8

What type of installation are you running?

Home Assistant OS

Integration causing the issue

No response

Link to integration documentation on our website

No response

Example YAML snippet

No response

Anything in the logs that might be useful for us?

No response

Additional information

Most themes, the off color of icons is white. So if lights are on cool white they are now also white and impossible to distinguish from off. And when on and warm white they have an orangy icon. These icons used to follow the current theme and only adjust based on brightness while maintaining the color of the theme.

image here the Lamps are ON but cool white, the ceiling and closet are off. Previously they would have been the themes color for on, in this case yellow.

image Top 3 are not color temp lights while the bottom 3 are, completely breaking the consistency of the theme and every other icon.

Different attributes when on vs off image image

Color temp bulbs are not RGB and the attribute shouldn't be forced onto the entities. This was a "bug" previously when lights were reporting incorrect supported features, https://github.com/home-assistant/core/issues/52661, and now it is baked in as an actual "feature".