home-assistant / frontend

:lollipop: Frontend for Home Assistant
https://demo.home-assistant.io
Other
3.99k stars 2.72k forks source link

Can't get past disabled overflow menu items with keyboard #20002

Open karwosts opened 7 months ago

karwosts commented 7 months ago

Checklist

Describe the issue you are experiencing

In the automation editor overflow menus, I can move up and down the list by pressing up/down arrows on the keyboard.

But once I reach a disabled item (Move up in this case), I can't go down any further. I can press up/down to go between items 1-5 in this list, but there doesn't seem to be any way to get past them to reach the Edit/Disable/Delete options.

image

Describe the behavior you expected

Can press down arrow 10 times to reach the Delete option.

Steps to reproduce the issue

1. 2. 3. ...

What version of Home Assistant Core has the issue?

2024.3

What was the last working version of Home Assistant Core?

No response

In which browser are you experiencing the issue with?

chrome & firefox

Which operating system are you using to run this browser?

Windows

State of relevant entities

No response

Problem-relevant frontend configuration

No response

Javascript errors shown in your browser console/inspector

No response

Additional information

No response

jackwilsdon commented 6 months ago

This appears to be a bug in mwc-list, specifically this code which attempts to focus the next element (it doesn't check if the next element is actually focusable):

https://github.com/material-components/material-web/blob/c1e876a15bc028034781984538ea803ba67dbed3/packages/list/mwc-list-foundation.ts#L315-L329

HA seems to be using an old version of material-web, so I think this might have to be fixed with a custom MDCListFoundation type.

github-actions[bot] commented 3 months ago

There hasn't been any activity on this issue recently. Due to the high number of incoming GitHub notifications, we have to clean some of the old issues, as many of them have already been resolved with the latest updates. Please make sure to update to the latest Home Assistant version and check if that solves the issue. Let us know if that works for you by adding a comment 👍 This issue has now been marked as stale and will be closed if no further activity occurs. Thank you for your contributions.

karwosts commented 3 months ago

keep

github-actions[bot] commented 3 weeks ago

There hasn't been any activity on this issue recently. Due to the high number of incoming GitHub notifications, we have to clean some of the old issues, as many of them have already been resolved with the latest updates. Please make sure to update to the latest Home Assistant version and check if that solves the issue. Let us know if that works for you by adding a comment 👍 This issue has now been marked as stale and will be closed if no further activity occurs. Thank you for your contributions.