home-assistant / frontend

:lollipop: Frontend for Home Assistant
https://demo.home-assistant.io
Other
3.8k stars 2.6k forks source link

Fan widget does not allow to pan the fan. (zhimi.fan.za4) #20021

Open DooMMasteR opened 4 months ago

DooMMasteR commented 4 months ago

Checklist

Describe the issue you are experiencing

The "direction drop down" is weirdly indicating "forward" and "reverse" and either can only be selected once. Once selected the fan moves a bit into the direction but the element is now selected and the can cannot be moved again into the same direction.

Screenshot from 2024-03-08 00-13-54

image

Describe the behavior you expected

I would expect 2 buttons, that can be repeatedly pressed to move the fan further than just a tad.

Steps to reproduce the issue

  1. Open the Fan widget
  2. click on direction
  3. select forward or reverse
  4. try to select the previous item again. ...

What version of Home Assistant Core has the issue?

2024.3.0

What was the last working version of Home Assistant Core?

No response

In which browser are you experiencing the issue with?

any browser

Which operating system are you using to run this browser?

Linux, Windows, Mac OS 14

State of relevant entities

No response

Problem-relevant frontend configuration

No response

Javascript errors shown in your browser console/inspector

No response

Additional information

No response

pvxe commented 2 months ago

Just my two cents, I also have a similar issue with a dmaker.fan.p10 (though the exact model of fan may be irrelevant for this issue).

Before https://github.com/home-assistant/frontend/pull/17540 I could turn the fan left or right by pressing the relevant button multiple times from the older frontend, unfortunately this is no longer the case with the new frontend.

karwosts commented 2 months ago

Is that really the intended function of set_direction, to set the orientation? Feels almost like that integration is using it as a mis-appropriation of what the feature is supposed to mean.

I don't know but I am assuming direction means whether the blades are spinning in a clockwise or counterclockwise fashion, not something that is intended to allow for changing the angle of the direction of the blowing.

pvxe commented 2 months ago

Is that really the intended function of set_direction, to set the orientation? Feels almost like that integration is using it as a mis-appropriation of what the feature is supposed to mean.

I don't know but I am assuming direction means whether the blades are spinning in a clockwise or counterclockwise fashion, not something that is intended to allow for changing the angle of the direction of the blowing.

Well if we take a look at https://github.com/home-assistant/frontend/blob/7120ad99b9bdd3d6dc648deb6ae5285d986f8744/src/fake_data/demo_services.ts#L922-L932 then you are absolutely right.

I'm not aware of any domestic floor/pedestal fan that is intended to provide functionality such as to change the blade turning direction/orientation. This functionality strikes to me as something related to ceiling fans.

Just giving my two cents as a user here, maybe there should be some distinction between blade direction (for ceiling fans) and pedestal fan orientation, which seems to be the case for this particular issue.

Cheers!