Energy Solar Graph forecast not correctly drawn when using multiple forecasts

N3rdix commented 3 months ago

Checklist

[X] I have updated to the latest available Home Assistant version.
[X] I have cleared the cache of my browser.
[X] I have tried a different browser to see if it is related to my browser.
[ ] I have tried reproducing the issue in safe mode to rule out problems with unsupported custom resources.

Describe the issue you are experiencing

After adding a second forecast.solar integration with much lower values than the main one I observed strange graph values in the solar-graph-forecast card. It seems the forecast values are not interpreted correctly in the graph although the legend shows the correct values. As indicated on the screenshot both markers on the line seem to be wrong:

This does only happen with 2 forecasts, if I disable the main one the new one displays correct values (screenshot from test-system without production data):

Describe the behavior you expected

the dotted lines should be correctly drawn also in case of multiple forecasts

Steps to reproduce the issue

Not sure if this prob1. add a forecast.solar integration with relatively low production values (mine is 860 Wp, Azimuth 219°, 25° angle)

go to the energy dashboard and check if the solar forecast dotted line meets the values of the integration

What version of Home Assistant Core has the issue?

2024.3.3

What was the last working version of Home Assistant Core?

No response

In which browser are you experiencing the issue with?

Chrome, Edge, companion App

Which operating system are you using to run this browser?

Windows, iOS

State of relevant entities

No response

Problem-relevant frontend configuration

No response

Javascript errors shown in your browser console/inspector

No response

Additional information

No response

karwosts commented 3 months ago

AFAIK these are intended to "stack" in the same way that multiple solar productions stack. That way the height of your forecast(s) match with the height of your stack of productions.

Is that what you're trying to say is "wrong" about them, that you don't think that is correct behavior?

N3rdix commented 3 months ago

I was not aware the lines are also "stacked" as they seem to be 2 separate lines. Of course the sum of both is represented by the top line, but from my perspective it is wrong to treat the lines as a stock unless they are not visually stacked like the production.

The line (in my example with a value of 0.17 Wh) has a value on the y-axis of >1.6. If I would sum up the individual values based on their y-axis value it would be wrong.

In case this is really the intended behavior maybe we can make it obvious that multiple forecasts are stacked/summed up as well?

karwosts commented 3 months ago

Looks like this has been discussed a bit before, but both stale'd out without resolution.

https://github.com/home-assistant/frontend/issues/16192 https://github.com/home-assistant/frontend/issues/15011

N3rdix commented 3 months ago

Oh right, didn't see them before.

At least @bramkragten made a proposal which would at least display correct values. Downside: it's just one line and hides the details of individual forecasts.

Maybe we can continue the discussion on how it should look like in future, I'm pretty sure more and more people will have multiple forecasts for multiple solar production systems as they get cheaper and more "main-stream" due to Plug & Play...

github-actions[bot] commented 1 week ago

There hasn't been any activity on this issue recently. Due to the high number of incoming GitHub notifications, we have to clean some of the old issues, as many of them have already been resolved with the latest updates. Please make sure to update to the latest Home Assistant version and check if that solves the issue. Let us know if that works for you by adding a comment 👍 This issue has now been marked as stale and will be closed if no further activity occurs. Thank you for your contributions.

home-assistant / frontend