When creating a label on the fly, the input text is not use to pre-fill the form - Githubissues

home-assistant / frontend

:lollipop: Frontend for Home Assistant

https://demo.home-assistant.io

Other

4.06k stars 2.78k forks source link

When creating a label on the fly, the input text is not use to pre-fill the form #20226

Closed jlpouffier closed 7 months ago

jlpouffier commented 7 months ago

Checklist

[X] I have updated to the latest available Home Assistant version.
[X] I have cleared the cache of my browser.
[X] I have tried a different browser to see if it is related to my browser.
[ ] I have tried reproducing the issue in safe mode to rule out problems with unsupported custom resources.

Describe the issue you are experiencing

How to reproduce

Try to add a label
Start typing on the label selector a new label title (Something that does not exist yet)
The only option available is "Create a new label"
Click on it

Wanted behavior: The input text used to filter the labels is used to prefill the form Actual behavior: The form is empty

https://github.com/home-assistant/frontend/assets/5878296/2f9137f4-6798-4597-94e4-0d6c8590b78e

Describe the behavior you expected

Wanted behavior: The input text used to filter the labels is used to prefill the form Actual behavior: The form is empty

Steps to reproduce the issue

Try to add a label
Start typing on the label selector a new label title (Something that does not exist yet)
The only option available is "Create a new label"
Click on it

What version of Home Assistant Core has the issue?

2024.4.0b0

What was the last working version of Home Assistant Core?

Not applicable: New feature

In which browser are you experiencing the issue with?

Arc Version 1.35.0 (47750)

Which operating system are you using to run this browser?

macOS 14.4 (23E214)

State of relevant entities

No response

Problem-relevant frontend configuration

No response

Javascript errors shown in your browser console/inspector

No response

Additional information

No response

Mincka commented 7 months ago

I think this will be superseded by the suggested option here: https://github.com/home-assistant/frontend/issues/20218

That seems to be a better approach from a UX perspective. The user should be invited to use the menu to add the label with the modal, not type it directly in the field for a new label.

Alternatively, since the icon and color are currently not mandatory, clicking "Add a new label", could not show the modal at all if new label is typed in the field, just creating if on the fly and adding it directly.

Personally I prefer the first option (only #20218) since it's a one time action and it's better to show the attributes that can be associated with a label.