home-assistant / frontend

:lollipop: Frontend for Home Assistant
https://demo.home-assistant.io
Other
3.99k stars 2.72k forks source link

Create backup dialog: two close buttons #20918

Open SeanPM5 opened 4 months ago

SeanPM5 commented 4 months ago

Checklist

Describe the issue you are experiencing

Similar issue to https://github.com/home-assistant/frontend/issues/20910 ... The create backup dialog has two close buttons.

Screen Shot 2024-05-30 at 3 12 34 AM

Describe the behavior you expected

Only one close button, icon-based one in the top right. Text-based button in bottom left shouldn't be there.

Steps to reproduce the issue

  1. Go to Settings → System → Backups Open your Home Assistant instance and Deprecated, use 'supervisor_backups' instead.
  2. Click "Create backup"
  3. Look at dialog, two close buttons

What version of Home Assistant Core has the issue?

2024.5.5

What was the last working version of Home Assistant Core?

No response

In which browser are you experiencing the issue with?

No response

Which operating system are you using to run this browser?

No response

State of relevant entities

No response

Problem-relevant frontend configuration

No response

Javascript errors shown in your browser console/inspector

No response

Additional information

No response

matthiasdebaat commented 4 months ago

Close should be cancel. This flow could use some redesign in general.

github-actions[bot] commented 1 month ago

There hasn't been any activity on this issue recently. Due to the high number of incoming GitHub notifications, we have to clean some of the old issues, as many of them have already been resolved with the latest updates. Please make sure to update to the latest Home Assistant version and check if that solves the issue. Let us know if that works for you by adding a comment 👍 This issue has now been marked as stale and will be closed if no further activity occurs. Thank you for your contributions.

SeanPM5 commented 1 month ago

Not stale