home-assistant / frontend

:lollipop: Frontend for Home Assistant
https://demo.home-assistant.io
Other
3.99k stars 2.72k forks source link

Android Navigation Back gesture activates buttons on dashboard #21042

Open dbaq opened 3 months ago

dbaq commented 3 months ago

Checklist

Describe the issue you are experiencing

There is a long thread (with reproducing steps, some troubleshooting, and even a solution) on the https://github.com/home-assistant/android repo but it looks like it is a home-assistant/frontend issue.

The android back gesture seems to activate the button which is present below the trace of the finger while performing the gesture (on finger lift-off). This is not the case for other apps I tested (e.g outlook, twitter, calculator, etc), therefore it seems to be an issue with the app.

Could this please be prioritized as it is impacting all Android users that have Android gestures enabled?

Thank you.

Describe the behavior you expected

Starting the swipe back gesture should not "activate" any cards.

Steps to reproduce the issue

See this https://github.com/home-assistant/android/issues/3565 and this specific comment

What version of Home Assistant Core has the issue?

2024.4.0

What was the last working version of Home Assistant Core?

No response

In which browser are you experiencing the issue with?

No response

Which operating system are you using to run this browser?

No response

State of relevant entities

No response

Problem-relevant frontend configuration

No response

Javascript errors shown in your browser console/inspector

No response

Additional information

No response

metheos commented 3 months ago

Would love if this was fixed. I just started using HA this year and find myself diving deep into customizing my dashboards every day! I've had to avoid using subviews because of this issue, they're too hard to navigate out of with the back gesture getting 'caught' on dashboard elements.

milnivlek commented 2 months ago

This really needs to be fixed. I have a subview for light controls, and keep triggering lights accidentally while swiping to go back to the main view. Just last night, I accidentally turned on the nursery light while my baby daughter was sleeping. Please fix this for the sake of the next generation! :)

strikeir13 commented 2 months ago

I encountered this recently when I changed some mushroom cards to tile cards. It is much, much more difficult to cause the false trigger when using mushroom cards than using tile cards. Maybe it's related to the fact that the tile card allows for different actions to be taken when tapping the icon vs the card itself (outside the icon), whereas mushroom does not. Edit: I was wrong, it doesn't seem to matter whether it is mushroom cards or HA-native tile cards, the issue persists quite significantly.

dbaq commented 2 months ago

I encountered this recently when I changed some mushroom cards to tile cards. It is much, much more difficult to cause the false trigger when using mushroom cards than using tile cards. Maybe it's related to the fact that the tile card allows for different actions to be taken when tapping the icon vs the card itself (outside the icon), whereas mushroom does not.

I am using mushroom cards (latest version) exclusively and still face the issue very frequently on my end.

Lackmake commented 3 weeks ago

There is a potential fix in the android issue thread mentioned above, just nobody able to setup the whole dev/test suite. https://github.com/home-assistant/android/issues/3565#issuecomment-1906393991