home-assistant / frontend

:lollipop: Frontend for Home Assistant
https://demo.home-assistant.io
Other
4.04k stars 2.76k forks source link

False positive in bridged matter device detection leads to missing UI for matter devices, that are connected via a non-matter device #21415

Open MrEbbinghaus opened 3 months ago

MrEbbinghaus commented 3 months ago

Checklist

Describe the issue you are experiencing

The frontend incorrectly decides that any matter device with the via_device_id attribute to be a bridged matter device.

A WiFi router may set via_device for network devices, but that's not the same as a "bridged device" in matter terms.

Describe the behavior you expected

Correctly detect if the device is a bridged matter device.

Steps to reproduce the issue

Create a single-node matter device that has any via_device set.

What version of Home Assistant Core has the issue?

2024.7.2

What was the last working version of Home Assistant Core?

No response

The situation

The AVM Fritz!Box Tools integration for WiFi routers creates a HA device for every connected device (wifi or ethernet). It also sets the via_device attribute for these devices. (It is unclear to me if this is semantically correct. see this comment https://github.com/home-assistant/core/pull/121257#issuecomment-2231842565)

The issue

The frontend uses the via_device_id field (here HaDeviceInfoMatter and getMatterDeviceActions) to detect if the device is a bridged Matter device and if it is, it doesn't show the Matter specific device information panel content.

image

This issue is related to this PR https://github.com/home-assistant/core/pull/121257, as it allows matter devices to be merged with existing devices using their hardware addresses. See: Defining devices - connections

github-actions[bot] commented 2 weeks ago

There hasn't been any activity on this issue recently. Due to the high number of incoming GitHub notifications, we have to clean some of the old issues, as many of them have already been resolved with the latest updates. Please make sure to update to the latest Home Assistant version and check if that solves the issue. Let us know if that works for you by adding a comment 👍 This issue has now been marked as stale and will be closed if no further activity occurs. Thank you for your contributions.

MrEbbinghaus commented 1 week ago

The issue has not been resolved as of frontend version 20241002.3