Open NoRi2909 opened 1 week ago
@j4n-e4t Thanks for taking care of the bug report. I try to figure out where I can see the actual changes in the PR to verify, but there is so much overhead for such a simple rewording that I can't tell the forest from the trees 🤓
@j4n-e4t Now I have it …
Was scrolling up and down and overlooked the Tab at the top to https://github.com/home-assistant/frontend/pull/22416/commits/d19feb6f7d3bcbdeffe591ee6e6c725d356b711b
The change from "Humidifier" to "Hygrostat" seems to me missing, or not?
Hygrostat
You're right, I've missed that. Changed it now.
Describe the issue you are experiencing
There are several issues with the naming and description of the Thermostat and Humidifier (should be Hygrostat) cards.
Describe the behavior you expected
The current description for the Thermostat card is found in:
https://github.com/home-assistant/frontend/blob/5175b4206958512c142dc400e0498d26d3a2ed8e/src/translations/en.json#L6141-L6145
That grammar is broken, should be fixed by using a comma: "The Thermostat card gives control of your climate entity, allowing you to change the temperature and mode of the entity."
But that "your" is also misleading, you can have many climate entities for all your rooms etc., and it should be noted that this works for heating and cooling.
Suggestion:
"The Thermostat card gives control of a climate entity for heating or cooling, allowing you to set its mode and desired temperature."
Similar, but with several inconsistencies:
https://github.com/home-assistant/frontend/blob/5175b4206958512c142dc400e0498d26d3a2ed8e/src/translations/en.json#L5985-L5989
Here we have an additional problem, because first of all this should be called "Hygrostat card" like the "Thermostat card" above. And this can control both humidifiers and dehumidifiers, just like heating and cooling above.
So here a suggested complete rewording:
"The Hygrostat card gives control of a humidifier entity for humidifying or dehumdifying, allowing you to set its mode and desired humidity."
Along this fix the name needs to be changed, matching the naming from the Thermostat above.
Steps to reproduce the issue
The thermostat string seems to be replaced by a graphic, but the humidifier text still shows up when adding a card to the dashboard.
What version of Home Assistant Core has the issue?
core-2024.10.1
Additional information
I tested this by creating two helper entities for HVAC and humidifier / dehumdifier.