home-assistant / frontend

:lollipop: Frontend for Home Assistant
https://demo.home-assistant.io
Other
4.01k stars 2.74k forks source link

Matter: ping_node::battery_device_warning missing a word or two #22344

Open NoRi2909 opened 6 days ago

NoRi2909 commented 6 days ago

Checklist

Describe the issue you are experiencing

The string

  ui::panel::config::matter::ping_node::battery_device_warning

Is currently:

"Note that especially for battery powered devices this can take a a while. You may need to up powered devices before starting the pinging to speed up the process. Refer to your device's manual for instructions on how to wake the device."

Describe the behavior you expected

I assume that should be "wake up battery powered" instead, given the ID of the string?

Then this could be shortened a bit, too:

"Note that especially for battery powered devices this can take a a while. You may need to wake those up before …"

Steps to reproduce the issue

n/a

What version of Home Assistant Core has the issue?

core-2024.10.2

What was the last working version of Home Assistant Core?

n/a

In which browser are you experiencing the issue with?

Google Chrome 130.0.6723.25 beta (64-Bit)

Which operating system are you using to run this browser?

Chrome OS

State of relevant entities

No response

Problem-relevant frontend configuration

No response

Javascript errors shown in your browser console/inspector

No response

Additional information

No response

silamon commented 5 days ago

Not sure, if you are looking to contribute to these issues. These specific translation changes doesn't require you to build anything.

1) Make a fork 2) Create a branch for each specific issue 3) Change github.com to github.dev (or open with dot) 4) Navigate to the translations folder / en.json and make the changes 5) Push to the branch and open a PR

NoRi2909 commented 5 days ago

@silamon I will do so in the coming weeks, but for the moment I'm overwhelmed with fixing the German translation in time for the next release. So please take care of these in the next days.

I will start with direct PRs soon. :-)