home-assistant / frontend

:lollipop: Frontend for Home Assistant
https://demo.home-assistant.io
Other
4.12k stars 2.81k forks source link

No favourite colours for light groups #22369

Open aidanharris opened 1 month ago

aidanharris commented 1 month ago

Checklist

Describe the issue you are experiencing

I can't seem to find a way to set favourite colours for a light group. Is this intentional?

Describe the behavior you expected

I should be able to maintain a set of favourite colours for a group of lights

Steps to reproduce the issue

Make a group of lights in configuration.yaml:

light:
  - platform: group
    name: "Aidan's Bedroom Lights"
    entities:
      - light.aidans_bedroom_main
      - light.aidans_bedroom_lamp

Restart home assistant and observe that you can set colours from the picker but there is no list of favourites to choose from. I don't care if it takes the favourites from the first light or maintains a dedicated list of favourites for the group but doing neither seems like an omission.

What version of Home Assistant Core has the issue?

2024.10.2 (Frontend: 20241002.3)

What was the last working version of Home Assistant Core?

N/A

In which browser are you experiencing the issue with?

Firefox Nightly: Mozilla/5.0 (X11; Linux x86_64; rv:133.0) Gecko/20100101 Firefox/133.0

Which operating system are you using to run this browser?

Linux

State of relevant entities

No response

Problem-relevant frontend configuration

No response

Javascript errors shown in your browser console/inspector

No response

Additional information

No response

karwosts commented 1 month ago

Can you share the attributes of said group, and the source entities?

I have a light group that has a color favorites, so it must be something specific to your particular lights.

aidanharris commented 1 month ago

light.aidan_s_bedroom_lights (this is the group):

min_color_temp_kelvin: 2500
max_color_temp_kelvin: 6500
min_mireds: 153
max_mireds: 400
supported_color_modes: color_temp, hs
color_mode: color_temp
brightness: 255
color_temp_kelvin: 2500
color_temp: 400
hs_color: 28.874, 72.522
rgb_color: 255, 159, 70
xy_color: 0.546, 0.389
entity_id: light.aidans_bedroom_main, light.aidans_bedroom_lamp
icon: mdi:lightbulb-group
friendly_name: Aidan's Bedroom Lights
supported_features: 0

light.aidans_bedroom_main:

    min_color_temp_kelvin: 2500
max_color_temp_kelvin: 6500
min_mireds: 153
max_mireds: 400
supported_color_modes: color_temp, hs
color_mode: color_temp
brightness: 255
color_temp_kelvin: 2500
color_temp: 400
hs_color: 28.874, 72.522
rgb_color: 255, 159, 70
xy_color: 0.546, 0.389
friendly_name: Main
supported_features: 0

light.aidans_bedroom_lamp:

min_color_temp_kelvin: 2500
max_color_temp_kelvin: 6500
min_mireds: 153
max_mireds: 400
supported_color_modes: color_temp, hs
color_mode: color_temp
brightness: 255
color_temp_kelvin: 2500
color_temp: 400
hs_color: 28.874, 72.522
rgb_color: 255, 159, 70
xy_color: 0.546, 0.389
friendly_name: Lamp
supported_features: 0

config_entry-tapo-01JA6DSD8ADTDF9V0D3VX338QH.json config_entry-tapo-01JA5RBNGJ5DH5ESTFC5CF2523.json

Is there anything else I should post?

karwosts commented 1 month ago

Hmm not sure why its not showing for you. Do you see any errors in the browser console?

Is there an option in the overflow menu "Edit favorite colors"?

aidanharris commented 1 month ago

I'm not seeing any errors in the console and the overflow menu just has "Related". It's worth noting I also have this issue in the Home Assistant app as well as every other browser. If I "Inspect Element" on the control there's the "ha-icon-button-group" with the brightness and colour picker but no favourites listed underneath it.

aidanharris commented 1 month ago

This is the ha-attributes-extra:

<ha-attributes extra-filters="brightness,color_temp,color_temp_kelvin,white_value,effect_list,effect,hs_color,rgb_color,rgbw_color,rgbww_color,xy_color,min_mireds,max_mireds,min_color_temp_kelvin,max_color_temp_kelvin,entity_id,supported_color_modes,color_mode" empty=""></ha-attributes>

Compared to this for the main light in the room:

<ha-attributes extra-filters="brightness,color_temp,color_temp_kelvin,white_value,effect_list,effect,hs_color,rgb_color,rgbw_color,rgbww_color,xy_color,min_mireds,max_mireds,min_color_temp_kelvin,max_color_temp_kelvin,entity_id,supported_color_modes,color_mode" empty=""></ha-attributes>

They both look the same as far as I can tell but there are favourites for the individual lights but not the group.