home-assistant / frontend

:lollipop: Frontend for Home Assistant
https://demo.home-assistant.io
Other
4.03k stars 2.75k forks source link

Inconsistent use of "sharing code" for other Matter controllers #22385

Open NoRi2909 opened 1 week ago

NoRi2909 commented 1 week ago

Checklist

Describe the issue you are experiencing

When sharing a Matter device with another controller there generic dialog looks like this:

Screenshot 2024-10-15 18 24 24

Describe the behavior you expected

As indicated in red it should say "setup code" there, too.

Probably "sharing mode" still resonated a bit when writing "sharing code" …

Also the headline should be changed to "Enter setup code" as this is what you do in this dialog.

Steps to reproduce the issue

Here are the two strings:

https://github.com/home-assistant/frontend/blob/b063840f462b1b995c2f4868ac80907bd6af8f5a/src/translations/en.json#L1787-L1788

Noticed while working on the German translation where getting rid of inconsistencies is task #1.

What version of Home Assistant Core has the issue?

core-2024.10.2

What was the last working version of Home Assistant Core?

n/a

In which browser are you experiencing the issue with?

Google Chrome 130.0.6723.25 beta (64-Bit)

Which operating system are you using to run this browser?

Chrome OS

NoRi2909 commented 1 week ago

In addition the sharing dialog for Google Home has a misleading headline and wording, too:

Screenshot 2024-10-15 18 49 37

You are not "linking" those some applications together like we do with the Nabu Casa integration in Google Home.

Here the headline should say "Share from Google Home" as the process uses an Android Sharing dialog, redirecting to the Home Assistant app (as it says at the bottom of the dialog)

Then for clarification it should say "Find your device in the Google Home app".

Finally, I would also make the text at the bottom Step 4 in the list as it gets overlooked easily in the current layout. Essentially swapping the positions of the link and the text at the bottom. But that will need some changes beyond the strings:

https://github.com/home-assistant/frontend/blob/b063840f462b1b995c2f4868ac80907bd6af8f5a/src/translations/en.json#L1756-L1757

I have no idea if the above process also works with the Google Home and Home Assistant apps on iOS. So the dialog might need some additional changes on top.